From: Jason Cooper <jason@lakedaemon.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
Richard Cochran <rcochran@linutronix.de>,
linux-kernel@vger.kernel.org,
Anna-Maria Gleixner <anna-maria@linutronix.de>
Subject: Re: [PATCH] irqchip: armada: avoid unused function warnings
Date: Mon, 18 Jul 2016 19:22:31 +0000 [thread overview]
Message-ID: <20160718192231.GG5814@io.lakedaemon.net> (raw)
In-Reply-To: <20160718160335.3134412-1-arnd@arndb.de>
+ Anna-Maria
Hey Arnd,
On Mon, Jul 18, 2016 at 06:03:21PM +0200, Arnd Bergmann wrote:
> When building with CONFIG_SMP disabled, we get some new harmless warnings:
>
> drivers/irqchip/irq-armada-370-xp.c:356:12: error: 'mpic_cascaded_starting_cpu' defined but not used [-Werror=unused-function]
> static int mpic_cascaded_starting_cpu(unsigned int cpu)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/irqchip/irq-armada-370-xp.c:349:12: error: 'armada_xp_mpic_starting_cpu' defined but not used [-Werror=unused-function]
> static int armada_xp_mpic_starting_cpu(unsigned int cpu)
>
> This moves the unused functions into the #ifdef, as they previously were.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cb5ff2d245c1 ("irqchip/armada-370-xp: Convert to hotplug state machine")
> ---
> drivers/irqchip/irq-armada-370-xp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Anna-Maria, can you make sure this gets pulled in with the cpuhp
changes? afaict, cb5ff2d245c1 is only in the tip/WIP.hotplug and
tip/master.
thx,
Jason.
next prev parent reply other threads:[~2016-07-18 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 16:03 [PATCH] irqchip: armada: avoid unused function warnings Arnd Bergmann
2016-07-18 19:22 ` Jason Cooper [this message]
2016-07-19 7:45 ` [tip:smp/hotplug] irqchip/armada: Avoid " tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718192231.GG5814@io.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=rcochran@linutronix.de \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).