* [PATCH 0947/1285] Replace numeric parameter like 0444 with macro @ 2016-08-02 12:01 Baole Ni 2016-08-02 12:51 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 4+ messages in thread From: Baole Ni @ 2016-08-02 12:01 UTC (permalink / raw) To: mchehab, maurochehab, mchehab, mchehab, m.chehab, gregkh, m.szyprowski, kyungmin.park, k.kozlowski Cc: linux-media, devel, linux-kernel, amitoj1606, arnd, hverkuil, chuansheng.liu, baolex.ni I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- drivers/staging/media/omap1/omap1_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/omap1/omap1_camera.c b/drivers/staging/media/omap1/omap1_camera.c index 54b8dd2..6e125dc 100644 --- a/drivers/staging/media/omap1/omap1_camera.c +++ b/drivers/staging/media/omap1/omap1_camera.c @@ -1692,7 +1692,7 @@ static struct platform_driver omap1_cam_driver = { module_platform_driver(omap1_cam_driver); -module_param(sg_mode, bool, 0644); +module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(sg_mode, "videobuf mode, 0: dma-contig (default), 1: dma-sg"); MODULE_DESCRIPTION("OMAP1 Camera Interface driver"); -- 2.9.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro 2016-08-02 12:01 [PATCH 0947/1285] Replace numeric parameter like 0444 with macro Baole Ni @ 2016-08-02 12:51 ` Mauro Carvalho Chehab 2016-08-02 15:00 ` Randy Dunlap 2016-08-02 19:56 ` Steve Cotton 0 siblings, 2 replies; 4+ messages in thread From: Mauro Carvalho Chehab @ 2016-08-02 12:51 UTC (permalink / raw) To: Baole Ni Cc: mchehab, mchehab, mchehab, m.chehab, gregkh, m.szyprowski, kyungmin.park, k.kozlowski, linux-media, devel, linux-kernel, amitoj1606, arnd, hverkuil, chuansheng.liu Em Tue, 2 Aug 2016 20:01:34 +0800 Baole Ni <baolex.ni@intel.com> escreveu: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. Gah! A patch series with 1285 patches with identical subject! Please don't ever do something like that. My inbox is not trash! Instead, please group the changes per subsystem, and use different names for each patch. Makes easier for people to review. also, you need to send the patches to the subsystem mainatiner, and not adding a random list of people like this: To: gregkh@linuxfoundation.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Btw, use *just* the more recent email of the maintainer, instead of spamming trash to all our emails (even to the ones that we don't use anymore! I'll just send all those things to /dev/null until you fix your email sending process. Regards, Mauro > > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> > Signed-off-by: Baole Ni <baolex.ni@intel.com> > --- > drivers/staging/media/omap1/omap1_camera.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/omap1/omap1_camera.c b/drivers/staging/media/omap1/omap1_camera.c > index 54b8dd2..6e125dc 100644 > --- a/drivers/staging/media/omap1/omap1_camera.c > +++ b/drivers/staging/media/omap1/omap1_camera.c > @@ -1692,7 +1692,7 @@ static struct platform_driver omap1_cam_driver = { > > module_platform_driver(omap1_cam_driver); > > -module_param(sg_mode, bool, 0644); > +module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(sg_mode, "videobuf mode, 0: dma-contig (default), 1: dma-sg"); > > MODULE_DESCRIPTION("OMAP1 Camera Interface driver"); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro 2016-08-02 12:51 ` Mauro Carvalho Chehab @ 2016-08-02 15:00 ` Randy Dunlap 2016-08-02 19:56 ` Steve Cotton 1 sibling, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2016-08-02 15:00 UTC (permalink / raw) To: Mauro Carvalho Chehab, Baole Ni Cc: devel, k.kozlowski, mchehab, arnd, gregkh, linux-media, mchehab, hverkuil, kyungmin.park, m.szyprowski, chuansheng.liu, mchehab, linux-kernel, m.chehab On 08/02/16 05:51, Mauro Carvalho Chehab wrote: > Em Tue, 2 Aug 2016 20:01:34 +0800 > Baole Ni <baolex.ni@intel.com> escreveu: > >> I find that the developers often just specified the numeric value >> when calling a macro which is defined with a parameter for access permission. >> As we know, these numeric value for access permission have had the corresponding macro, >> and that using macro can improve the robustness and readability of the code, >> thus, I suggest replacing the numeric parameter with the macro. > > Gah! > > A patch series with 1285 patches with identical subject! > > Please don't ever do something like that. My inbox is not trash! > > Instead, please group the changes per subsystem, and use different > names for each patch. Makes easier for people to review. > > also, you need to send the patches to the subsystem mainatiner, and > not adding a random list of people like this: > > To: gregkh@linuxfoundation.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com > > Btw, use *just* the more recent email of the maintainer, instead of > spamming trash to all our emails (even to the ones that we don't use > anymore! > > I'll just send all those things to /dev/null until you fix your > email sending process. > +1285 There are people at Intel who know about things like this. -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro 2016-08-02 12:51 ` Mauro Carvalho Chehab 2016-08-02 15:00 ` Randy Dunlap @ 2016-08-02 19:56 ` Steve Cotton 1 sibling, 0 replies; 4+ messages in thread From: Steve Cotton @ 2016-08-02 19:56 UTC (permalink / raw) To: Baole Ni Cc: Mauro Carvalho Chehab, gregkh, m.szyprowski, kyungmin.park, k.kozlowski, linux-media, devel, linux-kernel, amitoj1606, arnd, hverkuil, chuansheng.liu On Tue, Aug 02, 2016 at 09:51:18AM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 2 Aug 2016 20:01:34 +0800 Baole Ni <baolex.ni@intel.com> escreveu: > > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access permission. > > As we know, these numeric value for access permission have had the corresponding macro, > > and that using macro can improve the robustness and readability of the code, > > thus, I suggest replacing the numeric parameter with the macro. > > Gah! > > A patch series with 1285 patches with identical subject! > > Please don't ever do something like that. My inbox is not trash! > > Instead, please group the changes per subsystem, and use different > names for each patch. Makes easier for people to review. Hi Baole, It may also be worth waiting for the first group to be reviewed before sending the other groups, in case the review comments change what you send later. > > -module_param(sg_mode, bool, 0644); > > +module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); There's an S_IRUGO macro which makes the above just 'S_IRUGO | S_IWUSR'. Regards, Steve ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-02 20:13 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-08-02 12:01 [PATCH 0947/1285] Replace numeric parameter like 0444 with macro Baole Ni 2016-08-02 12:51 ` Mauro Carvalho Chehab 2016-08-02 15:00 ` Randy Dunlap 2016-08-02 19:56 ` Steve Cotton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).