From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add MDB support
Date: Wed, 31 Aug 2016 16:56:04 +0200 [thread overview]
Message-ID: <20160831145604.GF15078@lunn.ch> (raw)
In-Reply-To: <874m618095.fsf@ketchup.mtl.sfl>
> Do you mean the something like this?
>
> if (obj->id == SWITCHDEV_OBJ_ID_PORT_FDB) {
> ...
> } else if (obj->id == SWITCHDEV_OBJ_ID_PORT_MDB) {
> ...
> } else {
> return -EOPNOTSUPP;
> }
Hi Vivien
The -ENONOTSUPP is even better. I was not going as far as that.
> No the signatures are differentes. See _fdb vs. _mdb.
Ah, missed that. Then two functions are O.K. I don't think we should
consolidate it in the DSA layer.
Andrew
next prev parent reply other threads:[~2016-08-31 14:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 20:32 [PATCH net-next 0/3] net: dsa: add MDB support Vivien Didelot
2016-08-29 20:32 ` [PATCH net-next 1/3] " Vivien Didelot
2016-08-31 13:25 ` Andrew Lunn
2016-08-31 14:22 ` Vivien Didelot
2016-08-31 14:33 ` Andrew Lunn
2016-08-31 14:57 ` Vivien Didelot
2016-08-31 15:03 ` Andrew Lunn
2016-08-29 20:32 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: make switchdev DB ops generic Vivien Didelot
2016-08-31 13:49 ` Andrew Lunn
2016-08-31 14:39 ` Vivien Didelot
2016-08-31 14:53 ` Andrew Lunn
2016-08-31 15:05 ` Vivien Didelot
2016-08-29 20:32 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: add MDB support Vivien Didelot
2016-08-31 13:57 ` Andrew Lunn
2016-08-31 14:46 ` Vivien Didelot
2016-08-31 14:56 ` Andrew Lunn [this message]
2016-08-31 17:33 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831145604.GF15078@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).