From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add MDB support
Date: Wed, 31 Aug 2016 20:33:54 +0300 [thread overview]
Message-ID: <74ccc395-74ca-26a9-fa3b-02880c4fdc27@cogentembedded.com> (raw)
In-Reply-To: <874m618095.fsf@ketchup.mtl.sfl>
Hello.
On 08/31/2016 05:46 PM, Vivien Didelot wrote:
>>> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
>>> index 93abfff..812cb47 100644
>>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>>> @@ -2240,6 +2240,15 @@ static int mv88e6xxx_port_db_dump_one(struct mv88e6xxx_chip *chip,
>>> fdb->ndm_state = NUD_NOARP;
>>> else
>>> fdb->ndm_state = NUD_REACHABLE;
>>> + } else {
>>
>> Rather than else, i think it would be safer to do
>>
>> if (obj->id == SWITCHDEV_OBJ_ID_PORT_MDB) {
>>> + struct switchdev_obj_port_mdb *mdb;
>>> +
>>> + if (!is_multicast_ether_addr(addr.mac))
>>> + continue;
>>> +
>>> + mdb = SWITCHDEV_OBJ_PORT_MDB(obj);
>>> + mdb->vid = vid;
>>> + ether_addr_copy(mdb->addr, addr.mac);
>>> }
>>
>> It should not happen, but the day it does, we get very confused...
>
> Do you mean the something like this?
>
> if (obj->id == SWITCHDEV_OBJ_ID_PORT_FDB) {
> ...
> } else if (obj->id == SWITCHDEV_OBJ_ID_PORT_MDB) {
> ...
> } else {
> return -EOPNOTSUPP;
> }
>
> I'm OK with that if you think it is better.
Just code it as a *switch*, please. :-)
[...]
MBR, Sergei
prev parent reply other threads:[~2016-08-31 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 20:32 [PATCH net-next 0/3] net: dsa: add MDB support Vivien Didelot
2016-08-29 20:32 ` [PATCH net-next 1/3] " Vivien Didelot
2016-08-31 13:25 ` Andrew Lunn
2016-08-31 14:22 ` Vivien Didelot
2016-08-31 14:33 ` Andrew Lunn
2016-08-31 14:57 ` Vivien Didelot
2016-08-31 15:03 ` Andrew Lunn
2016-08-29 20:32 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: make switchdev DB ops generic Vivien Didelot
2016-08-31 13:49 ` Andrew Lunn
2016-08-31 14:39 ` Vivien Didelot
2016-08-31 14:53 ` Andrew Lunn
2016-08-31 15:05 ` Vivien Didelot
2016-08-29 20:32 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: add MDB support Vivien Didelot
2016-08-31 13:57 ` Andrew Lunn
2016-08-31 14:46 ` Vivien Didelot
2016-08-31 14:56 ` Andrew Lunn
2016-08-31 17:33 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ccc395-74ca-26a9-fa3b-02880c4fdc27@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).