linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 1/3] net: dsa: add MDB support
Date: Wed, 31 Aug 2016 10:57:27 -0400	[thread overview]
Message-ID: <871t157zqg.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <20160831143315.GD15078@lunn.ch>

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> > Does the bridge code use multicast group when referring to L2?
>> 
>> The switchdev MDB attribute is very similary to the FDB attribute. It
>> contains the VLAN ID and the Ethernet MAC address of the group.
>
> I'm just trying to avoid the use of 'multicast group' for a L2 entity,
> unless it is already widespread used so in the bridge code. If the
> bridge code does consider L2 a 'multciast group', fine, lets document
> it so. But if the bridge code only uses 'multciast group' to mean L3,
> we should not use it here for L2.

I am not quite sure about that. I can see that SWITCHDEV_OBJ_ID_PORT_MDB
is only crafted in net/bridge/br_mdb.c:__br_mdb_notify().

What should we do if the bridge code consider a multicast group as L3?

Thanks,

        Vivien

  reply	other threads:[~2016-08-31 14:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29 20:32 [PATCH net-next 0/3] net: dsa: add MDB support Vivien Didelot
2016-08-29 20:32 ` [PATCH net-next 1/3] " Vivien Didelot
2016-08-31 13:25   ` Andrew Lunn
2016-08-31 14:22     ` Vivien Didelot
2016-08-31 14:33       ` Andrew Lunn
2016-08-31 14:57         ` Vivien Didelot [this message]
2016-08-31 15:03           ` Andrew Lunn
2016-08-29 20:32 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: make switchdev DB ops generic Vivien Didelot
2016-08-31 13:49   ` Andrew Lunn
2016-08-31 14:39     ` Vivien Didelot
2016-08-31 14:53       ` Andrew Lunn
2016-08-31 15:05         ` Vivien Didelot
2016-08-29 20:32 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: add MDB support Vivien Didelot
2016-08-31 13:57   ` Andrew Lunn
2016-08-31 14:46     ` Vivien Didelot
2016-08-31 14:56       ` Andrew Lunn
2016-08-31 17:33       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t157zqg.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).