From: Rob Herring <robh@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Joel Stanley <joel@jms.id.au>,
Alexandre Courbot <gnurou@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Kerr <jk@ozlabs.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers
Date: Fri, 2 Sep 2016 10:00:45 -0500 [thread overview]
Message-ID: <20160902150045.GA17024@rob-hp-laptop> (raw)
In-Reply-To: <20160830075427.11493-5-andrew@aj.id.au>
On Tue, Aug 30, 2016 at 05:24:23PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> Acked-by: Joel Stanley <joel@jms.id.au>
> ---
> .../devicetree/bindings/gpio/gpio-aspeed.txt | 36 ++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
Acked-by: Rob Herring <robh@kernel.org>
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
> new file mode 100644
> index 000000000000..09f26cac18d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
> @@ -0,0 +1,36 @@
> +Aspeed GPIO controller Device Tree Bindings
> +-------------------------------------------
> +
> +Required properties:
> +- #gpio-cells : Should be two
> + - First cell is the GPIO line number
> + - Second cell is used to specify optional
> + parameters (unused)
> +
> +- compatible : Either "aspeed,ast2400-gpio" or "aspeed,ast2500-gpio"
I'd prefer this be listed first if you respin this.
> +
> +- reg : Address and length of the register set for the device
> +- gpio-controller : Marks the device node as a GPIO controller.
> +- interrupts : Interrupt specifier (see interrupt bindings for
> + details)
> +- interrupt-controller : Mark the GPIO controller as an interrupt-controller
> +
> +Optional properties:
> +
> +- interrupt-parent : The parent interrupt controller, optional if inherited
> +
> +The gpio and interrupt properties are further described in their respective
> +bindings documentation:
> +
> +- Documentation/devicetree/bindings/gpio/gpio.txt
> +- Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> +
> + Example:
> + gpio@1e780000 {
> + #gpio-cells = <2>;
> + compatible = "aspeed,ast2400-gpio";
> + gpio-controller;
> + interrupts = <20>;
> + reg = <0x1e780000 0x1000>;
> + interrupt-controller;
> + };
> --
> 2.9.3.1.g0db844e
>
next prev parent reply other threads:[~2016-09-02 15:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 7:54 [PATCH v3 0/8] aspeed: Add pinctrl and gpio drivers Andrew Jeffery
2016-08-30 7:54 ` [PATCH v3 1/8] MAINTAINERS: Add glob for Aspeed devicetree bindings Andrew Jeffery
2016-09-07 14:37 ` Linus Walleij
2016-09-07 14:42 ` Arnd Bergmann
2016-08-30 7:54 ` [PATCH v3 2/8] syscon: dt-bindings: Add documentation for Aspeed system control units Andrew Jeffery
2016-09-07 14:38 ` Linus Walleij
2016-09-07 16:30 ` Lee Jones
2016-09-08 1:03 ` Andrew Jeffery
2016-09-08 1:01 ` Andrew Jeffery
2016-09-08 7:01 ` Lee Jones
2016-08-30 7:54 ` [PATCH v3 3/8] pinctrl: dt-bindings: Add documentation for Aspeed pin controllers Andrew Jeffery
2016-09-07 14:40 ` Linus Walleij
2016-08-30 7:54 ` [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers Andrew Jeffery
2016-09-02 15:00 ` Rob Herring [this message]
2016-09-07 14:43 ` Linus Walleij
2016-09-08 1:19 ` Andrew Jeffery
2016-08-30 7:54 ` [PATCH v3 5/8] pinctrl: Add core support for Aspeed SoCs Andrew Jeffery
2016-09-07 14:50 ` Linus Walleij
2016-09-08 3:58 ` Andrew Jeffery
2016-08-30 7:54 ` [PATCH v3 6/8] pinctrl: Add pinctrl-aspeed-g4 driver Andrew Jeffery
2016-09-07 14:53 ` Linus Walleij
2016-08-30 7:54 ` [PATCH v3 7/8] pinctrl: Add pinctrl-aspeed-g5 driver Andrew Jeffery
2016-09-07 14:54 ` Linus Walleij
2016-08-30 7:54 ` [PATCH v3 8/8] gpio: Add Aspeed driver Andrew Jeffery
2016-09-07 14:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902150045.GA17024@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).