From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Joel Stanley <joel@jms.id.au>,
Alexandre Courbot <gnurou@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeremy Kerr <jk@ozlabs.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 5/8] pinctrl: Add core support for Aspeed SoCs
Date: Wed, 7 Sep 2016 16:50:54 +0200 [thread overview]
Message-ID: <CACRpkdb2ftH5B5VqKW9rPU=LMeWjrfo9jBTP5DKbNYeZAoMC8Q@mail.gmail.com> (raw)
In-Reply-To: <20160830075427.11493-6-andrew@aj.id.au>
On Tue, Aug 30, 2016 at 9:54 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> The Aspeed SoCs typically provide more than 200 pins for GPIO and other
> functions. The signal enabled on a pin is determined on a priority
> basis, where a given pin can provide a number of different signal types.
>
> In addition to the priority levels, the Aspeed pin controllers describe
> the signal active on a pin by compound logical expressions involving
> multiple operators, registers and bits. Some difficulty arises as a
> pin's function bit masks for each priority level are frequently not the
> same (i.e. we cannot just flip a bit to change from a high to low
> priority signal), or even in the same register(s). Some configuration
> bits affect multiple pins, while in other cases the signals for a bus
> must each be enabled individually.
>
> Together, these features give rise to some complexity in the
> implementation. A more complete description of the complexities is
> provided in the associated header file.
>
> The patch doesn't implement pinctrl/pinmux/pinconf for any particular
> Aspeed SoC, rather it adds the framework for defining pinmux
> configurations.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
Patch applied! It's not getting better than this through iteration, it is better
to get the system up and develop inside the mainline tree from now on.
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1027,6 +1027,7 @@ S: Maintained
> F: arch/arm/mach-aspeed/
> F: arch/arm/boot/dts/aspeed-*
> F: drivers/*/*aspeed*
> +F: drivers/pinctrl/aspeed/
> F: Documentation/devicetree/bindings/*/*aspeed*
I dropped this hunk of the patch, because:
(A) I didn't merge the glob patch and
(B) the glob covers this driver too, it is a tautology/truism
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-09-07 14:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 7:54 [PATCH v3 0/8] aspeed: Add pinctrl and gpio drivers Andrew Jeffery
2016-08-30 7:54 ` [PATCH v3 1/8] MAINTAINERS: Add glob for Aspeed devicetree bindings Andrew Jeffery
2016-09-07 14:37 ` Linus Walleij
2016-09-07 14:42 ` Arnd Bergmann
2016-08-30 7:54 ` [PATCH v3 2/8] syscon: dt-bindings: Add documentation for Aspeed system control units Andrew Jeffery
2016-09-07 14:38 ` Linus Walleij
2016-09-07 16:30 ` Lee Jones
2016-09-08 1:03 ` Andrew Jeffery
2016-09-08 1:01 ` Andrew Jeffery
2016-09-08 7:01 ` Lee Jones
2016-08-30 7:54 ` [PATCH v3 3/8] pinctrl: dt-bindings: Add documentation for Aspeed pin controllers Andrew Jeffery
2016-09-07 14:40 ` Linus Walleij
2016-08-30 7:54 ` [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers Andrew Jeffery
2016-09-02 15:00 ` Rob Herring
2016-09-07 14:43 ` Linus Walleij
2016-09-08 1:19 ` Andrew Jeffery
2016-08-30 7:54 ` [PATCH v3 5/8] pinctrl: Add core support for Aspeed SoCs Andrew Jeffery
2016-09-07 14:50 ` Linus Walleij [this message]
2016-09-08 3:58 ` Andrew Jeffery
2016-08-30 7:54 ` [PATCH v3 6/8] pinctrl: Add pinctrl-aspeed-g4 driver Andrew Jeffery
2016-09-07 14:53 ` Linus Walleij
2016-08-30 7:54 ` [PATCH v3 7/8] pinctrl: Add pinctrl-aspeed-g5 driver Andrew Jeffery
2016-09-07 14:54 ` Linus Walleij
2016-08-30 7:54 ` [PATCH v3 8/8] gpio: Add Aspeed driver Andrew Jeffery
2016-09-07 14:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdb2ftH5B5VqKW9rPU=LMeWjrfo9jBTP5DKbNYeZAoMC8Q@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).