From: Peter Chen <hzpeterchen@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Leo Li <pku.leo@gmail.com>, Felipe Balbi <balbi@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, lkml <linux-kernel@vger.kernel.org>,
Stuart Yoder <stuart.yoder@nxp.com>,
Scott Wood <oss@buserror.net>,
David Fisher <david.fisher1@synopsys.com>,
"Thang Q. Nguyen" <tqnguyen@apm.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev
Date: Tue, 6 Sep 2016 14:35:29 +0800 [thread overview]
Message-ID: <20160906063529.GA22312@b29397-desktop> (raw)
In-Reply-To: <4865343.bOXkeC8XtQ@wuerfel>
On Mon, Sep 05, 2016 at 05:39:27PM +0200, Arnd Bergmann wrote:
> On Friday, September 2, 2016 5:16:31 PM CEST Leo Li wrote:
> >
> > Can we use the firmware or bootloader information to provide the
> > default dma-mapping attributes for devices that doesn't have an
> > of_node pointer or ACPI data? This will at least restore what we had
> > previously provided . I'm concerned that changing all the drivers
> > that are creating child device will be a big effort. Like I mentioned
> > in another thread, there are many instances of platform_device_add()
> > under the drivers/ directory.
>
> Fortunately, there are not too many drivers that call platform_device_add
> *and* try to set up a dma mask for the child device:
>
> git grep -wl dma_mask drivers | xargs grep -wl 'platform_device_\(add\|register\)'
>
> drivers/base/platform.c
> drivers/bcma/main.c
> drivers/eisa/virtual_root.c
> drivers/mfd/mfd-core.c
> drivers/mfd/omap-usb-host.c
> drivers/misc/mic/card/mic_x100.c
> drivers/platform/goldfish/pdev_bus.c
> drivers/ssb/main.c
> drivers/usb/chipidea/core.c
> drivers/usb/dwc3/dwc3-exynos.c
> drivers/usb/dwc3/host.c
> drivers/usb/gadget/udc/bdc/bdc_pci.c
> drivers/usb/host/bcma-hcd.c
> drivers/usb/host/fsl-mph-dr-of.c
> drivers/usb/host/ssb-hcd.c
> drivers/usb/misc/ftdi-elan.c
> drivers/usb/musb/blackfin.c
> drivers/usb/musb/musb_dsps.c
> drivers/usb/musb/omap2430.c
> drivers/usb/musb/ux500.c
>
> Most of these are probably never used with any nonstandard
> DMA settings (IOMMU, cache coherency, offset, ...).
>
> One thing we could possibly do is to go through these and
> replace the hardcoded dma mask setup with of_dma_configure()
> in all cases in which we actually use DT for probing, which
> should cover the interesting cases.
>
One case I am going to work is to let USB chipidea driver support iommu,
the chipidea core device is no of_node, and created by
platform_add_device on the runtime. Using of_dma_configure with parent
of_node is a solution from my point, like [1].
https://lkml.org/lkml/2016/2/22/7
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-09-06 6:35 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 19:21 [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Grygorii Strashko
2016-04-26 6:17 ` Felipe Balbi
2016-04-26 8:14 ` Grygorii Strashko
2016-04-27 5:41 ` Felipe Balbi
2016-04-27 11:55 ` Grygorii Strashko
2016-04-27 13:59 ` Catalin Marinas
2016-04-27 14:11 ` Arnd Bergmann
2016-04-27 15:50 ` Catalin Marinas
2016-04-27 16:04 ` Arnd Bergmann
2016-04-27 16:53 ` Felipe Balbi
2016-04-27 17:42 ` Arnd Bergmann
2016-04-27 17:59 ` Alan Stern
2016-04-27 18:08 ` Arnd Bergmann
2016-04-27 20:05 ` Felipe Balbi
2016-04-27 21:05 ` Arnd Bergmann
2016-04-28 6:37 ` Felipe Balbi
2016-04-28 14:16 ` Russell King - ARM Linux
2016-04-28 14:23 ` Arnd Bergmann
2016-04-28 14:27 ` Felipe Balbi
2016-09-01 22:14 ` Leo Li
2016-09-02 10:43 ` Arnd Bergmann
2016-09-02 10:47 ` Russell King - ARM Linux
2016-09-02 11:08 ` Felipe Balbi
2016-09-02 14:11 ` Felipe Balbi
2016-09-02 14:21 ` Alan Stern
2016-09-02 15:51 ` Arnd Bergmann
2016-09-07 7:17 ` Roger Quadros
2016-09-07 8:29 ` Arnd Bergmann
2016-09-07 13:04 ` Roger Quadros
2016-09-07 14:38 ` Arnd Bergmann
2016-09-02 16:23 ` Grygorii Strashko
2016-09-02 10:53 ` Felipe Balbi
2016-09-02 11:55 ` Robin Murphy
2016-09-02 12:56 ` Felipe Balbi
2016-09-02 13:10 ` Arnd Bergmann
2016-09-02 22:16 ` Leo Li
2016-09-05 15:39 ` Arnd Bergmann
2016-09-06 6:35 ` Peter Chen [this message]
2016-09-06 6:40 ` Felipe Balbi
2016-09-06 10:46 ` Arnd Bergmann
2016-09-06 10:50 ` Felipe Balbi
2016-09-06 13:27 ` Arnd Bergmann
2016-09-07 6:51 ` Felipe Balbi
2016-09-07 7:44 ` Peter Chen
2016-09-07 8:52 ` Arnd Bergmann
2016-09-07 9:29 ` Peter Chen
2016-09-07 9:35 ` Russell King - ARM Linux
2016-09-07 10:18 ` Felipe Balbi
2016-09-06 10:38 ` Arnd Bergmann
2016-09-07 6:33 ` Peter Chen
2016-09-07 8:48 ` Arnd Bergmann
2016-09-07 9:55 ` Peter Chen
2016-09-07 10:33 ` Robin Murphy
2016-09-07 10:47 ` Felipe Balbi
2016-09-14 16:31 ` Lorenzo Pieralisi
2016-09-14 21:50 ` Arnd Bergmann
2016-09-07 10:24 ` Felipe Balbi
2016-09-07 15:24 ` Arnd Bergmann
2016-09-07 16:08 ` Alan Stern
2016-09-07 19:45 ` Arnd Bergmann
2016-09-08 1:15 ` Peter Chen
2016-09-08 8:02 ` Arnd Bergmann
2016-09-08 8:03 ` Felipe Balbi
2016-09-08 8:26 ` Arnd Bergmann
2016-09-08 8:29 ` Felipe Balbi
2016-09-08 8:45 ` Arnd Bergmann
2016-09-08 9:43 ` Felipe Balbi
2016-09-08 10:17 ` Arnd Bergmann
2016-09-08 11:00 ` Felipe Balbi
2016-09-08 11:11 ` Arnd Bergmann
2016-09-08 11:20 ` Felipe Balbi
2016-09-08 11:39 ` Arnd Bergmann
2016-09-08 11:52 ` Felipe Balbi
2016-09-08 12:46 ` Arnd Bergmann
2016-09-08 12:02 ` Grygorii Strashko
2016-09-08 12:14 ` Arnd Bergmann
2016-09-08 12:28 ` Peter Chen
2016-09-08 12:52 ` Arnd Bergmann
2016-09-09 1:37 ` Peter Chen
2016-09-08 12:59 ` Grygorii Strashko
2016-09-09 1:52 ` Peter Chen
2016-09-21 11:06 ` Sriram Dash
2016-09-21 11:31 ` Arnd Bergmann
2016-09-21 11:43 ` Sriram Dash
2016-09-21 12:48 ` Arnd Bergmann
2016-09-22 5:02 ` Sriram Dash
2016-10-07 22:46 ` Leo Li
2016-09-21 17:14 ` [PATCH] usb: xhci: Fix the patch inherit dma configuration from kbuild test robot
2016-04-27 20:57 ` [PATCH] usb: dwc3: host: inherit dma configuration from parent dev Felipe Balbi
2016-04-27 14:14 ` Grygorii Strashko
2016-05-05 17:07 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906063529.GA22312@b29397-desktop \
--to=hzpeterchen@gmail.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david.fisher1@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nsekhar@ti.com \
--cc=oss@buserror.net \
--cc=pku.leo@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=stuart.yoder@nxp.com \
--cc=tqnguyen@apm.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).