* linux-next: build failure after merge of the pm tree
@ 2016-09-14 4:27 Stephen Rothwell
2016-09-14 21:38 ` Rafael J. Wysocki
[not found] ` <CGME20160914213244epcas1p12dc9e18680105107404e1715ebcd40f8@epcas1p1.samsung.com>
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2016-09-14 4:27 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-next, linux-kernel, Krzysztof Kozlowski, MyungJoo Ham,
Chanwoo Choi
Hi Rafael,
After merging the pm tree, today's linux-next build (powerpc allyesconfig)
failed like this:
drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
clk_set_min_rate(tegra->emc_clock, rate);
^
Caused by commit
797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
clk_set_min_rate() usage depends on CONFIG_HAVE_CLK.
I added the following for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 14 Sep 2016 14:22:25 +1000
Subject: [PATCH] partial revert of 797da5598f3a ("PM / devfreq: Add
COMPILE_TEST for build coverage")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/devfreq/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index cadd56e50b2c..93b6ada06676 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
config ARM_TEGRA_DEVFREQ
tristate "Tegra DEVFREQ Driver"
- depends on ARCH_TEGRA_124_SOC || COMPILE_TEST
+ depends on ARCH_TEGRA_124_SOC
select DEVFREQ_GOV_SIMPLE_ONDEMAND
select PM_OPP
help
--
2.8.1
--
Cheers,
Stephen Rothwell
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: linux-next: build failure after merge of the pm tree
2016-09-14 4:27 linux-next: build failure after merge of the pm tree Stephen Rothwell
@ 2016-09-14 21:38 ` Rafael J. Wysocki
[not found] ` <CGME20160914213244epcas1p12dc9e18680105107404e1715ebcd40f8@epcas1p1.samsung.com>
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-09-14 21:38 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Krzysztof Kozlowski, MyungJoo Ham,
Chanwoo Choi
On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> Hi Rafael,
>
> After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
> clk_set_min_rate(tegra->emc_clock, rate);
> ^
>
> Caused by commit
>
> 797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
>
> clk_set_min_rate() usage depends on CONFIG_HAVE_CLK.
>
> I added the following for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 14 Sep 2016 14:22:25 +1000
> Subject: [PATCH] partial revert of 797da5598f3a ("PM / devfreq: Add
> COMPILE_TEST for build coverage")
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/devfreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index cadd56e50b2c..93b6ada06676 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
>
> config ARM_TEGRA_DEVFREQ
> tristate "Tegra DEVFREQ Driver"
> - depends on ARCH_TEGRA_124_SOC || COMPILE_TEST
> + depends on ARCH_TEGRA_124_SOC
> select DEVFREQ_GOV_SIMPLE_ONDEMAND
> select PM_OPP
> help
I've just gone ahead and applied it.
Thanks Stephen!
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: Re: linux-next: build failure after merge of the pm tree
[not found] ` <CGME20160914213244epcas1p12dc9e18680105107404e1715ebcd40f8@epcas1p1.samsung.com>
@ 2016-09-19 7:37 ` MyungJoo Ham
2016-09-19 16:12 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: MyungJoo Ham @ 2016-09-19 7:37 UTC (permalink / raw)
To: Rafael J. Wysocki, Stephen Rothwell
Cc: linux-next, linux-kernel, Krzysztof Kozlowski, Chanwoo Choi
[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]
> On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> > failed like this:
> >
> > drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> > drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
> > clk_set_min_rate(tegra->emc_clock, rate);
> > ^
> >
> > Caused by commit
> >
> > 797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
@Rafael: Thank you!
@Kozlowski:
It looks like COMMON_CLK is required to be "selected" for TEGRA.
Although COMMON_CLK is supposed to be widely used by most ARM platforms
especially if "Multiple platfrom selection" for ARMv7 is used,
COMPILE_TEST won't recognize it.
Adding COMMON_CLK for TEGRA will solve this instance of issue; however,
for COMPILE_TEST to be reasonably robust, each "COMPILE_TEST"ed item
should "select" every required item. How do you want to proceed with
COMPILE_TEST on SoC-specific device drivers?
Cheers,
MyungJoo.
> >
> > clk_set_min_rate() usage depends on CONFIG_HAVE_CLK.
> >
> > I added the following for today:
> >
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 14 Sep 2016 14:22:25 +1000
> > Subject: [PATCH] partial revert of 797da5598f3a ("PM / devfreq: Add
> > COMPILE_TEST for build coverage")
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> > drivers/devfreq/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> > index cadd56e50b2c..93b6ada06676 100644
> > --- a/drivers/devfreq/Kconfig
> > +++ b/drivers/devfreq/Kconfig
> > @@ -92,7 +92,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
> >
> > config ARM_TEGRA_DEVFREQ
> > tristate "Tegra DEVFREQ Driver"
> > - depends on ARCH_TEGRA_124_SOC || COMPILE_TEST
> > + depends on ARCH_TEGRA_124_SOC
> > select DEVFREQ_GOV_SIMPLE_ONDEMAND
> > select PM_OPP
> > help
>
> I've just gone ahead and applied it.
>
> Thanks Stephen!
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: linux-next: build failure after merge of the pm tree
2016-09-19 7:37 ` MyungJoo Ham
@ 2016-09-19 16:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-09-19 16:12 UTC (permalink / raw)
To: MyungJoo Ham
Cc: Rafael J. Wysocki, Stephen Rothwell, linux-next, linux-kernel,
Krzysztof Kozlowski, Chanwoo Choi
On Mon, Sep 19, 2016 at 07:37:24AM +0000, MyungJoo Ham wrote:
> > On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> > > Hi Rafael,
> > >
> > > After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> > > failed like this:
> > >
> > > drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> > > drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
> > > clk_set_min_rate(tegra->emc_clock, rate);
> > > ^
> > >
> > > Caused by commit
> > >
> > > 797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
>
> @Rafael: Thank you!
>
>
> @Kozlowski:
>
> It looks like COMMON_CLK is required to be "selected" for TEGRA.
>
> Although COMMON_CLK is supposed to be widely used by most ARM platforms
> especially if "Multiple platfrom selection" for ARMv7 is used,
> COMPILE_TEST won't recognize it.
>
> Adding COMMON_CLK for TEGRA will solve this instance of issue; however,
> for COMPILE_TEST to be reasonably robust, each "COMPILE_TEST"ed item
> should "select" every required item. How do you want to proceed with
> COMPILE_TEST on SoC-specific device drivers?
I think drivers should depend on COMMON_CLK in such case. This tegra
driver probably does not require strict ARCH_TEGRA_124_SOC dependency
because it does not use any SoC-specific data/functions etc. However it
uses common clock framework so explicit dependency looks proper to me.
In fact this is already seen in kernel like SND_SOC_TEGRA, SND_MXS_SOC,
PWM_IMG(with compile test), SND_SOC_RCAR (even without compile test).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-19 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 4:27 linux-next: build failure after merge of the pm tree Stephen Rothwell
2016-09-14 21:38 ` Rafael J. Wysocki
[not found] ` <CGME20160914213244epcas1p12dc9e18680105107404e1715ebcd40f8@epcas1p1.samsung.com>
2016-09-19 7:37 ` MyungJoo Ham
2016-09-19 16:12 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).