[PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Nadim Almas]

Fixed coding style issue.

Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
 drivers/staging/dgnc/dgnc_neo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index e794056..bc15584 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
 		 * Rx Oruns. Exar says that an orun will NOT corrupt
 		 * the FIFO. It will just replace the holding register
 		 * with this new data byte. So basically just ignore this.
-		 * Probably we should eventually have an orun stat in our driver...
+		 * Probably we should eventually have an orun stat in our
+		 * driver...
 		 */
 		ch->ch_err_overrun++;
 	}
-- 
2.7.4

Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Greg KH]

On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index e794056..bc15584 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
>  		 * Rx Oruns. Exar says that an orun will NOT corrupt
>  		 * the FIFO. It will just replace the holding register
>  		 * with this new data byte. So basically just ignore this.
> -		 * Probably we should eventually have an orun stat in our driver...
> +		 * Probably we should eventually have an orun stat in our
> +		 * driver...
>  		 */
>  		ch->ch_err_overrun++;
>  	}

Why did you just fix only one of these warnings in the file?  You aren't
going to send one patch per instance of this warning in this file, are
you?  Please group it all into one.

thanks,

greg k-h

Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Nadim Almas]

sir i am  new in linux kernel hacking so I just want to start with
something very simple ,so for sake of simplicity and learning I fixed
only one of these warning

Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Greg KH]

On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote:
> sir i am  new in linux kernel hacking so I just want to start with
> something very simple ,so for sake of simplicity and learning I fixed
> only one of these warning

That's great, but next time try to do a little bit more, just fixing a
single warning like that isn't all that useful overall, right?

thanks,

greg k-h

Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Nadim Almas]

So my first patch is correct?

On Sun, Oct 2, 2016 at 9:39 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote:
>> sir i am  new in linux kernel hacking so I just want to start with
>> something very simple ,so for sake of simplicity and learning I fixed
>> only one of these warning
>
> That's great, but next time try to do a little bit more, just fixing a
> single warning like that isn't all that useful overall, right?
>
> thanks,
>
> greg k-h

Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Greg KH]

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Sun, Oct 02, 2016 at 10:11:12PM +0530, Nadim Almas wrote:
> So my first patch is correct?

I don't remember, I think someone else already did the same work as you,
but as I deal with hundreds of patches a day, I can't recall.  Resync on
my staging-testing branch of staging.git and rebase your patch and do
more cleanup than just one tiny one and then resend.

thanks,

greg k-h

Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Joe Perches]

On Thu, 2016-10-06 at 20:53 +0530, Nadim Almas wrote:
> May be it is not looking better than it did before but it removed 6 warning of
> the file which is shown by running "perl scripts/checkpatch.pl -f
> drivers/staging/dgnc/* | less" commend
> than why it is not acceptable

(please don't top post)

Because it's ugly and checkpatch output messages are not dicta.

If this is really useful, realign all the comments to start on
the same column.

more below...

> On Thu, Oct 6, 2016 at 1:52 PM, Nadim Almas <nadim.902@gmail.com> wrote:
> > May be it is not looking better than yours but it removed 6 warning of
> > the file which is shown by running "perl scripts/checkpatch.pl -f
> > drivers/staging/dgnc/* | less" commend
> > 
> > On Thu, Oct 6, 2016 at 10:51 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
> > > > Fixed coding style issue
> > > > 
> > > > Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> > > > ---
> > > >  drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
> > > >  1 file changed, 12 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
> > > > index abddd48..65994e3 100644
> > > > --- a/drivers/staging/dgnc/dgnc_neo.h
> > > > +++ b/drivers/staging/dgnc/dgnc_neo.h
> > > > @@ -30,7 +30,8 @@
> > > >  struct neo_uart_struct {O
> > > >       u8 txrx;                /* WR  RHR/THR - Holding Reg */
> > > >       u8 ier;         /* WR  IER - Interrupt Enable Reg */
> > > > -     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> > > > +     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
> > > > +                                                                     /*Reg */

Consider

12345678901234567890123456789012345678901234567890123456789012345678901234567890

struct neo_uart_struct {
	u8 txrx; 	/* WR  RHR/THR - Holding Reg */
	u8 ier;		/* WR  IER - Interrupt Enable Reg */
	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status & Fifo Control Reg */

or

struct neo_uart_struct {
	u8 txrx; 	/* WR  RHR/THR - Holding Reg */
	u8 ier;		/* WR  IER - Interrupt Enable Reg */
	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status Reg and
                         *               Fifo Control Reg
			 */

or

struct neo_uart_struct {
	u8 txrx; 	// WR  RHR/THR - Holding Reg
	u8 ier;		// WR  IER - Interrupt Enable Reg
	u8 isr_fcr;	// WR  ISR/FCR - Interrupt Status/Fifo Control Reg

Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Nadim Almas]

May be it is not looking better than it did before but it removed 6 warning of
the file which is shown by running "perl scripts/checkpatch.pl -f
drivers/staging/dgnc/* | less" commend
than why it is not acceptable

On Thu, Oct 6, 2016 at 1:52 PM, Nadim Almas <nadim.902@gmail.com> wrote:
> May be it is not looking better than yours but it removed 6 warning of
> the file which is shown by running "perl scripts/checkpatch.pl -f
> drivers/staging/dgnc/* | less" commend
>
> On Thu, Oct 6, 2016 at 10:51 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
>>> Fixed coding style issue
>>>
>>> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
>>> ---
>>>  drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
>>>  1 file changed, 12 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
>>> index abddd48..65994e3 100644
>>> --- a/drivers/staging/dgnc/dgnc_neo.h
>>> +++ b/drivers/staging/dgnc/dgnc_neo.h
>>> @@ -30,7 +30,8 @@
>>>  struct neo_uart_struct {
>>>       u8 txrx;                /* WR  RHR/THR - Holding Reg */
>>>       u8 ier;         /* WR  IER - Interrupt Enable Reg */
>>> -     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
>>> +     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
>>> +                                                                     /*Reg */
>>
>> Does that really look better now than it did before?
>>
>> I don't think so :(
>>
>> sorry,
>>
>> greg k-h

Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Nadim Almas]

May be it is not looking better than yours but it removed 6 warning of
the file which is shown by running "perl scripts/checkpatch.pl -f
drivers/staging/dgnc/* | less" commend

On Thu, Oct 6, 2016 at 10:51 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
>> Fixed coding style issue
>>
>> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
>> ---
>>  drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
>>  1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
>> index abddd48..65994e3 100644
>> --- a/drivers/staging/dgnc/dgnc_neo.h
>> +++ b/drivers/staging/dgnc/dgnc_neo.h
>> @@ -30,7 +30,8 @@
>>  struct neo_uart_struct {
>>       u8 txrx;                /* WR  RHR/THR - Holding Reg */
>>       u8 ier;         /* WR  IER - Interrupt Enable Reg */
>> -     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
>> +     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
>> +                                                                     /*Reg */
>
> Does that really look better now than it did before?
>
> I don't think so :(
>
> sorry,
>
> greg k-h

Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Greg KH]

On Wed, Oct 05, 2016 at 02:53:58PM -0700, Nadim Almas wrote:
> Fixed coding style issue
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
> index abddd48..65994e3 100644
> --- a/drivers/staging/dgnc/dgnc_neo.h
> +++ b/drivers/staging/dgnc/dgnc_neo.h
> @@ -30,7 +30,8 @@
>  struct neo_uart_struct {
>  	u8 txrx;		/* WR  RHR/THR - Holding Reg */
>  	u8 ier;		/* WR  IER - Interrupt Enable Reg */
> -	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> +	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
> +									/*Reg */

Does that really look better now than it did before?

I don't think so :(

sorry,

greg k-h

[PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

[Nadim Almas]

Fixed coding style issue

Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
 drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
index abddd48..65994e3 100644
--- a/drivers/staging/dgnc/dgnc_neo.h
+++ b/drivers/staging/dgnc/dgnc_neo.h
@@ -30,7 +30,8 @@
 struct neo_uart_struct {
 	u8 txrx;		/* WR  RHR/THR - Holding Reg */
 	u8 ier;		/* WR  IER - Interrupt Enable Reg */
-	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
+	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
+									/*Reg */
 	u8 lcr;		/* WR  LCR - Line Control Reg */
 	u8 mcr;		/* WR  MCR - Modem Control Reg */
 	u8 lsr;		/* WR  LSR - Line Status Reg */
@@ -108,7 +109,8 @@ struct neo_uart_struct {
 /* 17158 Extended IIR's */
 #define UART_17158_IIR_RDI_TIMEOUT	0x0C	/* Receiver data TIMEOUT */
 #define UART_17158_IIR_XONXOFF		0x10	/* Received an XON/XOFF char */
-#define UART_17158_IIR_HWFLOW_STATE_CHANGE 0x20	/* CTS/DSR or RTS/DTR state change */
+#define UART_17158_IIR_HWFLOW_STATE_CHANGE 0x20	/* CTS/DSR or RTS/DTR state */
+								/* change */
 #define UART_17158_IIR_FIFO_ENABLED	0xC0	/* 16550 FIFOs are Enabled */
 
 /*
@@ -119,8 +121,10 @@ struct neo_uart_struct {
 #define UART_17158_RXRDY_TIMEOUT	0x2	/* RX Ready Timeout */
 #define UART_17158_TXRDY		0x3	/* TX Ready */
 #define UART_17158_MSR			0x4	/* Modem State Change */
-#define UART_17158_TX_AND_FIFO_CLR	0x40	/* Transmitter Holding Reg Empty */
-#define UART_17158_RX_FIFO_DATA_ERROR	0x80	/* UART detected an RX FIFO Data error */
+#define UART_17158_TX_AND_FIFO_CLR	0x40	/* Transmitter Holding Reg */
+								/* Empty */
+#define UART_17158_RX_FIFO_DATA_ERROR	0x80	/* UART detected an RX FIFO */
+								/* Data error */
 
 /*
  * These are the EXTENDED definitions for the 17C158's Interrupt
@@ -132,8 +136,10 @@ struct neo_uart_struct {
 #define UART_17158_EFR_RTSDTR	0x40	/* Auto RTS/DTR Flow Control Enable */
 #define UART_17158_EFR_CTSDSR	0x80	/* Auto CTS/DSR Flow COntrol Enable */
 
-#define UART_17158_XOFF_DETECT	0x1	/* Indicates whether chip saw an incoming XOFF char  */
-#define UART_17158_XON_DETECT	0x2	/* Indicates whether chip saw an incoming XON char */
+#define UART_17158_XOFF_DETECT	0x1	/* Indicates whether chip saw an */
+						/* incoming XOFF char  */
+#define UART_17158_XON_DETECT	0x2	/* Indicates whether chip saw an */
+							/* incoming XON char */
 
 #define UART_17158_IER_RSVD1	0x10	/* Reserved by Exar */
 #define UART_17158_IER_XOFF	0x20	/* Xoff Interrupt Enable */
-- 
2.7.4