From: Mark Rutland <mark.rutland@arm.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Rob Herring <robh+dt@kernel.org>,
Nicolas Pitre <nico@fluxnic.net>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms
Date: Mon, 3 Oct 2016 16:46:25 +0100 [thread overview]
Message-ID: <20161003154624.GG7632@leverpostej> (raw)
In-Reply-To: <1475485553-18747-3-git-send-email-robert.jarzmik@free.fr>
On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote:
> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes
> which must be aligned on 32 bits addresses.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/smsc911x.txt b/Documentation/devicetree/bindings/net/smsc911x.txt
> index 3fed3c124411..224965b7453c 100644
> --- a/Documentation/devicetree/bindings/net/smsc911x.txt
> +++ b/Documentation/devicetree/bindings/net/smsc911x.txt
> @@ -13,6 +13,8 @@ Optional properties:
> - reg-io-width : Specify the size (in bytes) of the IO accesses that
> should be performed on the device. Valid value for SMSC LAN is
> 2 or 4. If it's omitted or invalid, the size would be 2.
> +- reg-u16-align4 : Boolean, put in place the workaround the force all
> + u16 writes to be 32 bits aligned
This property name and description is confusing.
How exactly does this differ from having reg-io-width = <4>, which is
documented immediately above?
Thanks,
Mark.
> - smsc,irq-active-high : Indicates the IRQ polarity is active-high
> - smsc,irq-push-pull : Indicates the IRQ type is push-pull
> - smsc,force-internal-phy : Forces SMSC LAN controller to use
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-10-03 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 9:05 [PATCH 1/3] net: smc91x: isolate u16 writes alignment workaround Robert Jarzmik
2016-10-03 9:05 ` [PATCH 2/3] net: smc91x: take into account half-word workaround Robert Jarzmik
2016-10-03 9:05 ` [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms Robert Jarzmik
2016-10-03 15:21 ` Jeremy Linton
2016-10-03 16:14 ` Robert Jarzmik
2016-10-03 15:46 ` Mark Rutland [this message]
2016-10-03 16:09 ` Russell King - ARM Linux
2016-10-03 16:42 ` Mark Rutland
2016-10-09 1:28 ` Rob Herring
2016-10-03 16:11 ` Robert Jarzmik
2016-10-03 16:50 ` Mark Rutland
2016-10-03 19:12 ` Robert Jarzmik
2016-10-06 6:47 ` Robert Jarzmik
2016-10-09 1:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003154624.GG7632@leverpostej \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).