From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Pitre <nico@fluxnic.net>, Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms
Date: Mon, 3 Oct 2016 17:09:13 +0100 [thread overview]
Message-ID: <20161003160913.GQ1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20161003154624.GG7632@leverpostej>
On Mon, Oct 03, 2016 at 04:46:25PM +0100, Mark Rutland wrote:
> On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote:
> > Add a workaround for mainstone, idp and stargate2 boards, for u16 writes
> > which must be aligned on 32 bits addresses.
> >
> > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> > ---
> > Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/smsc911x.txt b/Documentation/devicetree/bindings/net/smsc911x.txt
> > index 3fed3c124411..224965b7453c 100644
> > --- a/Documentation/devicetree/bindings/net/smsc911x.txt
> > +++ b/Documentation/devicetree/bindings/net/smsc911x.txt
> > @@ -13,6 +13,8 @@ Optional properties:
> > - reg-io-width : Specify the size (in bytes) of the IO accesses that
> > should be performed on the device. Valid value for SMSC LAN is
> > 2 or 4. If it's omitted or invalid, the size would be 2.
> > +- reg-u16-align4 : Boolean, put in place the workaround the force all
> > + u16 writes to be 32 bits aligned
>
> This property name and description is confusing.
>
> How exactly does this differ from having reg-io-width = <4>, which is
> documented immediately above?
Please note that the binding doc for smsc,lan91c111.txt is slightly wrong
on two counts:
1) compatible property:
compatible = "smsc,lan91c111";
vs the code:
static const struct of_device_id smc91x_match[] = {
{ .compatible = "smsc,lan91c94", },
{ .compatible = "smsc,lan91c111", },
{},
};
MODULE_DEVICE_TABLE(of, smc91x_match);
So the binding document needs to mention that smsc,lan91c94 is a valid
compatible for this device.
2) reg-io-width property:
- reg-io-width : Mask of sizes (in bytes) of the IO accesses that
are supported on the device. Valid value for SMSC LAN91c111 are
1, 2 or 4. If it's omitted or invalid, the size would be 2 meaning
16-bit access only.
The SMC requires at least one of byte or 16-bit access sizes, with
32-bit access sizes being optional on top. So, the legal values here
are: 1, 2, 3, 5, 6, and 7. 4 is illegal, and has never been supported
by the driver.
Note that the driver will always use byte accesses if '1' is specified
and emulate 16-bit accesses. If '2' is specified, the driver will
always use 16-bit accesses, and emulate byte accesses for the 8-bit
registers using a read-modify-write scheme. If '3' is specified, the
driver will use both 16-bit and byte accesses as appropriate for the
register being accessed with no emulation. Byte or 16-bit access are
required for non-data register access.
Including 32-bit accesses on top of this allows the packet transfer
(iow, data register accesses) to use 32-bit access instructions, which
is a performance boost.
Moreover, look at the property name vs the binding description. It's
property name says it's a width, but the description says it's a mask
of sizes - these really aren't the same thing. Once you start
specifying these other legal masks, it makes a nonsense of the "width"
part of the name. It's too late to try and fix this now though.
The binding document really needs to get fixed - I'll try to cook up a
patch during this week to correct these points, but it probably needs
coordination if others are going to be changing this as well.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-10-03 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 9:05 [PATCH 1/3] net: smc91x: isolate u16 writes alignment workaround Robert Jarzmik
2016-10-03 9:05 ` [PATCH 2/3] net: smc91x: take into account half-word workaround Robert Jarzmik
2016-10-03 9:05 ` [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms Robert Jarzmik
2016-10-03 15:21 ` Jeremy Linton
2016-10-03 16:14 ` Robert Jarzmik
2016-10-03 15:46 ` Mark Rutland
2016-10-03 16:09 ` Russell King - ARM Linux [this message]
2016-10-03 16:42 ` Mark Rutland
2016-10-09 1:28 ` Rob Herring
2016-10-03 16:11 ` Robert Jarzmik
2016-10-03 16:50 ` Mark Rutland
2016-10-03 19:12 ` Robert Jarzmik
2016-10-06 6:47 ` Robert Jarzmik
2016-10-09 1:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003160913.GQ1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).