From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration
Date: Mon, 24 Oct 2016 10:11:15 +0100 [thread overview]
Message-ID: <20161024091115.GG14477@dell> (raw)
In-Reply-To: <1476934445-17718-2-git-send-email-javier@osg.samsung.com>
On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
> alias: platform:mailbox-sti
>
> After this patch:
>
> $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias
> alias: platform:mailbox-sti
> alias: of:N*T*Cst,stih407-mailboxC*
> alias: of:N*T*Cst,stih407-mailbox
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mailbox/mailbox-sti.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c
> index a334db5c9f1c..41bcd339b68a 100644
> --- a/drivers/mailbox/mailbox-sti.c
> +++ b/drivers/mailbox/mailbox-sti.c
> @@ -403,6 +403,7 @@ static const struct of_device_id sti_mailbox_match[] = {
> },
> { }
> };
> +MODULE_DEVICE_TABLE(of, sti_mailbox_match);
>
> static int sti_mbox_probe(struct platform_device *pdev)
> {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-24 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 3:34 [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Javier Martinez Canillas
2016-10-20 3:34 ` [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-24 9:11 ` Lee Jones [this message]
2016-10-24 9:10 ` [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Lee Jones
2016-11-29 14:53 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024091115.GG14477@dell \
--to=lee.jones@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).