From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mailbox: mailbox-test: Fix module autoload
Date: Tue, 29 Nov 2016 11:53:07 -0300 [thread overview]
Message-ID: <3d940511-cb29-9b0b-b3b0-e24447a18206@osg.samsung.com> (raw)
In-Reply-To: <20161024091039.GF14477@dell>
Hello Jessi,
On 10/24/2016 06:10 AM, Lee Jones wrote:
> On Thu, 20 Oct 2016, Javier Martinez Canillas wrote:
>
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/mailbox/mailbox-test.ko | grep alias
>> alias: of:N*T*Cmailbox-testC*
>> alias: of:N*T*Cmailbox-test
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>> drivers/mailbox/mailbox-test.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
Any comments about this patch and 2/2? Lee acked both patches but
I see that were never picked.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
prev parent reply other threads:[~2016-11-29 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 3:34 [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Javier Martinez Canillas
2016-10-20 3:34 ` [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-24 9:11 ` Lee Jones
2016-10-24 9:10 ` [PATCH 1/2] mailbox: mailbox-test: Fix module autoload Lee Jones
2016-11-29 14:53 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d940511-cb29-9b0b-b3b0-e24447a18206@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).