From: Borislav Petkov <bp@alien8.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "He Chen" <he.chen@linux.intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>,
"Luwei Kang" <luwei.kang@intel.com>,
"Piotr Luc" <Piotr.Luc@intel.com>
Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest
Date: Fri, 4 Nov 2016 16:06:37 +0100 [thread overview]
Message-ID: <20161104150637.ejyxq5rfwcwggo3q@pd.tnic> (raw)
In-Reply-To: <ecdc20d5-e5c2-cab7-2973-39c811cac42c@redhat.com>
On Fri, Nov 04, 2016 at 03:53:02PM +0100, Paolo Bonzini wrote:
> > The modification to scattered et al without the kvm use should be a
> > separate patch.
>
> With no usage? Sounds like a good use of Acked-by. :)
I don't understand what do you mean here?
> >> +u32 get_scattered_cpuid_leaf(unsigned int level, unsigned int sub_leaf,
> >> + enum cpuid_regs_idx reg)
> >
> > Align arguments on the opening brace.
>
> They are aligned.
Right you are. I need to look into why those spaces get eaten in vim.
Looks like something is replacing 4 spaces with a single one...
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2016-11-04 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 7:07 [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS features to kvm guest He Chen
2016-11-04 10:52 ` Borislav Petkov
2016-11-04 14:53 ` Paolo Bonzini
2016-11-04 15:06 ` Borislav Petkov [this message]
2016-11-04 15:13 ` Paolo Bonzini
2016-11-04 15:57 ` Borislav Petkov
2016-11-04 15:58 ` Paolo Bonzini
2016-11-07 16:52 ` Thomas Gleixner
2016-11-07 2:10 ` He Chen
2016-11-07 9:05 ` Borislav Petkov
2016-11-07 16:47 ` Thomas Gleixner
2016-11-07 17:07 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104150637.ejyxq5rfwcwggo3q@pd.tnic \
--to=bp@alien8.de \
--cc=Piotr.Luc@intel.com \
--cc=he.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).