* linux-next: build warning after merge of the scsi-mkp tree
@ 2016-11-14 5:16 Stephen Rothwell
2016-11-14 12:31 ` Christoph Hellwig
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2016-11-14 5:16 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: linux-next, linux-kernel, Christoph Hellwig
Hi Martin,
After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
free_irq(pci_irq_vector(h->pdev, 0), &h->q[i]);
^
Introduced by commit
bc2bb1543e62 ("scsi: hpsa: use pci_alloc_irq_vectors and automatic irq affinity")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2016-11-14 5:16 linux-next: build warning after merge of the scsi-mkp tree Stephen Rothwell
@ 2016-11-14 12:31 ` Christoph Hellwig
0 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-11-14 12:31 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Martin K. Petersen, linux-next, linux-kernel, Christoph Hellwig
On Mon, Nov 14, 2016 at 04:16:24PM +1100, Stephen Rothwell wrote:
> Hi Martin,
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/scsi/hpsa.c: In function 'hpsa_free_irqs':
> drivers/scsi/hpsa.c:8223:40: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
> free_irq(pci_irq_vector(h->pdev, 0), &h->q[i]);
The i here shold be h->intr_mode, I'll send a fix in a bit.
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2017-08-24 5:57 Stephen Rothwell
2017-08-24 5:59 ` Stephen Rothwell
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2017-08-24 5:57 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Martin,
After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 'lpfc_nvmet_replenish_context' defined but not used [-Wunused-function]
lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
^
Introduced by commit
9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2017-08-24 5:57 Stephen Rothwell
@ 2017-08-24 5:59 ` Stephen Rothwell
0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2017-08-24 5:59 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Dick Kennedy,
James Smart
Hi all,
[Just adding Dick and James to the cc list]
On Thu, 24 Aug 2017 15:57:56 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: warning: 'lpfc_nvmet_replenish_context' defined but not used [-Wunused-function]
> lpfc_nvmet_replenish_context(struct lpfc_hba *phba,
> ^
>
> Introduced by commit
>
> 9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2017-09-26 4:09 Stephen Rothwell
2017-09-27 3:27 ` Stephen Rothwell
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2017-09-26 4:09 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Jason Yan
Hi Martin,
After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_controller_reset':
drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 'sas_ha' [-Wunused-variable]
struct sas_ha_struct *sas_ha = &hisi_hba->sha;
^
Introduced by commit
042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2017-09-26 4:09 Stephen Rothwell
@ 2017-09-27 3:27 ` Stephen Rothwell
0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2017-09-27 3:27 UTC (permalink / raw)
To: James Bottomley
Cc: Martin K. Petersen, Linux-Next Mailing List,
Linux Kernel Mailing List, Jason Yan
Hi James,
On Tue, 26 Sep 2017 14:09:47 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/scsi/hisi_sas/hisi_sas_main.c: In function 'hisi_sas_controller_reset':
> drivers/scsi/hisi_sas/hisi_sas_main.c:1049:24: warning: unused variable 'sas_ha' [-Wunused-variable]
> struct sas_ha_struct *sas_ha = &hisi_hba->sha;
> ^
>
> Introduced by commit
>
> 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
This warning now exists in the scsi tree.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2018-07-11 4:17 Stephen Rothwell
2018-07-12 4:30 ` Stephen Rothwell
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2018-07-11 4:17 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Hannes Reinecke, Johannes Thumshirn
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from include/linux/spinlock_types.h:18:0,
from include/linux/spinlock.h:82,
from drivers/scsi/libfc/fc_rport.c:61:
drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
#define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
^
drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
struct fc_rport_priv *rdata;
^~~~~
Introduced by commit
ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
It is actually complaining about function fc_rport_recv_plogi_req()
(presumably it is being inlined) and this looks like an actual bug :-(
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2018-07-11 4:17 Stephen Rothwell
@ 2018-07-12 4:30 ` Stephen Rothwell
2018-07-12 6:10 ` Hannes Reinecke
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2018-07-12 4:30 UTC (permalink / raw)
To: James Bottomley
Cc: Martin K. Petersen, Linux-Next Mailing List,
Linux Kernel Mailing List, Hannes Reinecke, Johannes Thumshirn
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
Hi all,
On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from include/linux/spinlock_types.h:18:0,
> from include/linux/spinlock.h:82,
> from drivers/scsi/libfc/fc_rport.c:61:
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
> #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
> ^
> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
> struct fc_rport_priv *rdata;
> ^~~~~
>
> Introduced by commit
>
> ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
>
> It is actually complaining about function fc_rport_recv_plogi_req()
> (presumably it is being inlined) and this looks like an actual bug :-(
This warning now appears after the merge of the scsi tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2018-07-12 4:30 ` Stephen Rothwell
@ 2018-07-12 6:10 ` Hannes Reinecke
0 siblings, 0 replies; 24+ messages in thread
From: Hannes Reinecke @ 2018-07-12 6:10 UTC (permalink / raw)
To: Stephen Rothwell, James Bottomley
Cc: Martin K. Petersen, Linux-Next Mailing List,
Linux Kernel Mailing List, Johannes Thumshirn
On 07/12/2018 06:30 AM, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 11 Jul 2018 14:17:37 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the scsi-mkp tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> In file included from include/linux/spinlock_types.h:18:0,
>> from include/linux/spinlock.h:82,
>> from drivers/scsi/libfc/fc_rport.c:61:
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_req':
>> include/linux/lockdep.h:347:45: warning: 'rdata' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> #define lockdep_is_held(lock) lock_is_held(&(lock)->dep_map)
>> ^
>> drivers/scsi/libfc/fc_rport.c:1832:24: note: 'rdata' was declared here
>> struct fc_rport_priv *rdata;
>> ^~~~~
>>
>> Introduced by commit
>>
>> ee35624e1e4e ("scsi: libfc: Add lockdep annotations")
>>
>> It is actually complaining about function fc_rport_recv_plogi_req()
>> (presumably it is being inlined) and this looks like an actual bug :-(
>
> This warning now appears after the merge of the scsi tree.
>
I have send a new round of patches to the scsi mailing list (cf
'libfc/fcoe: disc_mutex fixes') which address this issue.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2018-10-12 5:10 Stephen Rothwell
0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2018-10-12 5:10 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Avri Altman
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
./usr/include/scsi/scsi_bsg_ufs.h:45: found __[us]{8,16,32,64} type without #include <linux/types.h>
Introduced by commits
a851b2bd3632 ("scsi: uapi: ufs: Make utp_upiu_req visible to user space")
e77044c5a842 ("scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2018-12-20 6:34 Stephen Rothwell
0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2018-12-20 6:34 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Dave Carroll,
Kees Cook, Gustavo A. R. Silva
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_build_raid_path_request':
drivers/scsi/smartpqi/smartpqi_init.c:478:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
cdb_length = 0;
~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:479:2: note: here
case BMIC_IDENTIFY_CONTROLLER:
^~~~
drivers/scsi/smartpqi/smartpqi_init.c:487:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
cdb_length = 0;
~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:488:2: note: here
case BMIC_WRITE_HOST_WELLNESS:
^~~~
Introduced by commit
171c28653a2d ("scsi: smartpqi: turn off lun data caching for ptraid")
This due to my use of -Wimplicit-fallthrough for Kees Cook. This is
new code. The warning can be suppressed by adding a comment like
/* fall through */
just above the following "case" or "default" to indicate that the
fallthrough is intended.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2020-03-02 2:35 Stephen Rothwell
2020-03-02 14:36 ` Brian King
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2020-03-02 2:35 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Brian King
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/list.h:5,
from include/linux/module.h:12,
from drivers/scsi/ibmvscsi/ibmvfc.c:10:
drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
8 | #define NULL ((void *)0)
| ^
drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
3644 | return NULL;
| ^~~~
drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2020-03-02 2:35 Stephen Rothwell
@ 2020-03-02 14:36 ` Brian King
2020-03-06 4:52 ` Stephen Rothwell
0 siblings, 1 reply; 24+ messages in thread
From: Brian King @ 2020-03-02 14:36 UTC (permalink / raw)
To: Stephen Rothwell, Martin K. Petersen
Cc: Linux Next Mailing List, Linux Kernel Mailing List
On 3/1/20 8:35 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> In file included from include/uapi/linux/posix_types.h:5,
> from include/uapi/linux/types.h:14,
> from include/linux/types.h:6,
> from include/linux/list.h:5,
> from include/linux/module.h:12,
> from drivers/scsi/ibmvscsi/ibmvfc.c:10:
> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
> include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
> 8 | #define NULL ((void *)0)
> | ^
> drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
> 3644 | return NULL;
> | ^~~~
> drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
> 3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
>
Thanks. I'll send the one line fix.
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2020-03-02 14:36 ` Brian King
@ 2020-03-06 4:52 ` Stephen Rothwell
2020-03-06 15:30 ` Brian King
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2020-03-06 4:52 UTC (permalink / raw)
To: James Bottomley
Cc: Brian King, Martin K. Petersen, Linux Next Mailing List,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
Hi all,
On Mon, 2 Mar 2020 08:36:20 -0600 Brian King <brking@linux.vnet.ibm.com> wrote:
>
> On 3/1/20 8:35 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the scsi-mkp tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > In file included from include/uapi/linux/posix_types.h:5,
> > from include/uapi/linux/types.h:14,
> > from include/linux/types.h:6,
> > from include/linux/list.h:5,
> > from include/linux/module.h:12,
> > from drivers/scsi/ibmvscsi/ibmvfc.c:10:
> > drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
> > include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
> > 8 | #define NULL ((void *)0)
> > | ^
> > drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
> > 3644 | return NULL;
> > | ^~~~
> > drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
> > 3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> > 54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
>
> Thanks. I'll send the one line fix.
I am still getting this warning, but it is now after the merge of the
scsi tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2020-03-06 4:52 ` Stephen Rothwell
@ 2020-03-06 15:30 ` Brian King
0 siblings, 0 replies; 24+ messages in thread
From: Brian King @ 2020-03-06 15:30 UTC (permalink / raw)
To: Stephen Rothwell, James Bottomley
Cc: Martin K. Petersen, Linux Next Mailing List, Linux Kernel Mailing List
On 3/5/20 10:52 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 2 Mar 2020 08:36:20 -0600 Brian King <brking@linux.vnet.ibm.com> wrote:
>>
>> On 3/1/20 8:35 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the scsi-mkp tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>>
>>> In file included from include/uapi/linux/posix_types.h:5,
>>> from include/uapi/linux/types.h:14,
>>> from include/linux/types.h:6,
>>> from include/linux/list.h:5,
>>> from include/linux/module.h:12,
>>> from drivers/scsi/ibmvscsi/ibmvfc.c:10:
>>> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_tgt_implicit_logout_and_del':
>>> include/linux/stddef.h:8:14: warning: 'return' with a value, in function returning void [-Wreturn-type]
>>> 8 | #define NULL ((void *)0)
>>> | ^
>>> drivers/scsi/ibmvscsi/ibmvfc.c:3644:10: note: in expansion of macro 'NULL'
>>> 3644 | return NULL;
>>> | ^~~~
>>> drivers/scsi/ibmvscsi/ibmvfc.c:3638:13: note: declared here
>>> 3638 | static void ibmvfc_tgt_implicit_logout_and_del(struct ibmvfc_target *tgt)
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Introduced by commit
>>>
>>> 54b04c99d02e ("scsi: ibmvfc: Avoid loss of all paths during SVC node reboot")
>>
>> Thanks. I'll send the one line fix.
>
> I am still getting this warning, but it is now after the merge of the
> scsi tree.
>
I sent the fix to the list, waiting for it to get pulled in:
https://marc.info/?l=linux-scsi&m=158315998321290&w=2
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2021-10-18 20:41 Stephen Rothwell
2021-11-08 0:06 ` Stephen Rothwell
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2021-10-18 20:41 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Bart Van Assche, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (htmldocs)
produced this warning:
drivers/scsi/scsi_scan.c:129: warning: Function parameter or member 'dev' not described in 'scsi_enable_async_suspend'
Introduced by commit
a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2021-10-18 20:41 Stephen Rothwell
@ 2021-11-08 0:06 ` Stephen Rothwell
2021-11-08 14:36 ` James Bottomley
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2021-11-08 0:06 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Bart Van Assche, Linux Kernel Mailing List,
Linux Next Mailing List, James Bottomley
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
Hi all,
On Tue, 19 Oct 2021 07:41:19 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/scsi/scsi_scan.c:129: warning: Function parameter or member 'dev' not described in 'scsi_enable_async_suspend'
>
> Introduced by commit
>
> a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for async power management")
That commit is now in Linus' tree.
BTW, James, I tried to use your HansenPartnership.com email address, but
the DNS is giving SERVER FAIL errors for it ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2021-11-08 0:06 ` Stephen Rothwell
@ 2021-11-08 14:36 ` James Bottomley
0 siblings, 0 replies; 24+ messages in thread
From: James Bottomley @ 2021-11-08 14:36 UTC (permalink / raw)
To: Stephen Rothwell, Martin K. Petersen
Cc: Bart Van Assche, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Mon, 2021-11-08 at 11:06 +1100, Stephen Rothwell wrote:
[...]
> BTW, James, I tried to use your HansenPartnership.com email address,
> but the DNS is giving SERVER FAIL errors for it ...
Should be fixed now. An update in debian testing changed the way
dnssec works with bind9 and effectively caused a roll of my zone
signing key (or more accurately moved me from a separated ZSK KSK pair
to a combined key). Anyway, since there was no DS record for the new
key the whole domain broke. I've now fixed the delegation and it's
working again.
James
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2023-05-23 3:38 Stephen Rothwell
2023-05-23 6:38 ` Damien Le Moal
2023-05-23 7:49 ` Damien Le Moal
0 siblings, 2 replies; 24+ messages in thread
From: Stephen Rothwell @ 2023-05-23 3:38 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Damien Le Moal, Niklas Cassel, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (htmldocs)
produced this warning:
drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
Introduced by commit
df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2023-05-23 3:38 Stephen Rothwell
@ 2023-05-23 6:38 ` Damien Le Moal
2023-05-23 7:49 ` Damien Le Moal
1 sibling, 0 replies; 24+ messages in thread
From: Damien Le Moal @ 2023-05-23 6:38 UTC (permalink / raw)
To: Stephen Rothwell, Martin K. Petersen
Cc: Niklas Cassel, Linux Kernel Mailing List, Linux Next Mailing List
On 5/23/23 12:38, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
>
> Introduced by commit
>
> df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
>
Martin,
This is missing:
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 69fc0d2c2123..c676b1e9b6c9 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct
ata_queued_cmd *qc,
/**
* ata_mselect_control - Simulate MODE SELECT for control page
* @qc: Storage for translated ATA taskfile
+ * @spg: sub-page of the control page
* @buf: input buffer
* @len: number of valid bytes in the input buffer
* @fp: out parameter for the failed field on error
Do you want me to send a fix patch or can you fold this in ?
--
Damien Le Moal
Western Digital Research
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2023-05-23 3:38 Stephen Rothwell
2023-05-23 6:38 ` Damien Le Moal
@ 2023-05-23 7:49 ` Damien Le Moal
1 sibling, 0 replies; 24+ messages in thread
From: Damien Le Moal @ 2023-05-23 7:49 UTC (permalink / raw)
To: Stephen Rothwell, Martin K. Petersen
Cc: Niklas Cassel, Linux Kernel Mailing List, Linux Next Mailing List
On 5/23/23 12:38, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
>
> Introduced by commit
>
> df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
>
Martin,
To make things simpler, I posted a small patch to fix this. Please feel free to
fold it in df60f9c64576. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2023-07-24 4:04 Stephen Rothwell
2023-07-26 2:13 ` Martin K. Petersen
0 siblings, 1 reply; 24+ messages in thread
From: Stephen Rothwell @ 2023-07-24 4:04 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Can Guo, Ziqi Chen, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (arm64
defconfig) produced this warning:
drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
drivers/ufs/host/ufs-qcom.c:1652:31: warning: unused variable 'host' [-Wunused-variable]
1652 | struct ufs_qcom_host *host = ufshcd_get_variant(hba);
| ^~~~
Introduced by commit
8f2b78652d05 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: linux-next: build warning after merge of the scsi-mkp tree
2023-07-24 4:04 Stephen Rothwell
@ 2023-07-26 2:13 ` Martin K. Petersen
0 siblings, 0 replies; 24+ messages in thread
From: Martin K. Petersen @ 2023-07-26 2:13 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Martin K. Petersen, Can Guo, Ziqi Chen,
Linux Kernel Mailing List, Linux Next Mailing List
Stephen,
> After merging the scsi-mkp tree, today's linux-next build (arm64
> defconfig) produced this warning:
>
> drivers/ufs/host/ufs-qcom.c: In function 'ufs_qcom_mcq_esi_handler':
> drivers/ufs/host/ufs-qcom.c:1652:31: warning: unused variable 'host' [-Wunused-variable]
> 1652 | struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> | ^~~~
>
> Introduced by commit
>
> 8f2b78652d05 ("scsi: ufs: qcom: Get queue ID from MSI index in ESI handler")
Now fixed up, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 24+ messages in thread
* linux-next: build warning after merge of the scsi-mkp tree
@ 2023-08-28 3:13 Stephen Rothwell
0 siblings, 0 replies; 24+ messages in thread
From: Stephen Rothwell @ 2023-08-28 3:13 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Nilesh Javali, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2xxx_process_purls_pkt':
drivers/scsi/qla2xxx/qla_nvme.c:1183:20: warning: unused variable 'fcport' [-Wunused-variable]
1183 | fc_port_t *fcport = uctx->fcport;
| ^~~~~~
Introduced by commit
27177862de96 ("scsi: qla2xxx: Fix nvme_fc_rcv_ls_req() undefined error")
# CONFIG_NVME_FC is not set
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2023-08-28 3:20 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 5:16 linux-next: build warning after merge of the scsi-mkp tree Stephen Rothwell
2016-11-14 12:31 ` Christoph Hellwig
2017-08-24 5:57 Stephen Rothwell
2017-08-24 5:59 ` Stephen Rothwell
2017-09-26 4:09 Stephen Rothwell
2017-09-27 3:27 ` Stephen Rothwell
2018-07-11 4:17 Stephen Rothwell
2018-07-12 4:30 ` Stephen Rothwell
2018-07-12 6:10 ` Hannes Reinecke
2018-10-12 5:10 Stephen Rothwell
2018-12-20 6:34 Stephen Rothwell
2020-03-02 2:35 Stephen Rothwell
2020-03-02 14:36 ` Brian King
2020-03-06 4:52 ` Stephen Rothwell
2020-03-06 15:30 ` Brian King
2021-10-18 20:41 Stephen Rothwell
2021-11-08 0:06 ` Stephen Rothwell
2021-11-08 14:36 ` James Bottomley
2023-05-23 3:38 Stephen Rothwell
2023-05-23 6:38 ` Damien Le Moal
2023-05-23 7:49 ` Damien Le Moal
2023-07-24 4:04 Stephen Rothwell
2023-07-26 2:13 ` Martin K. Petersen
2023-08-28 3:13 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).