From: Stephen Boyd <sboyd@codeaurora.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com,
gregkh@linuxfoundation.org, rnayak@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write
Date: Tue, 15 Nov 2016 10:59:22 -0800 [thread overview]
Message-ID: <20161115185922.GB25626@codeaurora.org> (raw)
In-Reply-To: <1479218682-15948-1-git-send-email-vivek.gautam@codeaurora.org>
On 11/15, Vivek Gautam wrote:
> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev)
> static struct nvmem_config econfig = {
> .name = "qfprom",
> .owner = THIS_MODULE,
> - .stride = 4,
> + .stride = 1,
Are we certain that all qfproms support byte accesses?
> .word_size = 1,
> .reg_read = qfprom_reg_read,
> .reg_write = qfprom_reg_write,
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-15 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:04 [PATCH] nvmem: qfprom: Fix to support single byte read/write Vivek Gautam
2016-11-15 18:59 ` Stephen Boyd [this message]
2016-11-16 4:30 ` Vivek Gautam
2016-11-16 22:23 ` Stephen Boyd
2016-11-17 5:59 ` [PATCH v2] nvmem: qfprom: Allow single byte accesses for read/write Vivek Gautam
2017-01-04 14:07 ` Srinivas Kandagatla
2017-01-05 4:27 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115185922.GB25626@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rnayak@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).