From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: maxime.ripard@free-electrons.com, gregkh@linuxfoundation.org,
sboyd@codeaurora.org, rnayak@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: qfprom: Allow single byte accesses for read/write
Date: Wed, 4 Jan 2017 14:07:16 +0000 [thread overview]
Message-ID: <e5c113c8-c172-0cd9-3108-8e673666edb1@linaro.org> (raw)
In-Reply-To: <1479362345-14228-1-git-send-email-vivek.gautam@codeaurora.org>
Thanks for the Patch,
I will queue this up!!
On 17/11/16 05:59, Vivek Gautam wrote:
> The nvmem core driver supports to read and write single
> byte. So, allow qfprom to support this feature.
> This change helps in extracting a required value based
> on bit-offset and number of bits for the required value
> in the nvmem cell.
>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>
> Based on torvalds's master branch.
> - Tested on db410c (apq8016) and ifc6410 (apq 8064) targets
> for thermal sensors (could read the core temperatures); and
> on db820c (msm8996) for qusb2 phy, with tree [1] based on
> linaro qcom landing team's integration tree.
>
> Changes in v2:
> - Updated commit title, since the patch does extend the feature,
> rather than fixing any kind of bug in the code.
>
> Original title (v1): nvmem: qfprom: Fix to support single byte read/write
> Update title (v2): nvmem: qfprom: Allow single byte accesses for read/write.
>
> - Added some more info in the commit message as well.
>
> ** NO change in the code.
>
> [1] https://github.com/vivekgautam1/linux/tree/linaro/integration-linux-qcomlt-qcom-phy-upstream
>
> drivers/nvmem/qfprom.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index b5305f0..2bdb6c3 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -21,11 +21,11 @@ static int qfprom_reg_read(void *context,
> unsigned int reg, void *_val, size_t bytes)
> {
> void __iomem *base = context;
> - u32 *val = _val;
> - int i = 0, words = bytes / 4;
> + u8 *val = _val;
> + int i = 0, words = bytes;
>
> while (words--)
> - *val++ = readl(base + reg + (i++ * 4));
> + *val++ = readb(base + reg + i++);
>
> return 0;
> }
> @@ -34,11 +34,11 @@ static int qfprom_reg_write(void *context,
> unsigned int reg, void *_val, size_t bytes)
> {
> void __iomem *base = context;
> - u32 *val = _val;
> - int i = 0, words = bytes / 4;
> + u8 *val = _val;
> + int i = 0, words = bytes;
>
> while (words--)
> - writel(*val++, base + reg + (i++ * 4));
> + writeb(*val++, base + reg + i++);
>
> return 0;
> }
> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev)
> static struct nvmem_config econfig = {
> .name = "qfprom",
> .owner = THIS_MODULE,
> - .stride = 4,
> + .stride = 1,
> .word_size = 1,
> .reg_read = qfprom_reg_read,
> .reg_write = qfprom_reg_write,
>
next prev parent reply other threads:[~2017-01-04 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:04 [PATCH] nvmem: qfprom: Fix to support single byte read/write Vivek Gautam
2016-11-15 18:59 ` Stephen Boyd
2016-11-16 4:30 ` Vivek Gautam
2016-11-16 22:23 ` Stephen Boyd
2016-11-17 5:59 ` [PATCH v2] nvmem: qfprom: Allow single byte accesses for read/write Vivek Gautam
2017-01-04 14:07 ` Srinivas Kandagatla [this message]
2017-01-05 4:27 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5c113c8-c172-0cd9-3108-8e673666edb1@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rnayak@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).