linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write
Date: Wed, 16 Nov 2016 10:00:14 +0530	[thread overview]
Message-ID: <CAFp+6iEsTpga9pTgCwP=q4LG42QUhgBUih+0jH1eKp-NA7cLDw@mail.gmail.com> (raw)
In-Reply-To: <20161115185922.GB25626@codeaurora.org>

Hi Stephen,

On Wed, Nov 16, 2016 at 12:29 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 11/15, Vivek Gautam wrote:
>> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev)
>>  static struct nvmem_config econfig = {
>>       .name = "qfprom",
>>       .owner = THIS_MODULE,
>> -     .stride = 4,
>> +     .stride = 1,
>
> Are we certain that all qfproms support byte accesses?

I have tested on 8916 and 8996. Will give a try on older targets as
well.

For a note: we had been using the reg_stride = 1, before removing
regmap support for nvmem access [1].

[1] 382c62f nvmem: qfprom: remove nvmem regmap dependency


Thanks
Vivek

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2016-11-16  4:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 14:04 [PATCH] nvmem: qfprom: Fix to support single byte read/write Vivek Gautam
2016-11-15 18:59 ` Stephen Boyd
2016-11-16  4:30   ` Vivek Gautam [this message]
2016-11-16 22:23     ` Stephen Boyd
2016-11-17  5:59       ` [PATCH v2] nvmem: qfprom: Allow single byte accesses for read/write Vivek Gautam
2017-01-04 14:07         ` Srinivas Kandagatla
2017-01-05  4:27           ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFp+6iEsTpga9pTgCwP=q4LG42QUhgBUih+0jH1eKp-NA7cLDw@mail.gmail.com' \
    --to=vivek.gautam@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).