* [RFC PATCH v3 0/2] adding panel claa070wp03xg support for exynos @ 2016-09-19 19:02 Randy Li 2016-09-19 19:02 ` [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite Randy Li 2016-09-19 19:02 ` [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel Randy Li 0 siblings, 2 replies; 11+ messages in thread From: Randy Li @ 2016-09-19 19:02 UTC (permalink / raw) To: dri-devel Cc: linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, thierry.reding, airlied, a.hajda, devicetree, Randy Li The timings issue is still here, this version is just some modifications in dts file. Randy Li (2): ARM: dts: samsung: add rga-lvds panel in itop elite drm/panel: Add support for Chunghwa CLAA070WP03XG panel .../display/panel/chunghwa,claa070wp03xg.txt | 7 +++ arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++- drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++ 3 files changed, 86 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt -- 2.7.4 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite 2016-09-19 19:02 [RFC PATCH v3 0/2] adding panel claa070wp03xg support for exynos Randy Li @ 2016-09-19 19:02 ` Randy Li 2016-09-19 19:12 ` Fabio Estevam 2016-09-19 19:02 ` [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel Randy Li 1 sibling, 1 reply; 11+ messages in thread From: Randy Li @ 2016-09-19 19:02 UTC (permalink / raw) To: dri-devel Cc: linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, thierry.reding, airlied, a.hajda, devicetree, Randy Li It is actually a lvds panel connected through a rga-lvds bridge. The touchscreen is communicated with i2c bus but the driver is not support now. Signed-off-by: Randy Li <ayaka@soulik.info> --- arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++-- 1 file changed, 52 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts index b08705e..5153522 100644 --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts @@ -138,6 +138,36 @@ assigned-clocks = <&clock CLK_MOUT_CAM0>; assigned-clock-parents = <&clock CLK_XUSBXTI>; }; + + vcc_sys_lcd: sys-lcd { + compatible = "regulator-fixed"; + regulator-name = "vcc_5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>; + }; + + panel: panel@0 { + compatible = "chunghwa,claa070wp03xg"; + + power-supply = <&vcc_sys_lcd>; + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>; + backlight = <&bl>; + + port { + lcd_ep: endpoint { + remote-endpoint = <&rga_lvds>; + }; + }; + }; + + bl: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>; + brightness-levels = <0 5 12 16 32 64 128 255>; + default-brightness-level = <5>; + power-supply = <&vcc_sys_lcd>; + }; }; &adc { @@ -171,11 +201,31 @@ assigned-clock-rates = <0>, <176000000>; }; +&fimd { + pinctrl-0 = <&lcd_clk &lcd_data24>; + pinctrl-names = "default"; + status = "okay"; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@3 { + reg = <3>; + rga_lvds: endpoint { + remote-endpoint = <&lcd_ep>; + }; + }; + }; +}; + &hsotg { dr_mode = "peripheral"; status = "okay"; }; +&i2c_3 { + status = "okay"; +}; + &i2c_4 { samsung,i2c-sda-delay = <100>; samsung,i2c-slave-addr = <0x10>; @@ -215,9 +265,9 @@ &pwm { status = "okay"; - pinctrl-0 = <&pwm0_out>; + pinctrl-0 = <&pwm0_out &pwm1_out>; pinctrl-names = "default"; - samsung,pwm-outputs = <0>; + samsung,pwm-outputs = <0>, <1>; }; &sdhci_2 { -- 2.7.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite 2016-09-19 19:02 ` [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite Randy Li @ 2016-09-19 19:12 ` Fabio Estevam 2016-09-19 19:17 ` ayaka 0 siblings, 1 reply; 11+ messages in thread From: Fabio Estevam @ 2016-09-19 19:12 UTC (permalink / raw) To: Randy Li Cc: DRI mailing list, Russell King - ARM Linux, Kukjin Kim, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, Thierry Reding, David Airlie, Andrzej Hajda, devicetree On Mon, Sep 19, 2016 at 4:02 PM, Randy Li <ayaka@soulik.info> wrote: > + vcc_sys_lcd: sys-lcd { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_5v"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>; Is this really active high? If so, you should add the 'enable-active-high' property. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite 2016-09-19 19:12 ` Fabio Estevam @ 2016-09-19 19:17 ` ayaka 0 siblings, 0 replies; 11+ messages in thread From: ayaka @ 2016-09-19 19:17 UTC (permalink / raw) To: Fabio Estevam Cc: DRI mailing list, Russell King - ARM Linux, Kukjin Kim, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, Thierry Reding, David Airlie, Andrzej Hajda, devicetree On 09/20/2016 03:12 AM, Fabio Estevam wrote: > On Mon, Sep 19, 2016 at 4:02 PM, Randy Li <ayaka@soulik.info> wrote: > >> + vcc_sys_lcd: sys-lcd { >> + compatible = "regulator-fixed"; >> + regulator-name = "vcc_5v"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>; > Is this really active high? If so, you should add the > 'enable-active-high' property. I see, thank you. Btw, let me make it clearly, it is really an independentTransistor, not be controlled by PMIC. ^ permalink raw reply [flat|nested] 11+ messages in thread
* [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel 2016-09-19 19:02 [RFC PATCH v3 0/2] adding panel claa070wp03xg support for exynos Randy Li 2016-09-19 19:02 ` [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite Randy Li @ 2016-09-19 19:02 ` Randy Li 2016-09-23 18:00 ` Rob Herring 2016-12-06 15:46 ` Thierry Reding 1 sibling, 2 replies; 11+ messages in thread From: Randy Li @ 2016-09-19 19:02 UTC (permalink / raw) To: dri-devel Cc: linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, thierry.reding, airlied, a.hajda, devicetree, Randy Li The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be supported by the simple panel driver. Signed-off-by: Randy Li <ayaka@soulik.info> --- .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt new file mode 100644 index 0000000..dd22685 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt @@ -0,0 +1,7 @@ +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel + +Required properties: +- compatible: should be "chunghwa,claa070wp03xg" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f178998..3204e6b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -583,6 +583,30 @@ static const struct panel_desc avic_tm070ddh03 = { }, }; +static const struct drm_display_mode chunghwa_claa070wp03xg_mode = { + .clock = 66770, + .hdisplay = 800, + .hsync_start = 800 + 49, + .hsync_end = 800 + 49 + 33, + .htotal = 800 + 49 + 33 + 17, + .vdisplay = 1280, + .vsync_start = 1280 + 1, + .vsync_end = 1280 + 1 + 7, + .vtotal = 1280 + 1 + 7 + 15, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc chunghwa_claa070wp03xg = { + .modes = &chunghwa_claa070wp03xg_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 94, + .height = 150, + }, +}; + static const struct drm_display_mode chunghwa_claa101wa01a_mode = { .clock = 72070, .hdisplay = 1366, @@ -1544,6 +1568,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "avic,tm070ddh03", .data = &avic_tm070ddh03, }, { + .compatible = "chunghwa,claa070wp03xg", + .data = &chunghwa_claa070wp03xg, + }, { .compatible = "chunghwa,claa101wa01a", .data = &chunghwa_claa101wa01a }, { -- 2.7.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel 2016-09-19 19:02 ` [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel Randy Li @ 2016-09-23 18:00 ` Rob Herring 2016-09-28 19:51 ` ayaka 2016-12-06 15:46 ` Thierry Reding 1 sibling, 1 reply; 11+ messages in thread From: Rob Herring @ 2016-09-23 18:00 UTC (permalink / raw) To: Randy Li Cc: dri-devel, linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, thierry.reding, airlied, a.hajda, devicetree On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: > The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be > supported by the simple panel driver. > > Signed-off-by: Randy Li <ayaka@soulik.info> > --- > .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > new file mode 100644 > index 0000000..dd22685 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > @@ -0,0 +1,7 @@ > +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel > + > +Required properties: > +- compatible: should be "chunghwa,claa070wp03xg" What about VCC, VLED, LED_EN (PWM), LVBIT, LVFMT, DITHER signals? > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel 2016-09-23 18:00 ` Rob Herring @ 2016-09-28 19:51 ` ayaka 0 siblings, 0 replies; 11+ messages in thread From: ayaka @ 2016-09-28 19:51 UTC (permalink / raw) To: Rob Herring Cc: dri-devel, linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, thierry.reding, airlied, a.hajda, devicetree On 09/24/2016 02:00 AM, Rob Herring wrote: > On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: >> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be >> supported by the simple panel driver. >> >> Signed-off-by: Randy Li <ayaka@soulik.info> >> --- >> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> new file mode 100644 >> index 0000000..dd22685 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> @@ -0,0 +1,7 @@ >> +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "chunghwa,claa070wp03xg" > What about VCC, VLED, LED_EN (PWM), LVBIT, LVFMT, DITHER signals? I didn't see the other simple-panel has that, so I didn't neither. And I think it would only have VCC and LED_EN(PWM). > >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel 2016-09-19 19:02 ` [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel Randy Li 2016-09-23 18:00 ` Rob Herring @ 2016-12-06 15:46 ` Thierry Reding 2016-12-07 0:57 ` Ayaka 1 sibling, 1 reply; 11+ messages in thread From: Thierry Reding @ 2016-12-06 15:46 UTC (permalink / raw) To: Randy Li Cc: dri-devel, linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, airlied, a.hajda, devicetree [-- Attachment #1: Type: text/plain, Size: 542 bytes --] On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: > The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be > supported by the simple panel driver. > > Signed-off-by: Randy Li <ayaka@soulik.info> > --- > .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt Applied, thanks. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel 2016-12-06 15:46 ` Thierry Reding @ 2016-12-07 0:57 ` Ayaka 2016-12-07 14:55 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Ayaka @ 2016-12-07 0:57 UTC (permalink / raw) To: Thierry Reding Cc: dri-devel, linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc, linux-kernel, airlied, a.hajda, devicetree 從我的 iPad 傳送 > Thierry Reding <thierry.reding@gmail.com> 於 2016年12月6日 下午11:46 寫道： > >> On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: >> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be >> supported by the simple panel driver. >> >> Signed-off-by: Randy Li <ayaka@soulik.info> >> --- >> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > > Applied, thanks. Wait, it is RFC, not pass the test. > > Thierry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel 2016-12-07 0:57 ` Ayaka @ 2016-12-07 14:55 ` Daniel Vetter 2016-12-22 14:17 ` ayaka 0 siblings, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2016-12-07 14:55 UTC (permalink / raw) To: Ayaka Cc: Thierry Reding, devicetree, linux-samsung-soc, linux, krzk, linux-kernel, kgene, dri-devel, linux-arm-kernel On Wed, Dec 07, 2016 at 08:57:23AM +0800, Ayaka wrote: > > > 從我的 iPad 傳送 > > > Thierry Reding <thierry.reding@gmail.com> 於 2016年12月6日 下午11:46 寫道： > > > >> On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: > >> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be > >> supported by the simple panel driver. > >> > >> Signed-off-by: Randy Li <ayaka@soulik.info> > >> --- > >> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ > >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ > >> 2 files changed, 34 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt > > > > Applied, thanks. > Wait, it is RFC, not pass the test. Well 2 months of silence, it's reasonable to assume that this works for you ... I guess you need to supply a fixup patch asap ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel 2016-12-07 14:55 ` Daniel Vetter @ 2016-12-22 14:17 ` ayaka 0 siblings, 0 replies; 11+ messages in thread From: ayaka @ 2016-12-22 14:17 UTC (permalink / raw) To: Thierry Reding, devicetree, linux-samsung-soc, linux, krzk, linux-kernel, kgene, dri-devel, linux-arm-kernel On 12/07/2016 10:55 PM, Daniel Vetter wrote: > On Wed, Dec 07, 2016 at 08:57:23AM +0800, Ayaka wrote: >> >> 從我的 iPad 傳送 >> >>> Thierry Reding <thierry.reding@gmail.com> 於 2016年12月6日 下午11:46 寫道： >>> >>>> On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: >>>> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be >>>> supported by the simple panel driver. >>>> >>>> Signed-off-by: Randy Li <ayaka@soulik.info> >>>> --- >>>> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ >>>> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >>>> 2 files changed, 34 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >>> Applied, thanks. >> Wait, it is RFC, not pass the test. > Well 2 months of silence, it's reasonable to assume that this works for > you ... I guess you need to supply a fixup patch asap ;-) Sorry, my exynos 4412 board is broken, I will order one and fix this problem, please don't merge this patch until somebody confirm that it is adjusted to correct parameter. > -Daniel ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-12-22 14:18 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-09-19 19:02 [RFC PATCH v3 0/2] adding panel claa070wp03xg support for exynos Randy Li 2016-09-19 19:02 ` [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite Randy Li 2016-09-19 19:12 ` Fabio Estevam 2016-09-19 19:17 ` ayaka 2016-09-19 19:02 ` [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel Randy Li 2016-09-23 18:00 ` Rob Herring 2016-09-28 19:51 ` ayaka 2016-12-06 15:46 ` Thierry Reding 2016-12-07 0:57 ` Ayaka 2016-12-07 14:55 ` Daniel Vetter 2016-12-22 14:17 ` ayaka
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).