* [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()
@ 2016-12-07 11:14 Dan Carpenter
2016-12-07 20:46 ` Iyappan Subramanian
2016-12-08 16:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-12-07 11:14 UTC (permalink / raw)
To: Iyappan Subramanian; +Cc: Keyur Chudgar, netdev, linux-kernel, kernel-janitors
We never set "slots" in this function.
Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I copied how slots gets set in xgene_enet_rx_frame(). Static analysis.
Not tested.
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 6c7eea8b36af..884a334e82d0 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
return;
dev = ndev_to_dev(buf_pool->ndev);
+ slots = buf_pool->slots - 1;
head = buf_pool->head;
for (i = 0; i < 4; i++) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()
2016-12-07 11:14 [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Dan Carpenter
@ 2016-12-07 20:46 ` Iyappan Subramanian
2016-12-08 16:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Iyappan Subramanian @ 2016-12-07 20:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Keyur Chudgar, netdev, linux-kernel, kernel-janitors
On Wed, Dec 7, 2016 at 3:14 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We never set "slots" in this function.
>
> Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I copied how slots gets set in xgene_enet_rx_frame(). Static analysis.
> Not tested.
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> index 6c7eea8b36af..884a334e82d0 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
> @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
> return;
>
> dev = ndev_to_dev(buf_pool->ndev);
> + slots = buf_pool->slots - 1;
> head = buf_pool->head;
>
> for (i = 0; i < 4; i++) {
Thanks.
Acked-by: Iyappan Subramanian <isubramanian@apm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()
2016-12-07 11:14 [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Dan Carpenter
2016-12-07 20:46 ` Iyappan Subramanian
@ 2016-12-08 16:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-12-08 16:30 UTC (permalink / raw)
To: dan.carpenter
Cc: isubramanian, kchudgar, netdev, linux-kernel, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 7 Dec 2016 14:14:24 +0300
> We never set "slots" in this function.
>
> Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-08 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-07 11:14 [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Dan Carpenter
2016-12-07 20:46 ` Iyappan Subramanian
2016-12-08 16:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).