* Re: [PATCH] USB: OHCI: pxa27x: fix warnings and errors [not found] <1480976338-15646-1-git-send-email-csmanjuvijay@gmail.com> @ 2016-12-06 7:07 ` Greg Kroah-Hartman 2016-12-06 7:08 ` Greg Kroah-Hartman [not found] ` <1481153865-20554-1-git-send-email-csmanjuvijay@gmail.com> 2 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2016-12-06 7:07 UTC (permalink / raw) To: csmanjuvijay; +Cc: Alan Stern, linux-usb, linux-kernel On Mon, Dec 05, 2016 at 10:18:58PM +0000, csmanjuvijay@gmail.com wrote: > From: Manjunath Goudar <csmanjuvijay@gmail.com> > > This patch will fix the checkpatch.pl warnings and errors. what warnings and errors? Please always be specific. And don't send a single patch to fix everything up, break it up into logical types of fixes please. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: OHCI: pxa27x: fix warnings and errors [not found] <1480976338-15646-1-git-send-email-csmanjuvijay@gmail.com> 2016-12-06 7:07 ` [PATCH] USB: OHCI: pxa27x: fix warnings and errors Greg Kroah-Hartman @ 2016-12-06 7:08 ` Greg Kroah-Hartman [not found] ` <1481153865-20554-1-git-send-email-csmanjuvijay@gmail.com> 2 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2016-12-06 7:08 UTC (permalink / raw) To: csmanjuvijay; +Cc: Alan Stern, linux-usb, linux-kernel On Mon, Dec 05, 2016 at 10:18:58PM +0000, csmanjuvijay@gmail.com wrote: > From: Manjunath Goudar <csmanjuvijay@gmail.com> > > This patch will fix the checkpatch.pl warnings and errors. > > Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com> > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/usb/host/ohci-pxa27x.c | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index 79efde8f..c50a767 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -106,7 +106,8 @@ > #define UHCHIE_UPS2IE (1 << 12) /* Power Sense Port2 IntEn */ > #define UHCHIE_UPS1IE (1 << 11) /* Power Sense Port1 IntEn */ > #define UHCHIE_TAIE (1 << 10) /* HCI Interface Transfer Abort > - Interrupt Enable*/ > + * Interrupt Enable > + */ > #define UHCHIE_HBAIE (1 << 8) /* HCI Buffer Active IntEn */ > #define UHCHIE_RWIE (1 << 7) /* Remote Wake-up IntEn */ > > @@ -128,14 +129,14 @@ struct pxa27x_ohci { > #define to_pxa27x_ohci(hcd) (struct pxa27x_ohci *)(hcd_to_ohci(hcd)->priv) > > /* > - PMM_NPS_MODE -- PMM Non-power switching mode > - Ports are powered continuously. > - > - PMM_GLOBAL_MODE -- PMM global switching mode > - All ports are powered at the same time. > - > - PMM_PERPORT_MODE -- PMM per port switching mode > - Ports are powered individually. > + * PMM_NPS_MODE -- PMM Non-power switching mode > + * Ports are powered continuously. > + * > + * PMM_GLOBAL_MODE -- PMM global switching mode > + * All ports are powered at the same time. > + * > + * PMM_PERPORT_MODE -- PMM per port switching mode > + * Ports are powered individually. > */ > static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) > { > @@ -157,10 +158,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) > uhcrhdb |= (0x7<<17); > break; > default: > - printk( KERN_ERR > - "Invalid mode %d, set to non-power switch mode.\n", > - mode ); > - > + pr_err("Invalid mode %d,set to non-power switch mode.\n", mode); Use dev_err() please. > uhcrhda |= RH_A_NPS; > } > > @@ -541,7 +539,7 @@ static int ohci_hcd_pxa27x_drv_suspend(struct device *dev) > > > if (time_before(jiffies, ohci->next_statechange)) > - msleep(5); > + usleep_range(5000, 10000); This is totally wrong :( > ohci->next_statechange = jiffies; > > ret = ohci_suspend(hcd, do_wakeup); > @@ -561,7 +559,7 @@ static int ohci_hcd_pxa27x_drv_resume(struct device *dev) > int status; > > if (time_before(jiffies, ohci->next_statechange)) > - msleep(5); > + usleep_range(5000, 10000); As is this :( Did you not check these changes? ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1481153865-20554-1-git-send-email-csmanjuvijay@gmail.com>]
* Re: [PATCH v2] USB: OHCI: pxa27x:fix warnings and error [not found] ` <1481153865-20554-1-git-send-email-csmanjuvijay@gmail.com> @ 2016-12-08 16:49 ` Greg Kroah-Hartman [not found] ` <CAKsNYyyAx-OA5-4qJc-49Qt3n7u6Dq8SFy+KQsOLPKje4wAzag@mail.gmail.com> 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2016-12-08 16:49 UTC (permalink / raw) To: csmanjuvijay; +Cc: Alan Stern, linux-usb, linux-kernel On Wed, Dec 07, 2016 at 11:37:45PM +0000, csmanjuvijay@gmail.com wrote: > From: Manjunath Goudar <csmanjuvijay@gmail.com> > > This patch will fix the checkpatch.pl following warnings and error: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a separate line > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, > ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > ERROR: space prohibited after that open parenthesis '(' > > Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com> > Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > changelog V1->V2: > Warnings and error message is added to the patch discrition. > > drivers/usb/host/ohci-pxa27x.c | 24 +++++++++++------------- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c > index 79efde8f..73445ab 100644 > --- a/drivers/usb/host/ohci-pxa27x.c > +++ b/drivers/usb/host/ohci-pxa27x.c > @@ -106,7 +106,8 @@ > #define UHCHIE_UPS2IE (1 << 12) /* Power Sense Port2 IntEn */ > #define UHCHIE_UPS1IE (1 << 11) /* Power Sense Port1 IntEn */ > #define UHCHIE_TAIE (1 << 10) /* HCI Interface Transfer Abort > - Interrupt Enable*/ > + * Interrupt Enable > + */ > #define UHCHIE_HBAIE (1 << 8) /* HCI Buffer Active IntEn */ > #define UHCHIE_RWIE (1 << 7) /* Remote Wake-up IntEn */ > > @@ -128,14 +129,14 @@ struct pxa27x_ohci { > #define to_pxa27x_ohci(hcd) (struct pxa27x_ohci *)(hcd_to_ohci(hcd)->priv) > > /* > - PMM_NPS_MODE -- PMM Non-power switching mode > - Ports are powered continuously. > - > - PMM_GLOBAL_MODE -- PMM global switching mode > - All ports are powered at the same time. > - > - PMM_PERPORT_MODE -- PMM per port switching mode > - Ports are powered individually. > + * PMM_NPS_MODE -- PMM Non-power switching mode > + * Ports are powered continuously. > + * > + * PMM_GLOBAL_MODE -- PMM global switching mode > + * All ports are powered at the same time. > + * > + * PMM_PERPORT_MODE -- PMM per port switching mode > + * Ports are powered individually. > */ > static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) > { > @@ -157,10 +158,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) > uhcrhdb |= (0x7<<17); > break; > default: > - printk( KERN_ERR > - "Invalid mode %d, set to non-power switch mode.\n", > - mode ); > - > + dev_err(mode, "Invalid mode %d,set to non-power switch mode.\n"); Did you even compile this code? Please do so... And don't mix different types of fixes in the same patch please. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAKsNYyyAx-OA5-4qJc-49Qt3n7u6Dq8SFy+KQsOLPKje4wAzag@mail.gmail.com>]
* Re: [PATCH v2] USB: OHCI: pxa27x:fix warnings and error [not found] ` <CAKsNYyyAx-OA5-4qJc-49Qt3n7u6Dq8SFy+KQsOLPKje4wAzag@mail.gmail.com> @ 2016-12-09 7:16 ` Greg Kroah-Hartman 0 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2016-12-09 7:16 UTC (permalink / raw) To: manju goudar; +Cc: Alan Stern, USB list, linux-kernel On Thu, Dec 08, 2016 at 10:30:35PM +0000, manju goudar wrote: > > > On Thu, Dec 8, 2016 at 4:49 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> > wrote: > > On Wed, Dec 07, 2016 at 11:37:45PM +0000, csmanjuvijay@gmail.com wrote: > > From: Manjunath Goudar <csmanjuvijay@gmail.com> > > > > This patch will fix the checkpatch.pl following warnings and error: > > WARNING: Block comments use * on subsequent lines > > WARNING: Block comments use a trailing */ on a separate line > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, > > ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > ERROR: space prohibited after that open parenthesis '(' > > > > Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com> > > Cc: Alan Stern <stern@rowland.harvard.edu> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: linux-usb@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > --- > > changelog V1->V2: > > Warnings and error message is added to the patch discrition. > > > > drivers/usb/host/ohci-pxa27x.c | 24 +++++++++++------------- > > 1 file changed, 11 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci- > pxa27x.c > > index 79efde8f..73445ab 100644 > > --- a/drivers/usb/host/ohci-pxa27x.c > > +++ b/drivers/usb/host/ohci-pxa27x.c > > @@ -106,7 +106,8 @@ > > #define UHCHIE_UPS2IE (1 << 12) /* Power Sense Port2 IntEn > */ > > #define UHCHIE_UPS1IE (1 << 11) /* Power Sense Port1 IntEn > */ > > #define UHCHIE_TAIE (1 << 10) /* HCI Interface Transfer Abort > > - Interrupt Enable*/ > > + * Interrupt Enable > > + */ > > #define UHCHIE_HBAIE (1 << 8) /* HCI Buffer Active IntEn */ > > #define UHCHIE_RWIE (1 << 7) /* Remote Wake-up IntEn */ > > > > @@ -128,14 +129,14 @@ struct pxa27x_ohci { > > #define to_pxa27x_ohci(hcd) (struct pxa27x_ohci *)(hcd_to_ohci(hcd)-> > priv) > > > > /* > > - PMM_NPS_MODE -- PMM Non-power switching mode > > - Ports are powered continuously. > > - > > - PMM_GLOBAL_MODE -- PMM global switching mode > > - All ports are powered at the same time. > > - > > - PMM_PERPORT_MODE -- PMM per port switching mode > > - Ports are powered individually. > > + * PMM_NPS_MODE -- PMM Non-power switching mode > > + * Ports are powered continuously. > > + * > > + * PMM_GLOBAL_MODE -- PMM global switching mode > > + * All ports are powered at the same time. > > + * > > + * PMM_PERPORT_MODE -- PMM per port switching mode > > + * Ports are powered individually. > > */ > > static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int > mode) > > { > > @@ -157,10 +158,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci > *pxa_ohci, int mode) > > uhcrhdb |= (0x7<<17); > > break; > > default: > > - printk( KERN_ERR > > - "Invalid mode %d, set to non-power switch mode.\n", > > - mode ); > > - > > + dev_err(mode, "Invalid mode %d,set to non-power switch > mode.\n"); > > Did you even compile this code? > > > Yes It is successful compiled. I don't believe you. Look at your change here and tell me how that dev_err() function is correct. > Please do so... > > And don't mix different types of fixes in the same patch please. > > don't mix up means each type of warning fix as a separate patch? Yes please. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-09 7:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1480976338-15646-1-git-send-email-csmanjuvijay@gmail.com>
2016-12-06 7:07 ` [PATCH] USB: OHCI: pxa27x: fix warnings and errors Greg Kroah-Hartman
2016-12-06 7:08 ` Greg Kroah-Hartman
[not found] ` <1481153865-20554-1-git-send-email-csmanjuvijay@gmail.com>
2016-12-08 16:49 ` [PATCH v2] USB: OHCI: pxa27x:fix warnings and error Greg Kroah-Hartman
[not found] ` <CAKsNYyyAx-OA5-4qJc-49Qt3n7u6Dq8SFy+KQsOLPKje4wAzag@mail.gmail.com>
2016-12-09 7:16 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).