* Re: [PATCH 0/7] Move dell-led to drivers/platform/x86 [not found] ` <CAE7LaDAQokSHNvwEfVnUiAQT=hzsgXtq9rgi5dw3qTewnBkSSg@mail.gmail.com> @ 2016-12-15 14:57 ` Michał Kępień 0 siblings, 0 replies; 4+ messages in thread From: Michał Kępień @ 2016-12-15 14:57 UTC (permalink / raw) To: Anthony Wong Cc: Mario.Limonciello, Pali Rohár, j.anaszewski, rpurdie, mjg59, Darren Hart, perex, tiwai, Louis.Davis, Jim.Dailey, Alex Hung, Hui Wang (Jason), linux-leds, platform-driver-x86, alsa-devel, linux-kernel > On 12 December 2016 at 01:13, <Mario.Limonciello@dell.com> wrote: > > > add Anthony Wong @ Canonical. > > > > I'm about to go on break and won't have access to hardware for a while. > > > > Anthony, > > > > Your team has this hardware more readily available than I do. Would you be > > able to have someone on the team verify this series? > > > Sorry, just back from vacation. > > Yes, we can test it here some time next week. That is great news, thanks! I will try to post a v2 of this patch series within the next few days, so hopefully it will be ready before you get around to testing. I will keep you in the loop. -- Best regards, Michał Kępień ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CGME20161208123909epcas3p23229f5e0d337e19a27b272211798d364@epcas3p2.samsung.com>]
* [PATCH 0/7] Move dell-led to drivers/platform/x86 @ 2016-12-08 12:36 ` Michał Kępień 2016-12-08 14:26 ` Jacek Anaszewski 0 siblings, 1 reply; 4+ messages in thread From: Michał Kępień @ 2016-12-08 12:36 UTC (permalink / raw) To: Richard Purdie, Jacek Anaszewski, Matthew Garrett, Pali Rohár, Darren Hart, Jaroslav Kysela, Takashi Iwai Cc: Bob Rodgers, Louis Davis, Jim Dailey, Alex Hung, Hui Wang, linux-leds, platform-driver-x86, alsa-devel, linux-kernel This patch series moves the dell-led driver from the LED subsystem to the x86 platform driver subsystem. I decided to also CC the sound subsystem contacts for the whole series as sound/pci/hda/dell_wmi_helper.c is also affected. The original motivation behind this effort was to move all code using the dell-smbios module to the x86 platform driver subsystem. While I was investigating the possibilites to do that, it quickly emerged that dell-led can and in fact should be moved to the x86 platform driver subsystem in its entirety. dell-led consists of two major parts: - the part exposing a microphone mute LED interface, introduced in db6d8cc ("dell-led: add mic mute led interface"); this interface is used by sound/pci/hda/dell_wmi_helper.c; while the original implementation used a WMI interface, it was changed to use dell-smbios in cf0d7ea ("dell-led: use dell_smbios_find_token() for finding mic DMI tokens") and 0c41a08 ("dell-led: use dell_smbios_send_request() for performing SMBIOS calls"), - the part handling an activity LED present in Dell Latitude 2100 netbooks, introduced in 72dcd8d ("leds: Add Dell Business Class Netbook LED driver"); it binds to a specific WMI GUID and then registers a LED device which is controlled using WMI (i.e. it is basically a WMI driver). Patches 1-4 clean up the microphone mute LED interface to minimize the amount of code moved around. Patch 5 moves the microphone mute LED interface to drivers/platform/x86/dell-laptop.c, effectively causing sound/pci/hda/dell_wmi_helper.c to depend on CONFIG_DELL_LAPTOP instead of CONFIG_LEDS_DELL_NETBOOKS. Patch 6 reverts dell-led to the state it was in after its initial commit 72dcd8d ("leds: Add Dell Business Class Netbook LED driver") by removing all remnants of the microphone mute LED handling code. Patch 7 moves all that is left of dell-led (i.e. the activity LED part, as originally implemented), to a new module which is placed in drivers/platform/x86/dell-wmi-led.c. This patch series is based on linux-leds/for-4.11 as the LED subsystem is affected by all patches except patch 3. If anyone reading this has access to a Dell device which has an activity LED and/or a microphone mute LED currently supported by dell-led, I would love to hear from you as I do not have the hardware needed to practically test this patch series. drivers/leds/Kconfig | 9 --- drivers/leds/Makefile | 1 - drivers/platform/x86/Kconfig | 8 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/dell-laptop.c | 28 ++++++++ .../dell-led.c => platform/x86/dell-wmi-led.c} | 75 +++------------------- include/linux/dell-led.h | 6 +- sound/pci/hda/dell_wmi_helper.c | 18 +++--- 8 files changed, 55 insertions(+), 91 deletions(-) rename drivers/{leds/dell-led.c => platform/x86/dell-wmi-led.c} (73%) -- 2.10.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/7] Move dell-led to drivers/platform/x86 2016-12-08 12:36 ` Michał Kępień @ 2016-12-08 14:26 ` Jacek Anaszewski 2016-12-11 10:45 ` Pali Rohár 0 siblings, 1 reply; 4+ messages in thread From: Jacek Anaszewski @ 2016-12-08 14:26 UTC (permalink / raw) To: Michał Kępień, Richard Purdie, Matthew Garrett, Pali Rohár, Darren Hart, Jaroslav Kysela, Takashi Iwai Cc: Bob Rodgers, Louis Davis, Jim Dailey, Alex Hung, Hui Wang, linux-leds, platform-driver-x86, alsa-devel, linux-kernel Hi Michał, Thanks for the patch set. On 12/08/2016 01:36 PM, Michał Kępień wrote: > This patch series moves the dell-led driver from the LED subsystem to > the x86 platform driver subsystem. I decided to also CC the sound > subsystem contacts for the whole series as > sound/pci/hda/dell_wmi_helper.c is also affected. > > The original motivation behind this effort was to move all code using > the dell-smbios module to the x86 platform driver subsystem. While I > was investigating the possibilites to do that, it quickly emerged that > dell-led can and in fact should be moved to the x86 platform driver > subsystem in its entirety. > > dell-led consists of two major parts: > > - the part exposing a microphone mute LED interface, introduced in > db6d8cc ("dell-led: add mic mute led interface"); this interface is > used by sound/pci/hda/dell_wmi_helper.c; while the original > implementation used a WMI interface, it was changed to use > dell-smbios in cf0d7ea ("dell-led: use dell_smbios_find_token() for > finding mic DMI tokens") and 0c41a08 ("dell-led: use > dell_smbios_send_request() for performing SMBIOS calls"), > > - the part handling an activity LED present in Dell Latitude 2100 > netbooks, introduced in 72dcd8d ("leds: Add Dell Business Class > Netbook LED driver"); it binds to a specific WMI GUID and then > registers a LED device which is controlled using WMI (i.e. it is > basically a WMI driver). > > Patches 1-4 clean up the microphone mute LED interface to minimize the > amount of code moved around. > > Patch 5 moves the microphone mute LED interface to > drivers/platform/x86/dell-laptop.c, effectively causing > sound/pci/hda/dell_wmi_helper.c to depend on CONFIG_DELL_LAPTOP instead > of CONFIG_LEDS_DELL_NETBOOKS. > > Patch 6 reverts dell-led to the state it was in after its initial commit > 72dcd8d ("leds: Add Dell Business Class Netbook LED driver") by removing > all remnants of the microphone mute LED handling code. > > Patch 7 moves all that is left of dell-led (i.e. the activity LED part, > as originally implemented), to a new module which is placed in > drivers/platform/x86/dell-wmi-led.c. > > This patch series is based on linux-leds/for-4.11 as the LED subsystem > is affected by all patches except patch 3. > > If anyone reading this has access to a Dell device which has an activity > LED and/or a microphone mute LED currently supported by dell-led, I > would love to hear from you as I do not have the hardware needed to > practically test this patch series. I think that it is necessary to find someone who will give their Tested-by. What I can accept immediately is moving the driver in the current shape to x86 platform drivers. I could expose a stable branch with that patch for the x86 platform maintainers then. > drivers/leds/Kconfig | 9 --- > drivers/leds/Makefile | 1 - > drivers/platform/x86/Kconfig | 8 +++ > drivers/platform/x86/Makefile | 1 + > drivers/platform/x86/dell-laptop.c | 28 ++++++++ > .../dell-led.c => platform/x86/dell-wmi-led.c} | 75 +++------------------- > include/linux/dell-led.h | 6 +- > sound/pci/hda/dell_wmi_helper.c | 18 +++--- > 8 files changed, 55 insertions(+), 91 deletions(-) > rename drivers/{leds/dell-led.c => platform/x86/dell-wmi-led.c} (73%) > -- Best regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/7] Move dell-led to drivers/platform/x86 2016-12-08 14:26 ` Jacek Anaszewski @ 2016-12-11 10:45 ` Pali Rohár 0 siblings, 0 replies; 4+ messages in thread From: Pali Rohár @ 2016-12-11 10:45 UTC (permalink / raw) To: Jacek Anaszewski, mario.limonciello Cc: Michał Kępień, Richard Purdie, Matthew Garrett, Darren Hart, Jaroslav Kysela, Takashi Iwai, Louis Davis, Jim Dailey, Alex Hung, Hui Wang, linux-leds, platform-driver-x86, alsa-devel, linux-kernel [-- Attachment #1: Type: Text/Plain, Size: 3969 bytes --] On Thursday 08 December 2016 15:26:37 Jacek Anaszewski wrote: > Hi Michał, > > Thanks for the patch set. > > On 12/08/2016 01:36 PM, Michał Kępień wrote: > > This patch series moves the dell-led driver from the LED subsystem > > to the x86 platform driver subsystem. I decided to also CC the > > sound subsystem contacts for the whole series as > > sound/pci/hda/dell_wmi_helper.c is also affected. > > > > The original motivation behind this effort was to move all code > > using the dell-smbios module to the x86 platform driver subsystem. > > While I was investigating the possibilites to do that, it quickly > > emerged that dell-led can and in fact should be moved to the x86 > > platform driver subsystem in its entirety. > > > > dell-led consists of two major parts: > > - the part exposing a microphone mute LED interface, introduced > > in > > > > db6d8cc ("dell-led: add mic mute led interface"); this > > interface is used by sound/pci/hda/dell_wmi_helper.c; while > > the original implementation used a WMI interface, it was > > changed to use dell-smbios in cf0d7ea ("dell-led: use > > dell_smbios_find_token() for finding mic DMI tokens") and > > 0c41a08 ("dell-led: use > > dell_smbios_send_request() for performing SMBIOS calls"), > > > > - the part handling an activity LED present in Dell Latitude 2100 > > > > netbooks, introduced in 72dcd8d ("leds: Add Dell Business Class > > Netbook LED driver"); it binds to a specific WMI GUID and then > > registers a LED device which is controlled using WMI (i.e. it > > is basically a WMI driver). > > > > Patches 1-4 clean up the microphone mute LED interface to minimize > > the amount of code moved around. > > > > Patch 5 moves the microphone mute LED interface to > > drivers/platform/x86/dell-laptop.c, effectively causing > > sound/pci/hda/dell_wmi_helper.c to depend on CONFIG_DELL_LAPTOP > > instead of CONFIG_LEDS_DELL_NETBOOKS. > > > > Patch 6 reverts dell-led to the state it was in after its initial > > commit 72dcd8d ("leds: Add Dell Business Class Netbook LED > > driver") by removing all remnants of the microphone mute LED > > handling code. > > > > Patch 7 moves all that is left of dell-led (i.e. the activity LED > > part, as originally implemented), to a new module which is placed > > in drivers/platform/x86/dell-wmi-led.c. > > > > This patch series is based on linux-leds/for-4.11 as the LED > > subsystem is affected by all patches except patch 3. > > > > If anyone reading this has access to a Dell device which has an > > activity LED and/or a microphone mute LED currently supported by > > dell-led, I would love to hear from you as I do not have the > > hardware needed to practically test this patch series. > > I think that it is necessary to find someone who will give their > Tested-by. > > What I can accept immediately is moving the driver in the current > shape to x86 platform drivers. I could expose a stable branch with > that patch for the x86 platform maintainers then. Adding Mario Limonciello from @dell to discussion. Mario, any chance you could be able to test this patch series? > > drivers/leds/Kconfig | 9 --- > > drivers/leds/Makefile | 1 - > > drivers/platform/x86/Kconfig | 8 +++ > > drivers/platform/x86/Makefile | 1 + > > drivers/platform/x86/dell-laptop.c | 28 ++++++++ > > .../dell-led.c => platform/x86/dell-wmi-led.c} | 75 > > +++------------------- include/linux/dell-led.h > > | 6 +- sound/pci/hda/dell_wmi_helper.c > > | 18 +++--- 8 files changed, 55 insertions(+), 91 deletions(-) > > rename drivers/{leds/dell-led.c => platform/x86/dell-wmi-led.c} > > (73%) -- Pali Rohár pali.rohar@gmail.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-15 14:57 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <00c7k8btg2g3lgupdy340rwj.1481476421177@email.android.com> [not found] ` <CAE7LaDAQokSHNvwEfVnUiAQT=hzsgXtq9rgi5dw3qTewnBkSSg@mail.gmail.com> 2016-12-15 14:57 ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Michał Kępień [not found] <CGME20161208123909epcas3p23229f5e0d337e19a27b272211798d364@epcas3p2.samsung.com> 2016-12-08 12:36 ` Michał Kępień 2016-12-08 14:26 ` Jacek Anaszewski 2016-12-11 10:45 ` Pali Rohár
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).