* [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call
@ 2016-12-20 14:39 Thomas Casey
2016-12-21 6:49 ` Michal Hocko
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Casey @ 2016-12-20 14:39 UTC (permalink / raw)
To: akpm
Cc: john.stultz, tglx, gorcunov, nicolas.pitre, skinsbursky, mguzik,
mhocko, linux-kernel
Fixes two instances of EXPORT_SYMBOL not being called immediately after
the initialization of its argument
Signed-off-by: Thomas Casey <tqcasey@gmail.com>
---
kernel/sys.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/sys.c b/kernel/sys.c
index 9758892a2d09..8afd3e341f9b 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -110,9 +110,8 @@
*/
int overflowuid = DEFAULT_OVERFLOWUID;
-int overflowgid = DEFAULT_OVERFLOWGID;
-
EXPORT_SYMBOL(overflowuid);
+int overflowgid = DEFAULT_OVERFLOWGID;
EXPORT_SYMBOL(overflowgid);
/*
@@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid);
*/
int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
-int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
-
EXPORT_SYMBOL(fs_overflowuid);
+int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
EXPORT_SYMBOL(fs_overflowgid);
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call
2016-12-20 14:39 [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call Thomas Casey
@ 2016-12-21 6:49 ` Michal Hocko
0 siblings, 0 replies; 2+ messages in thread
From: Michal Hocko @ 2016-12-21 6:49 UTC (permalink / raw)
To: Thomas Casey
Cc: akpm, john.stultz, tglx, gorcunov, nicolas.pitre, skinsbursky,
mguzik, linux-kernel
On Tue 20-12-16 14:39:19, Thomas Casey wrote:
> Fixes two instances of EXPORT_SYMBOL not being called immediately after
> the initialization of its argument
What does this fix actually?
> Signed-off-by: Thomas Casey <tqcasey@gmail.com>
> ---
> kernel/sys.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 9758892a2d09..8afd3e341f9b 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -110,9 +110,8 @@
> */
>
> int overflowuid = DEFAULT_OVERFLOWUID;
> -int overflowgid = DEFAULT_OVERFLOWGID;
> -
> EXPORT_SYMBOL(overflowuid);
> +int overflowgid = DEFAULT_OVERFLOWGID;
> EXPORT_SYMBOL(overflowgid);
>
> /*
> @@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid);
> */
>
> int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
> -int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> -
> EXPORT_SYMBOL(fs_overflowuid);
> +int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> EXPORT_SYMBOL(fs_overflowgid);
>
> /*
> --
> 2.11.0
>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-21 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-20 14:39 [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call Thomas Casey
2016-12-21 6:49 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).