* [PATCH] selftests: ipc add missing generated file to .gitignore
2017-01-05 21:32 [PATCH] selftests: gpio add .gitignore for generated files Shuah Khan
@ 2017-01-05 21:32 ` Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: x86 protection_keys fix unused variable compile warnings Shuah Khan
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2017-01-05 21:32 UTC (permalink / raw)
To: shuah, sudeep.holla; +Cc: Shuah Khan, linux-kselftest, linux-kernel
Add missing generated file msgque to .gitignore
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
tools/testing/selftests/ipc/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/ipc/.gitignore b/tools/testing/selftests/ipc/.gitignore
index 84b66a3..9af04c9 100644
--- a/tools/testing/selftests/ipc/.gitignore
+++ b/tools/testing/selftests/ipc/.gitignore
@@ -1 +1,2 @@
msgque_test
+msgque
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] selftests: x86 protection_keys fix unused variable compile warnings
2017-01-05 21:32 [PATCH] selftests: gpio add .gitignore for generated files Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: ipc add missing generated file to .gitignore Shuah Khan
@ 2017-01-05 21:32 ` Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: x86 protection_keys remove dead code Shuah Khan
2017-01-05 21:32 ` [PATCH] tools: gpio add .gitignore for generated files Shuah Khan
3 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2017-01-05 21:32 UTC (permalink / raw)
To: shuah, dave.hansen, tglx; +Cc: Shuah Khan, linux-kselftest, linux-kernel
Fix unused variable compile warnings in protection_keys.c
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
tools/testing/selftests/x86/protection_keys.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/testing/selftests/x86/protection_keys.c b/tools/testing/selftests/x86/protection_keys.c
index bdd58c7..70402cd 100644
--- a/tools/testing/selftests/x86/protection_keys.c
+++ b/tools/testing/selftests/x86/protection_keys.c
@@ -812,8 +812,6 @@ void setup_hugetlbfs(void)
{
int err;
int fd;
- int validated_nr_pages;
- int i;
char buf[] = "123";
if (geteuid() != 0) {
@@ -1133,7 +1131,6 @@ void test_pkey_syscalls_on_non_allocated_pkey(int *ptr, u16 pkey)
void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
{
int err;
- int bad_flag = (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE) + 1;
int bad_pkey = NR_PKEYS+99;
/* not enforced when pkey_get() is not a syscall
@@ -1149,8 +1146,6 @@ void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
/* Assumes that all pkeys other than 'pkey' are unallocated */
void test_pkey_alloc_exhaust(int *ptr, u16 pkey)
{
- unsigned long flags;
- unsigned long init_val;
int err;
int allocated_pkeys[NR_PKEYS] = {0};
int nr_allocated_pkeys = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] selftests: x86 protection_keys remove dead code
2017-01-05 21:32 [PATCH] selftests: gpio add .gitignore for generated files Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: ipc add missing generated file to .gitignore Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: x86 protection_keys fix unused variable compile warnings Shuah Khan
@ 2017-01-05 21:32 ` Shuah Khan
2017-01-05 21:32 ` [PATCH] tools: gpio add .gitignore for generated files Shuah Khan
3 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2017-01-05 21:32 UTC (permalink / raw)
To: shuah, dave.hansen, tglx; +Cc: Shuah Khan, linux-kselftest, linux-kernel
Remove commented out calls to pkey_get().
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
tools/testing/selftests/x86/protection_keys.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/tools/testing/selftests/x86/protection_keys.c b/tools/testing/selftests/x86/protection_keys.c
index 70402cd..46f53ec 100644
--- a/tools/testing/selftests/x86/protection_keys.c
+++ b/tools/testing/selftests/x86/protection_keys.c
@@ -1114,11 +1114,6 @@ void test_pkey_syscalls_on_non_allocated_pkey(int *ptr, u16 pkey)
err = sys_pkey_free(i);
pkey_assert(err);
- /* not enforced when pkey_get() is not a syscall
- err = pkey_get(i, 0);
- pkey_assert(err < 0);
- */
-
err = sys_pkey_free(i);
pkey_assert(err);
@@ -1133,11 +1128,6 @@ void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
int err;
int bad_pkey = NR_PKEYS+99;
- /* not enforced when pkey_get() is not a syscall
- err = pkey_get(bad_pkey, bad_flag);
- pkey_assert(err < 0);
- */
-
/* pass a known-invalid pkey in: */
err = sys_mprotect_pkey(ptr, PAGE_SIZE, PROT_READ, bad_pkey);
pkey_assert(err);
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] tools: gpio add .gitignore for generated files
2017-01-05 21:32 [PATCH] selftests: gpio add .gitignore for generated files Shuah Khan
` (2 preceding siblings ...)
2017-01-05 21:32 ` [PATCH] selftests: x86 protection_keys remove dead code Shuah Khan
@ 2017-01-05 21:32 ` Shuah Khan
2017-01-10 9:29 ` Linus Walleij
3 siblings, 1 reply; 9+ messages in thread
From: Shuah Khan @ 2017-01-05 21:32 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: Shuah Khan, linux-kernel, linux-gpio
Add .gitignore for generated files.
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
tools/gpio/.gitignore | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 tools/gpio/.gitignore
diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
new file mode 100644
index 0000000..767ad24
--- /dev/null
+++ b/tools/gpio/.gitignore
@@ -0,0 +1,4 @@
+gpio-event-mon
+gpio-hammer
+lsgpio
+include
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] tools: gpio add .gitignore for generated files
2017-01-05 21:32 ` [PATCH] tools: gpio add .gitignore for generated files Shuah Khan
@ 2017-01-10 9:29 ` Linus Walleij
2017-01-10 14:07 ` Shuah Khan
0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2017-01-10 9:29 UTC (permalink / raw)
To: Shuah Khan; +Cc: Alexandre Courbot, linux-kernel, linux-gpio
On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> Add .gitignore for generated files.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> tools/gpio/.gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
> create mode 100644 tools/gpio/.gitignore
>
> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
> new file mode 100644
> index 0000000..767ad24
> --- /dev/null
> +++ b/tools/gpio/.gitignore
> @@ -0,0 +1,4 @@
> +gpio-event-mon
> +gpio-hammer
> +lsgpio
> +include
I understand the first three.
But "include"?
How did you produce that?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] tools: gpio add .gitignore for generated files
2017-01-10 9:29 ` Linus Walleij
@ 2017-01-10 14:07 ` Shuah Khan
2017-01-11 15:19 ` Linus Walleij
0 siblings, 1 reply; 9+ messages in thread
From: Shuah Khan @ 2017-01-10 14:07 UTC (permalink / raw)
To: Linus Walleij; +Cc: Alexandre Courbot, linux-kernel, linux-gpio, Shuah Khan
On 01/10/2017 02:29 AM, Linus Walleij wrote:
> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>
>> Add .gitignore for generated files.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> tools/gpio/.gitignore | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100644 tools/gpio/.gitignore
>>
>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>> new file mode 100644
>> index 0000000..767ad24
>> --- /dev/null
>> +++ b/tools/gpio/.gitignore
>> @@ -0,0 +1,4 @@
>> +gpio-event-mon
>> +gpio-hammer
>> +lsgpio
>> +include
>
> I understand the first three.
>
> But "include"?
> How did you produce that?
>
> Yours,
> Linus Walleij
>
I saw this after building selftests. gpio selftests Makefile installs
headres. "make kselftest" should reproduce the problem. This following
does an header install from tools/testing/selftests/gpio/Makefile
../../../../usr/include/linux/gpio.h:
make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] tools: gpio add .gitignore for generated files
2017-01-10 14:07 ` Shuah Khan
@ 2017-01-11 15:19 ` Linus Walleij
2017-01-11 16:02 ` Shuah Khan
0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2017-01-11 15:19 UTC (permalink / raw)
To: Shuah Khan; +Cc: Alexandre Courbot, linux-kernel, linux-gpio
On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>
>>> Add .gitignore for generated files.
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>> ---
>>> tools/gpio/.gitignore | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>> create mode 100644 tools/gpio/.gitignore
>>>
>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>> new file mode 100644
>>> index 0000000..767ad24
>>> --- /dev/null
>>> +++ b/tools/gpio/.gitignore
>>> @@ -0,0 +1,4 @@
>>> +gpio-event-mon
>>> +gpio-hammer
>>> +lsgpio
>>> +include
>>
>> I understand the first three.
>>
>> But "include"?
>> How did you produce that?
>>
>> Yours,
>> Linus Walleij
>>
>
> I saw this after building selftests. gpio selftests Makefile installs
> headres. "make kselftest" should reproduce the problem. This following
> does an header install from tools/testing/selftests/gpio/Makefile
>
> ../../../../usr/include/linux/gpio.h:
> make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
That seems like a bug.
I applied the patch removing the ignore line for include,
I think we should see this until we figured out what we do wrong.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] tools: gpio add .gitignore for generated files
2017-01-11 15:19 ` Linus Walleij
@ 2017-01-11 16:02 ` Shuah Khan
0 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2017-01-11 16:02 UTC (permalink / raw)
To: Linus Walleij; +Cc: Alexandre Courbot, linux-kernel, linux-gpio, Shuah Khan
On 01/11/2017 08:19 AM, Linus Walleij wrote:
> On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>>
>>>> Add .gitignore for generated files.
>>>>
>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>> ---
>>>> tools/gpio/.gitignore | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>> create mode 100644 tools/gpio/.gitignore
>>>>
>>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>>> new file mode 100644
>>>> index 0000000..767ad24
>>>> --- /dev/null
>>>> +++ b/tools/gpio/.gitignore
>>>> @@ -0,0 +1,4 @@
>>>> +gpio-event-mon
>>>> +gpio-hammer
>>>> +lsgpio
>>>> +include
>>>
>>> I understand the first three.
>>>
>>> But "include"?
>>> How did you produce that?
>>>
>>> Yours,
>>> Linus Walleij
>>>
>>
>> I saw this after building selftests. gpio selftests Makefile installs
>> headres. "make kselftest" should reproduce the problem. This following
>> does an header install from tools/testing/selftests/gpio/Makefile
>>
>> ../../../../usr/include/linux/gpio.h:
>> make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
>
> That seems like a bug.
>
> I applied the patch removing the ignore line for include,
> I think we should see this until we figured out what we do wrong.
>
> Yours,
> Linus Walleij
>
Sounds good.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread