From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: <lee.jones@linaro.org>
Cc: <patches@opensource.wolfsonmicro.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] mfd: arizona: Update arizona_poll_reg to take a timeout in milliseconds
Date: Fri, 6 Jan 2017 14:19:47 +0000 [thread overview]
Message-ID: <20170106141947.GB27100@localhost.localdomain> (raw)
In-Reply-To: <1483711896-29268-3-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Fri, Jan 06, 2017 at 02:11:35PM +0000, Charles Keepax wrote:
> Currently, we specify the timeout in terms of the number of polls but it
> is more clear from a user of the functions perspective to specify the
> timeout directly in milliseconds, as such update the function to these new
> semantics.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 4cb34c3..1307294 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -235,14 +235,18 @@ static irqreturn_t arizona_overclocked(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> +#define ARIZONA_REG_POLL_DELAY_MS 5
> +
> static int arizona_poll_reg(struct arizona *arizona,
> - int timeout, unsigned int reg,
> + int timeout_ms, unsigned int reg,
> unsigned int mask, unsigned int target)
> {
> + unsigned int npolls = (timeout_ms + ARIZONA_REG_POLL_DELAY_MS - 1) /
> + ARIZONA_REG_POLL_DELAY_MS;
> unsigned int val = 0;
> int ret, i;
>
> - for (i = 0; i < timeout; i++) {
> + for (i = 0; i < npolls; i++) {
> ret = regmap_read(arizona->regmap, reg, &val);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n",
> @@ -253,7 +257,8 @@ static int arizona_poll_reg(struct arizona *arizona,
> if ((val & mask) == target)
> return 0;
>
> - usleep_range(1000, 5000);
> + usleep_range((ARIZONA_REG_POLL_DELAY_MS * 1000) / 2,
> + ARIZONA_REG_POLL_DELAY_MS);
Oops sorry let me send another version missing a * 1000 here.
Thanks,
Charles
next prev parent reply other threads:[~2017-01-06 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 14:11 [PATCH 1/4] mfd: arizona: Remove duplicate set of ret variable Charles Keepax
2017-01-06 14:11 ` [PATCH 2/4] mfd: arizona: Display register addresses in hex Charles Keepax
2017-01-06 14:11 ` [PATCH 3/4] mfd: arizona: Update arizona_poll_reg to take a timeout in milliseconds Charles Keepax
2017-01-06 14:19 ` Charles Keepax [this message]
2017-01-06 14:11 ` [PATCH v2 4/4] mfd: arizona: Use regmap_read_poll_timeout instead of hard coding it Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106141947.GB27100@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).