From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 2/5] perf, tools: Add one liner warning for disabled features
Date: Mon, 9 Jan 2017 17:02:22 -0800 [thread overview]
Message-ID: <20170110010225.24870-3-andi@firstfloor.org> (raw)
In-Reply-To: <20170110010225.24870-1-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Add a one liner warning for perf features that need to be enabled
explicitly by the user, so that they know they are missing something.
Currently enabled for XED and BABELTRACE.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/Makefile.config | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 05dfa31506b6..e313739238a8 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -65,6 +65,8 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm))
NO_LIBDW_DWARF_UNWIND := 1
endif
+DISABLED_FEATURES =
+
ifeq ($(LIBUNWIND_LIBS),)
NO_LIBUNWIND := 1
endif
@@ -696,6 +698,8 @@ ifdef XED
EXTLIBS += -lxed
$(call detected,CONFIG_XED)
endif
+else
+ DISABLED_FEATURES += XED
endif
ifndef NO_LZMA
@@ -770,6 +774,8 @@ ifdef LIBBABELTRACE
else
msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
endif
+else
+ DISABLED_FEATURES += LIBBABELTRACE
endif
ifndef NO_AUXTRACE
@@ -841,6 +847,10 @@ ifdef LIBCLANGLLVM
endif
endif
+ifneq ($(DISABLED_FEATURES),)
+ $(warning Disabled features, need explicit enabling by user: $(DISABLED_FEATURES))
+endif
+
# Among the variables below, these:
# perfexecdir
# template_dir
--
2.9.3
next prev parent reply other threads:[~2017-01-10 1:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 1:02 New attempt at adding an disassembler to perf v2 Andi Kleen
2017-01-10 1:02 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
2017-01-10 6:11 ` Willy Tarreau
2017-01-11 18:37 ` Jiri Olsa
2017-01-11 22:35 ` [UPDATED PATCH] " Andi Kleen
2017-01-11 18:28 ` [PATCH 1/5] " Jiri Olsa
2017-01-11 18:37 ` Jiri Olsa
2017-01-11 22:17 ` Andi Kleen
2017-01-12 8:52 ` Jiri Olsa
2017-01-12 17:39 ` Andi Kleen
2017-01-18 11:16 ` Jiri Olsa
2017-01-10 1:02 ` Andi Kleen [this message]
2017-01-11 18:41 ` [PATCH 2/5] perf, tools: Add one liner warning for disabled features Jiri Olsa
2017-01-10 1:02 ` [PATCH 3/5] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-10 1:02 ` [PATCH 4/5] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-10 1:02 ` [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-19 1:41 New attempt at adding an disassembler to perf Andi Kleen
2017-01-19 1:41 ` [PATCH 2/5] perf, tools: Add one liner warning for disabled features Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110010225.24870-3-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).