From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed
Date: Wed, 18 Jan 2017 12:16:54 +0100 [thread overview]
Message-ID: <20170118111654.GA8813@krava> (raw)
In-Reply-To: <20170112173937.GA5460@tassilo.jf.intel.com>
On Thu, Jan 12, 2017 at 09:39:37AM -0800, Andi Kleen wrote:
> On Thu, Jan 12, 2017 at 09:52:53AM +0100, Jiri Olsa wrote:
> > On Wed, Jan 11, 2017 at 02:17:56PM -0800, Andi Kleen wrote:
> > > > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > > > > index e3fb5ecbdcb6..971a9ef87ca6 100644
> > > > > --- a/tools/build/Makefile.feature
> > > > > +++ b/tools/build/Makefile.feature
> > > > > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC := \
> > > > > lzma \
> > > > > get_cpuid \
> > > > > bpf \
> > > > > - sdt
> > > > > + sdt \
> > > >
> > > > looks like you forgot to add xed in here? why the '\' ?
> > >
> > > I removed it, but incompletely.
> > >
> > > > anyway, please add it in here so it's visible under make VF=1
> > >
> > > If I add it here then it is shown by default (even without VF=1).
> > > Arnaldo requested earlier that it shouldn't be shown.
> >
> > if you put it to FEATURE_TESTS_BASIC then it's displayed only for VF=1
>
> It's already in FEATURE_TESTS_BASIC:
>
> @ -63,7 +63,8 @@ FEATURE_TESTS_BASIC := \
> lzma \
> get_cpuid \
> bpf \
> - sdt
> + sdt \
> + xed
I see that on FEATURE_TESTS_EXTRA in your xed-4 branch,
unless that's different to what you sent out
jirka
next prev parent reply other threads:[~2017-01-18 11:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 1:02 New attempt at adding an disassembler to perf v2 Andi Kleen
2017-01-10 1:02 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
2017-01-10 6:11 ` Willy Tarreau
2017-01-11 18:37 ` Jiri Olsa
2017-01-11 22:35 ` [UPDATED PATCH] " Andi Kleen
2017-01-11 18:28 ` [PATCH 1/5] " Jiri Olsa
2017-01-11 18:37 ` Jiri Olsa
2017-01-11 22:17 ` Andi Kleen
2017-01-12 8:52 ` Jiri Olsa
2017-01-12 17:39 ` Andi Kleen
2017-01-18 11:16 ` Jiri Olsa [this message]
2017-01-10 1:02 ` [PATCH 2/5] perf, tools: Add one liner warning for disabled features Andi Kleen
2017-01-11 18:41 ` Jiri Olsa
2017-01-10 1:02 ` [PATCH 3/5] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-10 1:02 ` [PATCH 4/5] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-10 1:02 ` [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-19 1:41 New attempt at adding an disassembler to perf Andi Kleen
2017-01-19 1:41 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118111654.GA8813@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).