From: Willy Tarreau <w@1wt.eu>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed
Date: Tue, 10 Jan 2017 07:11:50 +0100 [thread overview]
Message-ID: <20170110061150.GB4450@1wt.eu> (raw)
In-Reply-To: <20170110010225.24870-2-andi@firstfloor.org>
Hi Andi,
just a very minor cosmetic detail, but your editor seems to use tabs while
there were 8 spaces around, causing visual alignment defects below :
On Mon, Jan 09, 2017 at 05:02:21PM -0800, Andi Kleen wrote:
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index e3fb5ecbdcb6..971a9ef87ca6 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC := \
> lzma \
> get_cpuid \
> bpf \
> - sdt
> + sdt \
here
> # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list
> # of all feature tests
> @@ -74,11 +74,12 @@ FEATURE_TESTS_EXTRA := \
> cplus-demangle \
> hello \
> libbabeltrace \
> + xed \
here
> liberty \
> liberty-z \
> libunwind-debug-frame \
> libunwind-debug-frame-arm \
> - libunwind-debug-frame-aarch64
> + libunwind-debug-frame-aarch64
here
>
> FEATURE_TESTS ?= $(FEATURE_TESTS_BASIC)
>
> @@ -105,7 +106,7 @@ FEATURE_DISPLAY ?= \
> zlib \
> lzma \
> get_cpuid \
> - bpf
> + bpf
and here.
I think it would be nice to fix them before merging.
Did I say it was very minor ? :-)
Regards,
Willy
next prev parent reply other threads:[~2017-01-10 6:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 1:02 New attempt at adding an disassembler to perf v2 Andi Kleen
2017-01-10 1:02 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
2017-01-10 6:11 ` Willy Tarreau [this message]
2017-01-11 18:37 ` Jiri Olsa
2017-01-11 22:35 ` [UPDATED PATCH] " Andi Kleen
2017-01-11 18:28 ` [PATCH 1/5] " Jiri Olsa
2017-01-11 18:37 ` Jiri Olsa
2017-01-11 22:17 ` Andi Kleen
2017-01-12 8:52 ` Jiri Olsa
2017-01-12 17:39 ` Andi Kleen
2017-01-18 11:16 ` Jiri Olsa
2017-01-10 1:02 ` [PATCH 2/5] perf, tools: Add one liner warning for disabled features Andi Kleen
2017-01-11 18:41 ` Jiri Olsa
2017-01-10 1:02 ` [PATCH 3/5] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-10 1:02 ` [PATCH 4/5] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-10 1:02 ` [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-19 1:41 New attempt at adding an disassembler to perf Andi Kleen
2017-01-19 1:41 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110061150.GB4450@1wt.eu \
--to=w@1wt.eu \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).