* [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int
@ 2017-01-10 16:21 Roman Sommer
2017-01-10 16:40 ` Johan Hovold
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Roman Sommer @ 2017-01-10 16:21 UTC (permalink / raw)
Cc: linux-kernel, Rui Miguel Silva, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Christian Bewermeyer, Roman Sommer
From: Christian Bewermeyer <christian.bewermeyer@fau.de>
Note that this patch does not fix all checkpatch warnings for
gpio.c
Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
Signed-off-by: Roman Sommer <roman.sommer@fau.de>
---
drivers/staging/greybus/gpio.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 250caa0..0c95bce 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -410,21 +410,21 @@ static int gb_gpio_request_handler(struct gb_operation *op)
return 0;
}
-static int gb_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_request(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_activate_operation(ggc, (u8)offset);
}
-static void gb_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void gb_gpio_free(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_deactivate_operation(ggc, (u8)offset);
}
-static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -438,22 +438,22 @@ static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].direction ? 1 : 0;
}
-static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_in_operation(ggc, (u8)offset);
}
-static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
- int value)
+static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned int offset,
+ int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_out_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -467,15 +467,15 @@ static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].value;
}
-static void gb_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static void gb_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_set_value_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned offset,
- unsigned debounce)
+static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned int offset,
+ unsigned int debounce)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u16 usec;
@@ -593,7 +593,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
{
struct gb_gpio_controller *ggc;
unsigned int offset;
- unsigned irq_base;
+ unsigned int irq_base;
if (!chip || !irqchip)
return -EINVAL;
@@ -625,7 +625,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
return 0;
}
-static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-10 16:21 [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int Roman Sommer
@ 2017-01-10 16:40 ` Johan Hovold
2017-01-10 17:01 ` roman.sommer
2017-01-11 13:48 ` [PATCH v2] " Roman Sommer
2017-01-13 20:54 ` [PATCH] staging: greybus: fix checkpatch unsigned warnings Roman Sommer
2 siblings, 1 reply; 14+ messages in thread
From: Johan Hovold @ 2017-01-10 16:40 UTC (permalink / raw)
To: Roman Sommer
Cc: linux-kernel, Rui Miguel Silva, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Christian Bewermeyer
On Tue, Jan 10, 2017 at 05:21:24PM +0100, Roman Sommer wrote:
> From: Christian Bewermeyer <christian.bewermeyer@fau.de>
>
> Note that this patch does not fix all checkpatch warnings for
> gpio.c
Fair enough, but you are fixing all of these new "unsigned int"
warnings in that driver, right?
How about fixing the sole remaining instance in the loopback driver so
that this is done for the whole subsystem once and for all?
Also your Subject should be
staging: greybus: gpio: fix checkpatch unsigned warnings
unless doing this subsystem-wide, in which case you can drop the
"gpio" module prefix.
Thanks,
Johan
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-10 16:40 ` Johan Hovold
@ 2017-01-10 17:01 ` roman.sommer
0 siblings, 0 replies; 14+ messages in thread
From: roman.sommer @ 2017-01-10 17:01 UTC (permalink / raw)
To: Johan Hovold
Cc: Roman Sommer, linux-kernel, Rui Miguel Silva, Johan Hovold,
Alex Elder, Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Christian Bewermeyer
> Fair enough, but you are fixing all of these new "unsigned int"
> warnings in that driver, right?
>
> How about fixing the sole remaining instance in the loopback driver so
> that this is done for the whole subsystem once and for all?
Thanks for the hint, I will do that.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-10 16:21 [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int Roman Sommer
2017-01-10 16:40 ` Johan Hovold
@ 2017-01-11 13:48 ` Roman Sommer
2017-01-11 13:52 ` Johan Hovold
2017-01-13 20:54 ` [PATCH] staging: greybus: fix checkpatch unsigned warnings Roman Sommer
2 siblings, 1 reply; 14+ messages in thread
From: Roman Sommer @ 2017-01-11 13:48 UTC (permalink / raw)
Cc: linux-kernel, Rui Miguel Silva, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Roman Sommer, Christian Bewermeyer
Note that this patch does not fix all checkpatch warnings for the
affected files.
Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
Signed-off-by: Roman Sommer <roman.sommer@fau.de>
---
drivers/staging/greybus/gpio.c | 24 ++++++++++++------------
drivers/staging/greybus/loopback.c | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 250caa0..558550c 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -410,21 +410,21 @@ static int gb_gpio_request_handler(struct gb_operation *op)
return 0;
}
-static int gb_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_request(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_activate_operation(ggc, (u8)offset);
}
-static void gb_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void gb_gpio_free(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_deactivate_operation(ggc, (u8)offset);
}
-static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -438,22 +438,22 @@ static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].direction ? 1 : 0;
}
-static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_in_operation(ggc, (u8)offset);
}
-static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
- int value)
+static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned int offset,
+ int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_out_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -467,15 +467,15 @@ static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].value;
}
-static void gb_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static void gb_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_set_value_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned offset,
- unsigned debounce)
+static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned int offset,
+ unsigned int debounce)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u16 usec;
@@ -593,7 +593,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
{
struct gb_gpio_controller *ggc;
unsigned int offset;
- unsigned irq_base;
+ unsigned int irq_base;
if (!chip || !irqchip)
return -EINVAL;
@@ -625,7 +625,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
return 0;
}
-static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7882306..3ad8c64 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -124,7 +124,7 @@ static DEFINE_IDA(loopback_ida);
#define GB_LOOPBACK_FIFO_DEFAULT 8192
-static unsigned kfifo_depth = GB_LOOPBACK_FIFO_DEFAULT;
+static unsigned int kfifo_depth = GB_LOOPBACK_FIFO_DEFAULT;
module_param(kfifo_depth, uint, 0444);
/* Maximum size of any one send data buffer we support */
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-11 13:48 ` [PATCH v2] " Roman Sommer
@ 2017-01-11 13:52 ` Johan Hovold
2017-01-11 14:44 ` roman.sommer
2017-01-11 15:00 ` [PATCH v3] staging: " Roman Sommer
0 siblings, 2 replies; 14+ messages in thread
From: Johan Hovold @ 2017-01-11 13:52 UTC (permalink / raw)
To: Roman Sommer
Cc: linux-kernel, Rui Miguel Silva, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Christian Bewermeyer
On Wed, Jan 11, 2017 at 02:48:38PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
> Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
> Signed-off-by: Roman Sommer <roman.sommer@fau.de>
You forgot to fix the Subject prefix ("staging: greybus: <summary>").
Care to fix that up and resend?
Thanks,
Johan
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-11 13:52 ` Johan Hovold
@ 2017-01-11 14:44 ` roman.sommer
2017-01-11 14:47 ` roman.sommer
2017-01-11 15:00 ` [PATCH v3] staging: " Roman Sommer
1 sibling, 1 reply; 14+ messages in thread
From: roman.sommer @ 2017-01-11 14:44 UTC (permalink / raw)
To: Johan Hovold
Cc: Roman Sommer, linux-kernel, Rui Miguel Silva, Johan Hovold,
Alex Elder, Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Christian Bewermeyer
> You forgot to fix the Subject prefix ("staging: greybus: <summary>").
>
> Care to fix that up and resend?
>
> Thanks,
> Johan
>
As I added the fix for loopback.c, I did not include the "gpio" prefix.
This is what I thought was correct after reading your last mail.
Apparently I misunderstood.
What should the prefix be in this case?
Thanks,
Roman
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-11 14:44 ` roman.sommer
@ 2017-01-11 14:47 ` roman.sommer
0 siblings, 0 replies; 14+ messages in thread
From: roman.sommer @ 2017-01-11 14:47 UTC (permalink / raw)
To: roman.sommer
Cc: Johan Hovold, Roman Sommer, linux-kernel, Rui Miguel Silva,
Alex Elder, Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Christian Bewermeyer
>> You forgot to fix the Subject prefix ("staging: greybus: <summary>").
>>
>> Care to fix that up and resend?
>>
>> Thanks,
>> Johan
>>
>
> As I added the fix for loopback.c, I did not include the "gpio" prefix.
> This is what I thought was correct after reading your last mail.
> Apparently I misunderstood.
>
> What should the prefix be in this case?
>
Oh, I see, I forgot the "staging".
I will fix that.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-11 13:52 ` Johan Hovold
2017-01-11 14:44 ` roman.sommer
@ 2017-01-11 15:00 ` Roman Sommer
2017-01-11 15:08 ` Johan Hovold
` (2 more replies)
1 sibling, 3 replies; 14+ messages in thread
From: Roman Sommer @ 2017-01-11 15:00 UTC (permalink / raw)
Cc: linux-kernel, Rui Miguel Silva, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Roman Sommer, Christian Bewermeyer
Note that this patch does not fix all checkpatch warnings for the
affected files.
Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
Signed-off-by: Roman Sommer <roman.sommer@fau.de>
---
drivers/staging/greybus/gpio.c | 24 ++++++++++++------------
drivers/staging/greybus/loopback.c | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 250caa0..558550c 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -410,21 +410,21 @@ static int gb_gpio_request_handler(struct gb_operation *op)
return 0;
}
-static int gb_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_request(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_activate_operation(ggc, (u8)offset);
}
-static void gb_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void gb_gpio_free(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_deactivate_operation(ggc, (u8)offset);
}
-static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -438,22 +438,22 @@ static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].direction ? 1 : 0;
}
-static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_in_operation(ggc, (u8)offset);
}
-static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
- int value)
+static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned int offset,
+ int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_out_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -467,15 +467,15 @@ static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].value;
}
-static void gb_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static void gb_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_set_value_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned offset,
- unsigned debounce)
+static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned int offset,
+ unsigned int debounce)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u16 usec;
@@ -593,7 +593,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
{
struct gb_gpio_controller *ggc;
unsigned int offset;
- unsigned irq_base;
+ unsigned int irq_base;
if (!chip || !irqchip)
return -EINVAL;
@@ -625,7 +625,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
return 0;
}
-static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7882306..3ad8c64 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -124,7 +124,7 @@ static DEFINE_IDA(loopback_ida);
#define GB_LOOPBACK_FIFO_DEFAULT 8192
-static unsigned kfifo_depth = GB_LOOPBACK_FIFO_DEFAULT;
+static unsigned int kfifo_depth = GB_LOOPBACK_FIFO_DEFAULT;
module_param(kfifo_depth, uint, 0444);
/* Maximum size of any one send data buffer we support */
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-11 15:00 ` [PATCH v3] staging: " Roman Sommer
@ 2017-01-11 15:08 ` Johan Hovold
2017-01-12 4:50 ` [greybus-dev] " Viresh Kumar
2017-01-12 7:05 ` Dan Carpenter
2 siblings, 0 replies; 14+ messages in thread
From: Johan Hovold @ 2017-01-11 15:08 UTC (permalink / raw)
To: Roman Sommer
Cc: devel, greybus-dev, Greg Kroah-Hartman, linux-kernel,
Johan Hovold, linux-kernel, Christian Bewermeyer
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
> Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
> Signed-off-by: Roman Sommer <roman.sommer@fau.de>
Next time I suggest you drop "checkpatch: " from your subject since
that's not a (greybus) component. You could have rephrased the summary
as "fix checkpatch unsigned warnings" or similar instead.
Reviewed-by: Johan Hovold <johan@kernel.org>
Thanks,
Johan
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [greybus-dev] [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-11 15:00 ` [PATCH v3] staging: " Roman Sommer
2017-01-11 15:08 ` Johan Hovold
@ 2017-01-12 4:50 ` Viresh Kumar
2017-01-12 7:05 ` Dan Carpenter
2 siblings, 0 replies; 14+ messages in thread
From: Viresh Kumar @ 2017-01-12 4:50 UTC (permalink / raw)
To: Roman Sommer
Cc: devel, Alex Elder, greybus-dev, linux-kernel, Johan Hovold,
linux-kernel, Christian Bewermeyer
On 11-01-17, 16:00, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
> Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
> Signed-off-by: Roman Sommer <roman.sommer@fau.de>
>
> ---
> drivers/staging/greybus/gpio.c | 24 ++++++++++++------------
> drivers/staging/greybus/loopback.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
I think checkpatch should rather not warn about it. Using 'unsigned' instead of
'unsigned int' isn't that bad :)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-11 15:00 ` [PATCH v3] staging: " Roman Sommer
2017-01-11 15:08 ` Johan Hovold
2017-01-12 4:50 ` [greybus-dev] " Viresh Kumar
@ 2017-01-12 7:05 ` Dan Carpenter
2017-01-12 8:47 ` Johan Hovold
2 siblings, 1 reply; 14+ messages in thread
From: Dan Carpenter @ 2017-01-12 7:05 UTC (permalink / raw)
To: Roman Sommer
Cc: devel, greybus-dev, Greg Kroah-Hartman, linux-kernel,
Johan Hovold, linux-kernel, Christian Bewermeyer
On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
>
A lot of ways that display git commits put the changelog and the summary
far apart. The changelog is pretty useless by itself in this case.
https://lkml.org/lkml/2017/1/11/308
See how it puts the date in between? marc.info is even worse but google
hasn't indexed it yet and I'm too lazy to look it up. So people read
the summary or the changelog but not necessarily both.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3] staging: greybus: checkpatch: Change parameter type unsigned to unsigned int
2017-01-12 7:05 ` Dan Carpenter
@ 2017-01-12 8:47 ` Johan Hovold
0 siblings, 0 replies; 14+ messages in thread
From: Johan Hovold @ 2017-01-12 8:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Roman Sommer, devel, linux-kernel, Greg Kroah-Hartman,
Johan Hovold, linux-kernel, greybus-dev, Christian Bewermeyer
On Thu, Jan 12, 2017 at 10:05:10AM +0300, Dan Carpenter wrote:
> On Wed, Jan 11, 2017 at 04:00:35PM +0100, Roman Sommer wrote:
> > Note that this patch does not fix all checkpatch warnings for the
> > affected files.
> >
>
> A lot of ways that display git commits put the changelog and the summary
> far apart. The changelog is pretty useless by itself in this case.
>
> https://lkml.org/lkml/2017/1/11/308
>
> See how it puts the date in between? marc.info is even worse but google
> hasn't indexed it yet and I'm too lazy to look it up. So people read
> the summary or the changelog but not necessarily both.
Yeah, let's do this right.
Roman, could you resend this with a self-contained commit message, and a
more compact summary (Subject) as I suggested earlier?
Thanks,
Johan
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] staging: greybus: fix checkpatch unsigned warnings
2017-01-10 16:21 [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int Roman Sommer
2017-01-10 16:40 ` Johan Hovold
2017-01-11 13:48 ` [PATCH v2] " Roman Sommer
@ 2017-01-13 20:54 ` Roman Sommer
2017-01-16 9:50 ` Johan Hovold
2 siblings, 1 reply; 14+ messages in thread
From: Roman Sommer @ 2017-01-13 20:54 UTC (permalink / raw)
Cc: linux-kernel, Rui Miguel Silva, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Roman Sommer, Christian Bewermeyer
Fix checkpatch warnings for parameter type unsigned in greybus.
Note that this patch does not fix all checkpatch warnings for the
affected files.
Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
Signed-off-by: Roman Sommer <roman.sommer@fau.de>
---
drivers/staging/greybus/gpio.c | 24 ++++++++++++------------
drivers/staging/greybus/loopback.c | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 250caa0..558550c 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -410,21 +410,21 @@ static int gb_gpio_request_handler(struct gb_operation *op)
return 0;
}
-static int gb_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_request(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_activate_operation(ggc, (u8)offset);
}
-static void gb_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void gb_gpio_free(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_deactivate_operation(ggc, (u8)offset);
}
-static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -438,22 +438,22 @@ static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].direction ? 1 : 0;
}
-static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_in_operation(ggc, (u8)offset);
}
-static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
- int value)
+static int gb_gpio_direction_output(struct gpio_chip *chip, unsigned int offset,
+ int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
return gb_gpio_direction_out_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_get(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u8 which;
@@ -467,15 +467,15 @@ static int gb_gpio_get(struct gpio_chip *chip, unsigned offset)
return ggc->lines[which].value;
}
-static void gb_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static void gb_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
gb_gpio_set_value_operation(ggc, (u8)offset, !!value);
}
-static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned offset,
- unsigned debounce)
+static int gb_gpio_set_debounce(struct gpio_chip *chip, unsigned int offset,
+ unsigned int debounce)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
u16 usec;
@@ -593,7 +593,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
{
struct gb_gpio_controller *ggc;
unsigned int offset;
- unsigned irq_base;
+ unsigned int irq_base;
if (!chip || !irqchip)
return -EINVAL;
@@ -625,7 +625,7 @@ static int gb_gpio_irqchip_add(struct gpio_chip *chip,
return 0;
}
-static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
+static int gb_gpio_to_irq(struct gpio_chip *chip, unsigned int offset)
{
struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7882306..3ad8c64 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -124,7 +124,7 @@ static DEFINE_IDA(loopback_ida);
#define GB_LOOPBACK_FIFO_DEFAULT 8192
-static unsigned kfifo_depth = GB_LOOPBACK_FIFO_DEFAULT;
+static unsigned int kfifo_depth = GB_LOOPBACK_FIFO_DEFAULT;
module_param(kfifo_depth, uint, 0444);
/* Maximum size of any one send data buffer we support */
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] staging: greybus: fix checkpatch unsigned warnings
2017-01-13 20:54 ` [PATCH] staging: greybus: fix checkpatch unsigned warnings Roman Sommer
@ 2017-01-16 9:50 ` Johan Hovold
0 siblings, 0 replies; 14+ messages in thread
From: Johan Hovold @ 2017-01-16 9:50 UTC (permalink / raw)
To: Roman Sommer
Cc: linux-kernel, Rui Miguel Silva, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, devel, linux-kernel,
Christian Bewermeyer
On Fri, Jan 13, 2017 at 09:54:51PM +0100, Roman Sommer wrote:
> Fix checkpatch warnings for parameter type unsigned in greybus.
> Note that this patch does not fix all checkpatch warnings for the
> affected files.
Thanks for the update. In the future, make sure to include a patch
revision in the Subject (e.g. "[PATCH v3] staging: ...") and a changelog
below the cut-off line ("---").
Funny that checkpatch warns about mentioning checkpatch in the Subject
line. Good thing ignoring checkpatch selectively is perfectly fine.
> Signed-off-by: Christian Bewermeyer <christian.bewermeyer@fau.de>
> Signed-off-by: Roman Sommer <roman.sommer@fau.de>
Reviewed-by: Johan Hovold <johan@kernel.org>
Thanks,
Johan
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-01-16 9:50 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-10 16:21 [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int Roman Sommer
2017-01-10 16:40 ` Johan Hovold
2017-01-10 17:01 ` roman.sommer
2017-01-11 13:48 ` [PATCH v2] " Roman Sommer
2017-01-11 13:52 ` Johan Hovold
2017-01-11 14:44 ` roman.sommer
2017-01-11 14:47 ` roman.sommer
2017-01-11 15:00 ` [PATCH v3] staging: " Roman Sommer
2017-01-11 15:08 ` Johan Hovold
2017-01-12 4:50 ` [greybus-dev] " Viresh Kumar
2017-01-12 7:05 ` Dan Carpenter
2017-01-12 8:47 ` Johan Hovold
2017-01-13 20:54 ` [PATCH] staging: greybus: fix checkpatch unsigned warnings Roman Sommer
2017-01-16 9:50 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).