* [PATCH] leds: ktd2692: avoid harmless maybe-uninitialized warning
@ 2017-01-25 22:22 Arnd Bergmann
2017-01-25 22:36 ` Pavel Machek
2017-01-26 20:20 ` Jacek Anaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-01-25 22:22 UTC (permalink / raw)
To: Richard Purdie, Jacek Anaszewski, Pavel Machek
Cc: Arnd Bergmann, linux-leds, linux-kernel
gcc gets confused about the control flow in ktd2692_parse_dt(), causing
it to warn about what seems like a potential bug:
drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
The code is fine, and slightly reworking it in an equivalent way lets
gcc figure that out too, which gets rid of the warning.
Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/leds/leds-ktd2692.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
index bf23ba191ad0..45296aaca9da 100644
--- a/drivers/leds/leds-ktd2692.c
+++ b/drivers/leds/leds-ktd2692.c
@@ -270,15 +270,15 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,
return -ENXIO;
led->ctrl_gpio = devm_gpiod_get(dev, "ctrl", GPIOD_ASIS);
- if (IS_ERR(led->ctrl_gpio)) {
- ret = PTR_ERR(led->ctrl_gpio);
+ ret = PTR_ERR_OR_ZERO(led->ctrl_gpio);
+ if (ret) {
dev_err(dev, "cannot get ctrl-gpios %d\n", ret);
return ret;
}
led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS);
- if (IS_ERR(led->aux_gpio)) {
- ret = PTR_ERR(led->aux_gpio);
+ ret = PTR_ERR_OR_ZERO(led->aux_gpio);
+ if (ret) {
dev_err(dev, "cannot get aux-gpios %d\n", ret);
return ret;
}
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: ktd2692: avoid harmless maybe-uninitialized warning
2017-01-25 22:22 [PATCH] leds: ktd2692: avoid harmless maybe-uninitialized warning Arnd Bergmann
@ 2017-01-25 22:36 ` Pavel Machek
2017-01-26 20:20 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2017-01-25 22:36 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Richard Purdie, Jacek Anaszewski, linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Wed 2017-01-25 23:22:36, Arnd Bergmann wrote:
> gcc gets confused about the control flow in ktd2692_parse_dt(), causing
> it to warn about what seems like a potential bug:
>
> drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
> drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The code is fine, and slightly reworking it in an equivalent way lets
> gcc figure that out too, which gets rid of the warning.
>
> Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: ktd2692: avoid harmless maybe-uninitialized warning
2017-01-25 22:22 [PATCH] leds: ktd2692: avoid harmless maybe-uninitialized warning Arnd Bergmann
2017-01-25 22:36 ` Pavel Machek
@ 2017-01-26 20:20 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2017-01-26 20:20 UTC (permalink / raw)
To: Arnd Bergmann, Richard Purdie, Pavel Machek; +Cc: linux-leds, linux-kernel
Hi Arnd,
Thanks for the patch, applied.
Best regards,
Jacek Anaszewski
On 01/25/2017 11:22 PM, Arnd Bergmann wrote:
> gcc gets confused about the control flow in ktd2692_parse_dt(), causing
> it to warn about what seems like a potential bug:
>
> drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
> drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The code is fine, and slightly reworking it in an equivalent way lets
> gcc figure that out too, which gets rid of the warning.
>
> Fixes: 77e7915b15bb ("leds: ktd2692: Add missing of_node_put")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/leds/leds-ktd2692.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
> index bf23ba191ad0..45296aaca9da 100644
> --- a/drivers/leds/leds-ktd2692.c
> +++ b/drivers/leds/leds-ktd2692.c
> @@ -270,15 +270,15 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,
> return -ENXIO;
>
> led->ctrl_gpio = devm_gpiod_get(dev, "ctrl", GPIOD_ASIS);
> - if (IS_ERR(led->ctrl_gpio)) {
> - ret = PTR_ERR(led->ctrl_gpio);
> + ret = PTR_ERR_OR_ZERO(led->ctrl_gpio);
> + if (ret) {
> dev_err(dev, "cannot get ctrl-gpios %d\n", ret);
> return ret;
> }
>
> led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS);
> - if (IS_ERR(led->aux_gpio)) {
> - ret = PTR_ERR(led->aux_gpio);
> + ret = PTR_ERR_OR_ZERO(led->aux_gpio);
> + if (ret) {
> dev_err(dev, "cannot get aux-gpios %d\n", ret);
> return ret;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-26 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-25 22:22 [PATCH] leds: ktd2692: avoid harmless maybe-uninitialized warning Arnd Bergmann
2017-01-25 22:36 ` Pavel Machek
2017-01-26 20:20 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).