* [PATCH] drivers: usb: usbip: Add missing break statement to switch
@ 2017-02-09 7:49 Gustavo A. R. Silva
2017-02-09 19:44 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-02-09 7:49 UTC (permalink / raw)
To: valentina.manea.m, shuah, gregkh
Cc: linux-usb, linux-kernel, Peter Senna Tschudin
Add missing break statement to prevent the code for case
USB_PORT_FEAT_C_RESET falling through to the default case.
Addresses-Coverity-ID: 143155
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/usb/usbip/vhci_hcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index c4724fb..e4cb9f0 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -313,6 +313,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
default:
break;
}
+ break;
default:
usbip_dbg_vhci_rh(" ClearPortFeature: default %x\n",
wValue);
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: usb: usbip: Add missing break statement to switch
2017-02-09 7:49 [PATCH] drivers: usb: usbip: Add missing break statement to switch Gustavo A. R. Silva
@ 2017-02-09 19:44 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2017-02-09 19:44 UTC (permalink / raw)
To: Gustavo A. R. Silva, valentina.manea.m, gregkh
Cc: linux-usb, linux-kernel, peter.senna, Shuah Khan, Shuah Khan
On 02/09/2017 12:49 AM, Gustavo A. R. Silva wrote:
> Add missing break statement to prevent the code for case
> USB_PORT_FEAT_C_RESET falling through to the default case.
>
> Addresses-Coverity-ID: 143155
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/usb/usbip/vhci_hcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index c4724fb..e4cb9f0 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -313,6 +313,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> default:
> break;
> }
> + break;
> default:
> usbip_dbg_vhci_rh(" ClearPortFeature: default %x\n",
> wValue);
>
Looks good to me.
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-09 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 7:49 [PATCH] drivers: usb: usbip: Add missing break statement to switch Gustavo A. R. Silva
2017-02-09 19:44 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).