* [PATCH V2] mtd: spi-nor: intel: use true/false for boolean
@ 2017-02-13 8:13 Nicholas Mc Guire
2017-02-14 4:52 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Nicholas Mc Guire @ 2017-02-13 8:13 UTC (permalink / raw)
To: Cyrille Pitchen
Cc: Marek Vasut, David Woodhouse, Brian Norris, Boris Brezillon,
Richard Weinberger, Mika Westerberg, linux-mtd, linux-kernel,
Nicholas Mc Guire
writeable in struct intel_spi is a boolean and assignment should be to
true/false not 1/0 as recommended by boolinit.cocci.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
make coccicheck complained with:
./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
Patch is against 4.10-rc7 (localversion-next is next-20170213)
drivers/mtd/spi-nor/intel-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
index 4630716..2956f2c 100644
--- a/drivers/mtd/spi-nor/intel-spi.c
+++ b/drivers/mtd/spi-nor/intel-spi.c
@@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
* whole partition read-only to be on the safe side.
*/
if (intel_spi_is_protected(ispi, base, limit))
- ispi->writeable = 0;
+ ispi->writeable = false;
end = (limit << 12) + 4096;
if (end > part->size)
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean
2017-02-13 8:13 [PATCH V2] mtd: spi-nor: intel: use true/false for boolean Nicholas Mc Guire
@ 2017-02-14 4:52 ` Marek Vasut
2017-02-14 9:57 ` Mika Westerberg
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2017-02-14 4:52 UTC (permalink / raw)
To: Nicholas Mc Guire, Cyrille Pitchen
Cc: David Woodhouse, Brian Norris, Boris Brezillon,
Richard Weinberger, Mika Westerberg, linux-mtd, linux-kernel
On 02/13/2017 09:13 AM, Nicholas Mc Guire wrote:
> writeable in struct intel_spi is a boolean and assignment should be to
> true/false not 1/0 as recommended by boolinit.cocci.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> make coccicheck complained with:
> ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
>
> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
>
> Patch is against 4.10-rc7 (localversion-next is next-20170213)
>
> drivers/mtd/spi-nor/intel-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index 4630716..2956f2c 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
> * whole partition read-only to be on the safe side.
> */
> if (intel_spi_is_protected(ispi, base, limit))
> - ispi->writeable = 0;
> + ispi->writeable = false;
>
> end = (limit << 12) + 4096;
> if (end > part->size)
>
Looks OK, also this is the only place in the driver where writeable is
assigned to an explicit true/false value.
Acked-by: Marek Vasut <marek.vasut@gmail.com>
btw the variable should be renamed from writeable to writable ;-)
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean
2017-02-14 4:52 ` Marek Vasut
@ 2017-02-14 9:57 ` Mika Westerberg
2017-02-15 21:08 ` Marek Vasut
2017-03-07 21:06 ` Cyrille Pitchen
0 siblings, 2 replies; 5+ messages in thread
From: Mika Westerberg @ 2017-02-14 9:57 UTC (permalink / raw)
To: Marek Vasut
Cc: Nicholas Mc Guire, Cyrille Pitchen, David Woodhouse,
Brian Norris, Boris Brezillon, Richard Weinberger, linux-mtd,
linux-kernel
On Tue, Feb 14, 2017 at 05:52:48AM +0100, Marek Vasut wrote:
> On 02/13/2017 09:13 AM, Nicholas Mc Guire wrote:
> > writeable in struct intel_spi is a boolean and assignment should be to
> > true/false not 1/0 as recommended by boolinit.cocci.
> >
> > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> > ---
> >
> > make coccicheck complained with:
> > ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
> >
> > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> >
> > Patch is against 4.10-rc7 (localversion-next is next-20170213)
> >
> > drivers/mtd/spi-nor/intel-spi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> > index 4630716..2956f2c 100644
> > --- a/drivers/mtd/spi-nor/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
> > * whole partition read-only to be on the safe side.
> > */
> > if (intel_spi_is_protected(ispi, base, limit))
> > - ispi->writeable = 0;
> > + ispi->writeable = false;
> >
> > end = (limit << 12) + 4096;
> > if (end > part->size)
> >
>
> Looks OK, also this is the only place in the driver where writeable is
> assigned to an explicit true/false value.
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
Also
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> btw the variable should be renamed from writeable to writable ;-)
It is named like that because it follows MTD_WRITEABLE flag.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean
2017-02-14 9:57 ` Mika Westerberg
@ 2017-02-15 21:08 ` Marek Vasut
2017-03-07 21:06 ` Cyrille Pitchen
1 sibling, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2017-02-15 21:08 UTC (permalink / raw)
To: Mika Westerberg
Cc: Nicholas Mc Guire, Cyrille Pitchen, David Woodhouse,
Brian Norris, Boris Brezillon, Richard Weinberger, linux-mtd,
linux-kernel
On 02/14/2017 10:57 AM, Mika Westerberg wrote:
> On Tue, Feb 14, 2017 at 05:52:48AM +0100, Marek Vasut wrote:
>> On 02/13/2017 09:13 AM, Nicholas Mc Guire wrote:
>>> writeable in struct intel_spi is a boolean and assignment should be to
>>> true/false not 1/0 as recommended by boolinit.cocci.
>>>
>>> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
>>> ---
>>>
>>> make coccicheck complained with:
>>> ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
>>>
>>> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
>>>
>>> Patch is against 4.10-rc7 (localversion-next is next-20170213)
>>>
>>> drivers/mtd/spi-nor/intel-spi.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
>>> index 4630716..2956f2c 100644
>>> --- a/drivers/mtd/spi-nor/intel-spi.c
>>> +++ b/drivers/mtd/spi-nor/intel-spi.c
>>> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
>>> * whole partition read-only to be on the safe side.
>>> */
>>> if (intel_spi_is_protected(ispi, base, limit))
>>> - ispi->writeable = 0;
>>> + ispi->writeable = false;
>>>
>>> end = (limit << 12) + 4096;
>>> if (end > part->size)
>>>
>>
>> Looks OK, also this is the only place in the driver where writeable is
>> assigned to an explicit true/false value.
>>
>> Acked-by: Marek Vasut <marek.vasut@gmail.com>
>
> Also
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
>> btw the variable should be renamed from writeable to writable ;-)
>
> It is named like that because it follows MTD_WRITEABLE flag.
>
Now there are two things which might need fixing ^_^'
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean
2017-02-14 9:57 ` Mika Westerberg
2017-02-15 21:08 ` Marek Vasut
@ 2017-03-07 21:06 ` Cyrille Pitchen
1 sibling, 0 replies; 5+ messages in thread
From: Cyrille Pitchen @ 2017-03-07 21:06 UTC (permalink / raw)
To: Mika Westerberg, Marek Vasut
Cc: Boris Brezillon, Richard Weinberger, linux-kernel,
Nicholas Mc Guire, linux-mtd, Cyrille Pitchen, Brian Norris,
David Woodhouse
Le 14/02/2017 à 10:57, Mika Westerberg a écrit :
> On Tue, Feb 14, 2017 at 05:52:48AM +0100, Marek Vasut wrote:
>> On 02/13/2017 09:13 AM, Nicholas Mc Guire wrote:
>>> writeable in struct intel_spi is a boolean and assignment should be to
>>> true/false not 1/0 as recommended by boolinit.cocci.
>>>
>>> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
>>> ---
>>>
>>> make coccicheck complained with:
>>> ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
>>>
>>> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
>>>
>>> Patch is against 4.10-rc7 (localversion-next is next-20170213)
>>>
>>> drivers/mtd/spi-nor/intel-spi.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
>>> index 4630716..2956f2c 100644
>>> --- a/drivers/mtd/spi-nor/intel-spi.c
>>> +++ b/drivers/mtd/spi-nor/intel-spi.c
>>> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
>>> * whole partition read-only to be on the safe side.
>>> */
>>> if (intel_spi_is_protected(ispi, base, limit))
>>> - ispi->writeable = 0;
>>> + ispi->writeable = false;
>>>
>>> end = (limit << 12) + 4096;
>>> if (end > part->size)
>>>
>>
>> Looks OK, also this is the only place in the driver where writeable is
>> assigned to an explicit true/false value.
>>
>> Acked-by: Marek Vasut <marek.vasut@gmail.com>
>
> Also
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to spi-nor/next
Thanks!
>
>> btw the variable should be renamed from writeable to writable ;-)
>
> It is named like that because it follows MTD_WRITEABLE flag.
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-07 21:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-13 8:13 [PATCH V2] mtd: spi-nor: intel: use true/false for boolean Nicholas Mc Guire
2017-02-14 4:52 ` Marek Vasut
2017-02-14 9:57 ` Mika Westerberg
2017-02-15 21:08 ` Marek Vasut
2017-03-07 21:06 ` Cyrille Pitchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).