From: changbin.du@intel.com
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org
Cc: linux-kernel@vger.kernel.org, Changbin Du <changbin.du@intel.com>
Subject: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given
Date: Mon, 13 Mar 2017 16:36:01 +0800 [thread overview]
Message-ID: <20170313083601.24465-1-changbin.du@intel.com> (raw)
From: Changbin Du <changbin.du@intel.com>
If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first. This patch forbid adding any overhead* field if there is one
already given.
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
tools/perf/util/sort.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index b6db140..7695b54 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2543,6 +2543,13 @@ static char *setup_overhead(char *keys)
if (sort__mode == SORT_MODE__DIFF)
return keys;
+ /*
+ * Only insert overhead && overhead_children when
+ * no overhead* field given.
+ */
+ if (strstr(keys, "overhead"))
+ return keys;
+
keys = prefix_if_not_in("overhead", keys);
if (symbol_conf.cumulate_callchain)
--
2.7.4
next reply other threads:[~2017-03-13 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 8:36 changbin.du [this message]
2017-03-15 2:06 ` [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given Du, Changbin
2017-06-01 9:03 changbin.du
2017-06-01 10:21 ` Jiri Olsa
2017-06-02 2:52 ` Du, Changbin
2017-06-02 3:22 ` Du, Changbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313083601.24465-1-changbin.du@intel.com \
--to=changbin.du@intel.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).