linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: changbin.du@intel.com
To: peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org
Cc: linux-kernel@vger.kernel.org, Changbin Du <changbin.du@intel.com>
Subject: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given
Date: Thu,  1 Jun 2017 17:03:21 +0800	[thread overview]
Message-ID: <1496307801-24134-1-git-send-email-changbin.du@intel.com> (raw)

From: Changbin Du <changbin.du@intel.com>

If we always insert 'overhead' and 'overhead_children' as sort keys,
this make it impossible to sort as overhead (which displayed as Self)
first.Ths will be a problem if the data is collected with call-graph
enabled. Then we never can sort the result as self-overhead on this
data. And sometimes the data is hard to collect.

This patch fix this by only insert overhead && overhead_children
when no overhead* field given.

Signed-off-by: Changbin Du <changbin.du@intel.com>
---
 tools/perf/util/sort.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 5762ae4..69eea3a 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
 	if (sort__mode == SORT_MODE__DIFF)
 		return keys;
 
+	if (strstr(keys, "overhead"))
+		return keys;
+
 	keys = prefix_if_not_in("overhead", keys);
 
 	if (symbol_conf.cumulate_callchain)
-- 
2.7.4

             reply	other threads:[~2017-06-01  9:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01  9:03 changbin.du [this message]
2017-06-01 10:21 ` [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given Jiri Olsa
2017-06-02  2:52   ` Du, Changbin
2017-06-02  3:22     ` Du, Changbin
2017-06-02  4:22 ` [PATCH v2] " changbin.du
2017-06-26  8:06   ` Du, Changbin
2017-06-29 15:22     ` Jiri Olsa
2017-07-05  3:02       ` Du, Changbin
2017-07-05  3:35 ` [PATCH v3] " changbin.du
2017-07-06 16:04   ` Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2017-03-13  8:36 [PATCH] " changbin.du
2017-03-15  2:06 ` Du, Changbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496307801-24134-1-git-send-email-changbin.du@intel.com \
    --to=changbin.du@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).