From: "Du, Changbin" <changbin.du@intel.com>
To: "Du, Changbin" <changbin.du@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given
Date: Fri, 2 Jun 2017 11:22:57 +0800 [thread overview]
Message-ID: <20170602032257.GA13003@intel.com> (raw)
In-Reply-To: <20170602025223.GA9307@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
On Fri, Jun 02, 2017 at 10:52:24AM +0800, Du, Changbin wrote:
> On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote:
> > On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@intel.com wrote:
> > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > > index 5762ae4..69eea3a 100644
> > > --- a/tools/perf/util/sort.c
> > > +++ b/tools/perf/util/sort.c
> > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > > if (sort__mode == SORT_MODE__DIFF)
> > > return keys;
> > >
> > > + if (strstr(keys, "overhead"))
> > > + return keys;
> > > +
> > > keys = prefix_if_not_in("overhead", keys);
> >
> > hum, you basicaly do what's at begining of prefix_if_not_in function:
> >
> > static char *prefix_if_not_in(const char *pre, char *str)
> > {
> > char *n;
> >
> > if (!str || strstr(str, pre))
> > return str;
> > ...
> >
> Thanks, will change it.
>
Misunderstood your words. This is not equal to prefix_if_not_in.
# perf record -ag
# perf report -s overhead,sym
Samples: 7K of event 'cycles', Event count (approx.): 865138253
Children Self Symbol
+ 26.41% 0.00% [k] verify_cpu
+ 26.37% 0.04% [k] cpu_startup_entry
+ 25.93% 0.27% [k] do_idle
+ 19.88% 0.00% [k] start_secondary
....
'Children' should not be here.
> >
> > could you please provide the example described in changelog?
> >
> Will add example cmdline there, Thanks.
>
> > jirka
>
> --
> Thanks,
> Changbin Du
--
Thanks,
Changbin Du
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-06-02 3:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 9:03 [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given changbin.du
2017-06-01 10:21 ` Jiri Olsa
2017-06-02 2:52 ` Du, Changbin
2017-06-02 3:22 ` Du, Changbin [this message]
2017-06-02 4:22 ` [PATCH v2] " changbin.du
2017-06-26 8:06 ` Du, Changbin
2017-06-29 15:22 ` Jiri Olsa
2017-07-05 3:02 ` Du, Changbin
2017-07-05 3:35 ` [PATCH v3] " changbin.du
2017-07-06 16:04 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2017-03-13 8:36 [PATCH] " changbin.du
2017-03-15 2:06 ` Du, Changbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602032257.GA13003@intel.com \
--to=changbin.du@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).