From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: mingo@redhat.com, mhiramat@kernel.org, brendan.d.gregg@gmail.com,
peterz@infradead.org, alexander.shishkin@linux.intel.com,
wangnan0@huawei.com, jolsa@kernel.org, ak@linux.intel.com,
treeze.taeung@gmail.com, mathieu.poirier@linaro.org,
hekuang@huawei.com, sukadev@linux.vnet.ibm.com,
ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com,
adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
hemant@linux.vnet.ibm.com
Subject: Re: [PATCH v5 2/7] perf tool: Add option macro OPT_CALLBACK_ARG
Date: Tue, 14 Mar 2017 18:00:24 -0300 [thread overview]
Message-ID: <20170314210024.GD12825@kernel.org> (raw)
In-Reply-To: <20170314150658.7065-3-ravi.bangoria@linux.vnet.ibm.com>
Em Tue, Mar 14, 2017 at 08:36:53PM +0530, Ravi Bangoria escreveu:
> Add an option macro that is the same as OPT_CALLBACK_OPTARG except
> that the argument is not optional.
Not 'perf tool:', adjusted to 'tools lib subcmd:' as this is not perf
specific at all, tools/lib/subcmd/ is by other tools, such as objtool.
- Arnaldo
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
> tools/lib/subcmd/parse-options.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/lib/subcmd/parse-options.h b/tools/lib/subcmd/parse-options.h
> index f054ca1..79472e0 100644
> --- a/tools/lib/subcmd/parse-options.h
> +++ b/tools/lib/subcmd/parse-options.h
> @@ -160,6 +160,10 @@ struct option {
> { .type = OPTION_CALLBACK, .short_name = (s), .long_name = (l), \
> .value = (v), .argh = (a), .help = (h), .callback = (f), \
> .flags = PARSE_OPT_OPTARG, .data = (d) }
> +#define OPT_CALLBACK_ARG(s, l, v, d, a, h, f) \
> + { .type = OPTION_CALLBACK, .short_name = (s), .long_name = (l), \
> + .value = (v), .argh = (a), .help = (h), .callback = (f), \
> + .data = (d) }
>
> /* parse_options() will filter out the processed options and leave the
> * non-option argments in argv[].
> --
> 2.9.3
next prev parent reply other threads:[~2017-03-14 21:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:06 [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 1/7] perf/sdt: Introduce util func is_sdt_event() Ravi Bangoria
2017-03-16 16:34 ` [tip:perf/core] perf probe: " tip-bot for Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 2/7] perf tool: Add option macro OPT_CALLBACK_ARG Ravi Bangoria
2017-03-14 21:00 ` Arnaldo Carvalho de Melo [this message]
2017-03-14 15:06 ` [PATCH v5 3/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-15 12:03 ` Jiri Olsa
2017-03-15 13:16 ` Arnaldo Carvalho de Melo
2017-03-15 13:49 ` Ravi Bangoria
2017-03-17 9:05 ` Masami Hiramatsu
2017-03-20 3:51 ` Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 4/7] perf/sdt: Allow recording of existing events Ravi Bangoria
2017-03-17 23:13 ` Masami Hiramatsu
2017-03-20 9:12 ` Ravi Bangoria
2017-03-21 4:52 ` Masami Hiramatsu
2017-03-14 15:06 ` [PATCH v5 5/7] perf/sdt: Warn when number of events recorded are not equal to cached events Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 6/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 7/7] " Ravi Bangoria
2017-03-17 23:14 ` Masami Hiramatsu
2017-03-20 9:16 ` Ravi Bangoria
2017-03-16 9:51 ` [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Masami Hiramatsu
2017-03-16 11:27 ` Ravi Bangoria
2017-03-17 4:42 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314210024.GD12825@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=brendan.d.gregg@gmail.com \
--cc=hekuang@huawei.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).