From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: mingo@redhat.com, acme@kernel.org, brendan.d.gregg@gmail.com,
peterz@infradead.org, alexander.shishkin@linux.intel.com,
wangnan0@huawei.com, jolsa@kernel.org, ak@linux.intel.com,
treeze.taeung@gmail.com, mathieu.poirier@linaro.org,
hekuang@huawei.com, sukadev@linux.vnet.ibm.com,
ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com,
adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
hemant@linux.vnet.ibm.com,
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record'
Date: Thu, 16 Mar 2017 16:57:52 +0530 [thread overview]
Message-ID: <58CA76B8.1030706@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170316185140.a17b885479976d4be36349f4@kernel.org>
Hi Masami,
On Thursday 16 March 2017 03:21 PM, Masami Hiramatsu wrote:
> On Tue, 14 Mar 2017 20:36:51 +0530
> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
>
>> Changes in v5:
>> - Patch 2/7 is new. New option introduced in this patch helps to pass
>> custome data from builtin-*.c to libperf.
>>
>> - All direct callbacks from libelf to builtin-record.c is removed.
>>
Minor correction.. s/libelf/libperf/
>> - Merged 2nd and 4th patch of v4 into patch 2 of v5.
s/patch 2 of v5/patch 3 of v5/
>>
>> - Moved all functions from util/probe-file.c to util/probe-event.c
>> which operates on perf_probe_event.
>>
>> - Made free_sdt_list() static as it's only used inside util/probe-event.c.
>>
>> - Couple of other changes as Masami has suggested in v4 review.
> Hi Ravi,
> Could you also describe which patches are updated? It seems 1/7 is not
> modified, correct?
Let me list a patch-wise brief changelog.
patch 1/7:- Introduced dummy version of is_sdt_event() which always return false
if !HAVE_LIBELF_SUPPORT.
patch 2/7: - is new. A new option introduced in this patch helps to passcustom
data from builtin-*.c to libperf.
patch 3/7: - Removed direct calls from libperf to builtin-record.c which was used
to prepare record.sdt_event_list. Instead pass list to libperf and let
libperf manage it.
- Introduce new wrapper func record__parse_events_option() that can
differentiate between sdt and other events while parsing them in
perf record.
- Moved all functions from util/probe-file.c to util/probe-event.c
which operates on perf_probe_event.
- Merged 2nd and 4th patch of v4 into this patch.
- Made free_sdt_list() static as it's only used inside util/probe-event.c.
patch 4/7:- Removed direct calls from libperf to builtin-record.c which was used
to prepare record.sdt_event_list. Instead pass list to libperf and let
libperf manage it.
- Moved all functions from util/probe-file.c to util/probe-event.c
which operates on perf_probe_event.
patch 5/7: No changes
patch 6/7: No changes
patch 7/7: No changes
Let me know if you need more details.
Thanks,
Ravi
next prev parent reply other threads:[~2017-03-16 11:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:06 [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 1/7] perf/sdt: Introduce util func is_sdt_event() Ravi Bangoria
2017-03-16 16:34 ` [tip:perf/core] perf probe: " tip-bot for Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 2/7] perf tool: Add option macro OPT_CALLBACK_ARG Ravi Bangoria
2017-03-14 21:00 ` Arnaldo Carvalho de Melo
2017-03-14 15:06 ` [PATCH v5 3/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-15 12:03 ` Jiri Olsa
2017-03-15 13:16 ` Arnaldo Carvalho de Melo
2017-03-15 13:49 ` Ravi Bangoria
2017-03-17 9:05 ` Masami Hiramatsu
2017-03-20 3:51 ` Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 4/7] perf/sdt: Allow recording of existing events Ravi Bangoria
2017-03-17 23:13 ` Masami Hiramatsu
2017-03-20 9:12 ` Ravi Bangoria
2017-03-21 4:52 ` Masami Hiramatsu
2017-03-14 15:06 ` [PATCH v5 5/7] perf/sdt: Warn when number of events recorded are not equal to cached events Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 6/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 7/7] " Ravi Bangoria
2017-03-17 23:14 ` Masami Hiramatsu
2017-03-20 9:16 ` Ravi Bangoria
2017-03-16 9:51 ` [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Masami Hiramatsu
2017-03-16 11:27 ` Ravi Bangoria [this message]
2017-03-17 4:42 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58CA76B8.1030706@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=brendan.d.gregg@gmail.com \
--cc=hekuang@huawei.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).