From: Jiri Olsa <jolsa@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: mingo@redhat.com, acme@kernel.org, mhiramat@kernel.org,
brendan.d.gregg@gmail.com, peterz@infradead.org,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
jolsa@kernel.org, ak@linux.intel.com, treeze.taeung@gmail.com,
mathieu.poirier@linaro.org, hekuang@huawei.com,
sukadev@linux.vnet.ibm.com, ananth@in.ibm.com,
naveen.n.rao@linux.vnet.ibm.com, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com
Subject: Re: [PATCH v5 3/7] perf/sdt: Directly record SDT events with 'perf record'
Date: Wed, 15 Mar 2017 13:03:31 +0100 [thread overview]
Message-ID: <20170315120331.GC18147@krava> (raw)
In-Reply-To: <20170314150658.7065-4-ravi.bangoria@linux.vnet.ibm.com>
On Tue, Mar 14, 2017 at 08:36:54PM +0530, Ravi Bangoria wrote:
SNIP
> ---
> tools/perf/builtin-record.c | 27 ++++++-
> tools/perf/util/parse-events.c | 60 +++++++++++++++
> tools/perf/util/parse-events.h | 3 +
> tools/perf/util/probe-event.c | 165 ++++++++++++++++++++++++++++++++++++++++-
> tools/perf/util/probe-event.h | 12 +++
> 5 files changed, 261 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index bc84a37..e8e1f73 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -73,6 +73,7 @@ struct record {
> bool timestamp_filename;
> struct switch_output switch_output;
> unsigned long long samples;
> + struct list_head sdt_event_list;
> };
>
> static volatile int auxtrace_record__snapshot_started;
> @@ -1503,6 +1504,23 @@ static struct record record = {
> },
> };
>
> +static int record__parse_events_option(const struct option *opt,
> + const char *str,
> + int unset)
> +{
> + if (is_sdt_event((char *) str))
> + return parse_sdt_events_option(opt, str, unset);
> + else
> + return parse_events_option(opt, str, unset);
so what happens if there're more than one event in 'str' like:
-e cycles,std_...
would it be better to plug this directly into parse-events.y
parser.. and handle it like any other event type?
thanks,
jirka
next prev parent reply other threads:[~2017-03-15 12:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:06 [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 1/7] perf/sdt: Introduce util func is_sdt_event() Ravi Bangoria
2017-03-16 16:34 ` [tip:perf/core] perf probe: " tip-bot for Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 2/7] perf tool: Add option macro OPT_CALLBACK_ARG Ravi Bangoria
2017-03-14 21:00 ` Arnaldo Carvalho de Melo
2017-03-14 15:06 ` [PATCH v5 3/7] perf/sdt: Directly record SDT events with 'perf record' Ravi Bangoria
2017-03-15 12:03 ` Jiri Olsa [this message]
2017-03-15 13:16 ` Arnaldo Carvalho de Melo
2017-03-15 13:49 ` Ravi Bangoria
2017-03-17 9:05 ` Masami Hiramatsu
2017-03-20 3:51 ` Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 4/7] perf/sdt: Allow recording of existing events Ravi Bangoria
2017-03-17 23:13 ` Masami Hiramatsu
2017-03-20 9:12 ` Ravi Bangoria
2017-03-21 4:52 ` Masami Hiramatsu
2017-03-14 15:06 ` [PATCH v5 5/7] perf/sdt: Warn when number of events recorded are not equal to cached events Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 6/7] perf/sdt: List events fetched from uprobe_events Ravi Bangoria
2017-03-14 15:06 ` [PATCH v5 7/7] " Ravi Bangoria
2017-03-17 23:14 ` Masami Hiramatsu
2017-03-20 9:16 ` Ravi Bangoria
2017-03-16 9:51 ` [PATCH v5 0/7] perf/sdt: Directly record SDT events with 'perf record' Masami Hiramatsu
2017-03-16 11:27 ` Ravi Bangoria
2017-03-17 4:42 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315120331.GC18147@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=brendan.d.gregg@gmail.com \
--cc=hekuang@huawei.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).