* please use pci_alloc_irq_vectors in thunderx_edac.
@ 2017-04-12 6:06 Christoph Hellwig
2017-04-12 9:21 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2017-04-12 6:06 UTC (permalink / raw)
To: Sergey Temerkhanov; +Cc: bp, linux-edac, linux-kernel
Hi Sergey,
you're new thunderx_edac driver uses pci_enable_msix_exact for no
good reason. Can you please switch it to use pci_alloc_irq_vectors
before it gets merged to mainline?
Thanks,
Christoph
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: please use pci_alloc_irq_vectors in thunderx_edac.
2017-04-12 6:06 please use pci_alloc_irq_vectors in thunderx_edac Christoph Hellwig
@ 2017-04-12 9:21 ` Borislav Petkov
2017-04-12 17:16 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2017-04-12 9:21 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Sergey Temerkhanov, linux-edac, linux-kernel
On Wed, Apr 12, 2017 at 08:06:00AM +0200, Christoph Hellwig wrote:
> Hi Sergey,
>
> you're new thunderx_edac driver uses pci_enable_msix_exact for no
> good reason. Can you please switch it to use pci_alloc_irq_vectors
> before it gets merged to mainline?
Do we need to mark pci_enable_msix_exact() deprecated or so, or maybe a
checkpatch rule?
It says so in some text file in Documentation:
4.3 Legacy APIs
The following old APIs to enable and disable MSI or MSI-X interrupts should
not be used in new code:
pci_enable_msi() /* deprecated */
pci_disable_msi() /* deprecated */
pci_enable_msix_range() /* deprecated */
pci_enable_msix_exact() /* deprecated */
pci_disable_msix() /* deprecated */
but maybe we should enforce it?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: please use pci_alloc_irq_vectors in thunderx_edac.
2017-04-12 9:21 ` Borislav Petkov
@ 2017-04-12 17:16 ` Christoph Hellwig
2017-04-12 17:28 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2017-04-12 17:16 UTC (permalink / raw)
To: Borislav Petkov
Cc: Christoph Hellwig, Sergey Temerkhanov, linux-edac, linux-kernel
On Wed, Apr 12, 2017 at 11:21:01AM +0200, Borislav Petkov wrote:
> Do we need to mark pci_enable_msix_exact() deprecated or so, or maybe a
> checkpatch rule?
Did we ever do this for deprecated APIs before? For now I'm just watching
Linux-next and sending gentle reminders :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: please use pci_alloc_irq_vectors in thunderx_edac.
2017-04-12 17:16 ` Christoph Hellwig
@ 2017-04-12 17:28 ` Borislav Petkov
2017-04-12 17:30 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2017-04-12 17:28 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Sergey Temerkhanov, linux-edac, linux-kernel
On Wed, Apr 12, 2017 at 07:16:22PM +0200, Christoph Hellwig wrote:
> Did we ever do this for deprecated APIs before? For now I'm just watching
> Linux-next and sending gentle reminders :)
$ git grep __deprecated
shows some have been done. I wonder whether marking
pci_enable_msix_exact() would cause a lot of warnings though. An
allyesconfig build would tell...
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: please use pci_alloc_irq_vectors in thunderx_edac.
2017-04-12 17:28 ` Borislav Petkov
@ 2017-04-12 17:30 ` Christoph Hellwig
2017-04-13 8:53 ` Johannes Thumshirn
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2017-04-12 17:30 UTC (permalink / raw)
To: Borislav Petkov
Cc: Christoph Hellwig, Sergey Temerkhanov, linux-edac, linux-kernel
On Wed, Apr 12, 2017 at 07:28:59PM +0200, Borislav Petkov wrote:
> On Wed, Apr 12, 2017 at 07:16:22PM +0200, Christoph Hellwig wrote:
> > Did we ever do this for deprecated APIs before? For now I'm just watching
> > Linux-next and sending gentle reminders :)
>
> $ git grep __deprecated
>
> shows some have been done. I wonder whether marking
> pci_enable_msix_exact() would cause a lot of warnings though. An
> allyesconfig build would tell...
It would cause lots of warnings. The problem with __deprecated is that
it causes warnings for existing users, not just new ones.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: please use pci_alloc_irq_vectors in thunderx_edac.
2017-04-12 17:30 ` Christoph Hellwig
@ 2017-04-13 8:53 ` Johannes Thumshirn
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2017-04-13 8:53 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Borislav Petkov, Sergey Temerkhanov, linux-edac, linux-kernel
On Wed, Apr 12, 2017 at 07:30:22PM +0200, Christoph Hellwig wrote:
> > shows some have been done. I wonder whether marking
> > pci_enable_msix_exact() would cause a lot of warnings though. An
> > allyesconfig build would tell...
>
> It would cause lots of warnings. The problem with __deprecated is that
> it causes warnings for existing users, not just new ones.
So a checkpatch rule is the way to go, I guess.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-13 8:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 6:06 please use pci_alloc_irq_vectors in thunderx_edac Christoph Hellwig
2017-04-12 9:21 ` Borislav Petkov
2017-04-12 17:16 ` Christoph Hellwig
2017-04-12 17:28 ` Borislav Petkov
2017-04-12 17:30 ` Christoph Hellwig
2017-04-13 8:53 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).