From: Patrick Bellasi <patrick.bellasi@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Paul Turner <pjt@google.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Todd Kjos <tkjos@android.com>, Tim Murray <timmurray@google.com>,
Andres Oportus <andresoportus@google.com>,
Joel Fernandes <joelaf@google.com>,
Juri Lelli <juri.lelli@arm.com>,
Chris Redpath <chris.redpath@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [RFC v3 0/5] Add capacity capping support to the CPU controller
Date: Wed, 12 Apr 2017 15:43:10 +0100 [thread overview]
Message-ID: <20170412144310.GB7572@e110439-lin> (raw)
In-Reply-To: <20170412143414.2c27dakhrydl2pqb@hirez.programming.kicks-ass.net>
On 12-Apr 16:34, Peter Zijlstra wrote:
> On Wed, Apr 12, 2017 at 02:27:41PM +0100, Patrick Bellasi wrote:
> > On 12-Apr 14:48, Peter Zijlstra wrote:
> > > On Tue, Apr 11, 2017 at 06:58:33PM +0100, Patrick Bellasi wrote:
> > > > > illustrated per your above points in that it affects both, while in
> > > > > fact it actually modifies another metric, namely util_avg.
> > > >
> > > > I don't see it modifying in any direct way util_avg.
> > >
> > > The point is that clamps called 'capacity' are applied to util. So while
> > > you don't modify util directly, you do modify the util signal (for one
> > > consumer).
> >
> > Right, but this consumer (i.e. schedutil) it's already translating
> > the util_avg into a next_freq (which ultimately it's a capacity).
> >
> > Thus, I don't see a big misfit in that code path to "filter" this
> > translation with a capacity clamp.
>
> Still strikes me as odd though.
Can you better elaborate on they why?
--
#include <best/regards.h>
Patrick Bellasi
next prev parent reply other threads:[~2017-04-12 14:43 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 14:38 [RFC v3 0/5] Add capacity capping support to the CPU controller Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 1/5] sched/core: add capacity constraints to " Patrick Bellasi
2017-03-13 10:46 ` Joel Fernandes (Google)
2017-03-15 11:20 ` Patrick Bellasi
2017-03-15 13:20 ` Joel Fernandes
2017-03-15 16:10 ` Paul E. McKenney
2017-03-15 16:44 ` Patrick Bellasi
2017-03-15 17:24 ` Paul E. McKenney
2017-03-15 17:57 ` Patrick Bellasi
2017-03-20 17:15 ` Tejun Heo
2017-03-20 17:36 ` Tejun Heo
2017-03-20 18:08 ` Patrick Bellasi
2017-03-23 0:28 ` Joel Fernandes (Google)
2017-03-23 10:32 ` Patrick Bellasi
2017-03-23 16:01 ` Tejun Heo
2017-03-23 18:15 ` Patrick Bellasi
2017-03-23 18:39 ` Tejun Heo
2017-03-24 6:37 ` Joel Fernandes (Google)
2017-03-24 15:00 ` Tejun Heo
2017-03-30 21:13 ` Paul Turner
2017-03-24 7:02 ` Joel Fernandes (Google)
2017-03-30 21:15 ` Paul Turner
2017-04-01 16:25 ` Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 2/5] sched/core: track CPU's capacity_{min,max} Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 3/5] sched/core: sync capacity_{min,max} between slow and fast paths Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 4/5] sched/{core,cpufreq_schedutil}: add capacity clamping for FAIR tasks Patrick Bellasi
2017-02-28 14:38 ` [RFC v3 5/5] sched/{core,cpufreq_schedutil}: add capacity clamping for RT/DL tasks Patrick Bellasi
2017-03-13 10:08 ` Joel Fernandes (Google)
2017-03-15 11:40 ` Patrick Bellasi
2017-03-15 12:59 ` Joel Fernandes
2017-03-15 14:44 ` Juri Lelli
2017-03-15 16:13 ` Joel Fernandes
2017-03-15 16:24 ` Juri Lelli
2017-03-15 23:40 ` Joel Fernandes
2017-03-16 11:16 ` Juri Lelli
2017-03-16 12:27 ` Patrick Bellasi
2017-03-16 12:44 ` Juri Lelli
2017-03-16 16:58 ` Joel Fernandes
2017-03-16 17:17 ` Juri Lelli
2017-03-15 11:41 ` [RFC v3 0/5] Add capacity capping support to the CPU controller Rafael J. Wysocki
2017-03-15 12:59 ` Patrick Bellasi
2017-03-16 1:04 ` Rafael J. Wysocki
2017-03-16 3:15 ` Joel Fernandes
2017-03-20 22:51 ` Rafael J. Wysocki
2017-03-21 11:01 ` Patrick Bellasi
2017-03-24 23:52 ` Rafael J. Wysocki
2017-03-16 12:23 ` Patrick Bellasi
2017-03-20 14:51 ` Tejun Heo
2017-03-20 17:22 ` Patrick Bellasi
2017-04-10 7:36 ` Peter Zijlstra
2017-04-11 17:58 ` Patrick Bellasi
2017-04-12 12:10 ` Peter Zijlstra
2017-04-12 13:55 ` Patrick Bellasi
2017-04-12 15:37 ` Peter Zijlstra
2017-04-13 11:33 ` Patrick Bellasi
2017-04-12 12:15 ` Peter Zijlstra
2017-04-12 13:34 ` Patrick Bellasi
2017-04-12 14:41 ` Peter Zijlstra
2017-04-12 12:22 ` Peter Zijlstra
2017-04-12 13:24 ` Patrick Bellasi
2017-04-12 12:48 ` Peter Zijlstra
2017-04-12 13:27 ` Patrick Bellasi
2017-04-12 14:34 ` Peter Zijlstra
2017-04-12 14:43 ` Patrick Bellasi [this message]
2017-04-12 16:14 ` Peter Zijlstra
2017-04-13 10:34 ` Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412144310.GB7572@e110439-lin \
--to=patrick.bellasi@arm.com \
--cc=andresoportus@google.com \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=john.stultz@linaro.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=timmurray@google.com \
--cc=tj@kernel.org \
--cc=tkjos@android.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).