From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Lee Jones <lee.jones@linaro.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused
Date: Wed, 19 Apr 2017 19:52:27 +0200 [thread overview]
Message-ID: <20170419175227.x4uow3mhcweagpza@piout.net> (raw)
In-Reply-To: <20170419174824.4134087-1-arnd@arndb.de>
On 19/04/2017 at 19:48:07 +0200, Arnd Bergmann wrote:
> We get a harmless warning without CONFIG_PM:
>
> drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function]
>
> Marking the function as __maybe_unused does the right thing here
> and drops it silently when unused.
>
> Fixes: a483fb10e5ea ("memory: atmel-ebi: Add PM ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sure,
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
I think you can safely take it through arm-soc directly.
> ---
> drivers/memory/atmel-ebi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 35910f945bfa..99e644cda4d1 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -581,7 +581,7 @@ static int atmel_ebi_probe(struct platform_device *pdev)
> return of_platform_populate(np, NULL, NULL, dev);
> }
>
> -static int atmel_ebi_resume(struct device *dev)
> +static __maybe_unused int atmel_ebi_resume(struct device *dev)
> {
> struct atmel_ebi *ebi = dev_get_drvdata(dev);
> struct atmel_ebi_dev *ebid;
> --
> 2.9.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-19 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 17:48 [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused Arnd Bergmann
2017-04-19 17:52 ` Alexandre Belloni [this message]
2017-05-15 9:38 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419175227.x4uow3mhcweagpza@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).