linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused
@ 2017-04-19 17:48 Arnd Bergmann
  2017-04-19 17:52 ` Alexandre Belloni
  2017-05-15  9:38 ` Alexandre Belloni
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-04-19 17:48 UTC (permalink / raw)
  To: Nicolas Ferre, Alexandre Belloni
  Cc: Arnd Bergmann, Boris Brezillon, Lee Jones, Wei Yongjun,
	linux-arm-kernel, linux-kernel

We get a harmless warning without CONFIG_PM:

drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function]

Marking the function as __maybe_unused does the right thing here
and drops it silently when unused.

Fixes: a483fb10e5ea ("memory: atmel-ebi: Add PM ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/memory/atmel-ebi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
index 35910f945bfa..99e644cda4d1 100644
--- a/drivers/memory/atmel-ebi.c
+++ b/drivers/memory/atmel-ebi.c
@@ -581,7 +581,7 @@ static int atmel_ebi_probe(struct platform_device *pdev)
 	return of_platform_populate(np, NULL, NULL, dev);
 }
 
-static int atmel_ebi_resume(struct device *dev)
+static __maybe_unused int atmel_ebi_resume(struct device *dev)
 {
 	struct atmel_ebi *ebi = dev_get_drvdata(dev);
 	struct atmel_ebi_dev *ebid;
-- 
2.9.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused
  2017-04-19 17:48 [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused Arnd Bergmann
@ 2017-04-19 17:52 ` Alexandre Belloni
  2017-05-15  9:38 ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2017-04-19 17:52 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Nicolas Ferre, Boris Brezillon, Lee Jones, Wei Yongjun,
	linux-arm-kernel, linux-kernel

On 19/04/2017 at 19:48:07 +0200, Arnd Bergmann wrote:
> We get a harmless warning without CONFIG_PM:
> 
> drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function]
> 
> Marking the function as __maybe_unused does the right thing here
> and drops it silently when unused.
> 
> Fixes: a483fb10e5ea ("memory: atmel-ebi: Add PM ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Sure,

Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

I think you can safely take it through arm-soc directly.

> ---
>  drivers/memory/atmel-ebi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c
> index 35910f945bfa..99e644cda4d1 100644
> --- a/drivers/memory/atmel-ebi.c
> +++ b/drivers/memory/atmel-ebi.c
> @@ -581,7 +581,7 @@ static int atmel_ebi_probe(struct platform_device *pdev)
>  	return of_platform_populate(np, NULL, NULL, dev);
>  }
>  
> -static int atmel_ebi_resume(struct device *dev)
> +static __maybe_unused int atmel_ebi_resume(struct device *dev)
>  {
>  	struct atmel_ebi *ebi = dev_get_drvdata(dev);
>  	struct atmel_ebi_dev *ebid;
> -- 
> 2.9.0
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused
  2017-04-19 17:48 [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused Arnd Bergmann
  2017-04-19 17:52 ` Alexandre Belloni
@ 2017-05-15  9:38 ` Alexandre Belloni
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2017-05-15  9:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Nicolas Ferre, Boris Brezillon, Lee Jones, Wei Yongjun,
	linux-arm-kernel, linux-kernel

On 19/04/2017 at 19:48:07 +0200, Arnd Bergmann wrote:
> We get a harmless warning without CONFIG_PM:
> 
> drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function]
> 
> Marking the function as __maybe_unused does the right thing here
> and drops it silently when unused.
> 
> Fixes: a483fb10e5ea ("memory: atmel-ebi: Add PM ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/memory/atmel-ebi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-15  9:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 17:48 [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused Arnd Bergmann
2017-04-19 17:52 ` Alexandre Belloni
2017-05-15  9:38 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).