* [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
@ 2017-04-28 21:00 Darren Hart (VMware)
2017-04-28 21:09 ` Dmitry Torokhov
2017-05-03 6:28 ` Jean Delvare
0 siblings, 2 replies; 4+ messages in thread
From: Darren Hart (VMware) @ 2017-04-28 21:00 UTC (permalink / raw)
To: LKML, platform-driver-x86
Cc: Hans de Goede, Andy Shevchenko, Jean Delvare, Dmitry Torokhov
SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
driver. Make this explicitly clear in the Kconfig depends.
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: Jean Delvare <jdelvare@suse.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9e5b2c2..5690664 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
config SILEAD_DMI
bool "Tablets with Silead touchscreens"
- depends on ACPI && DMI && I2C=y && INPUT
+ depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
---help---
Certain ACPI based tablets with Silead touchscreens do not have
enough data in ACPI tables for the touchscreen driver to handle
--
2.9.3
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
2017-04-28 21:00 [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD Darren Hart (VMware)
@ 2017-04-28 21:09 ` Dmitry Torokhov
2017-04-28 22:14 ` Darren Hart
2017-05-03 6:28 ` Jean Delvare
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2017-04-28 21:09 UTC (permalink / raw)
To: Darren Hart (VMware)
Cc: LKML, platform-driver-x86, Hans de Goede, Andy Shevchenko, Jean Delvare
On Fri, Apr 28, 2017 at 02:00:19PM -0700, Darren Hart (VMware) wrote:
> SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> driver. Make this explicitly clear in the Kconfig depends.
>
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9e5b2c2..5690664 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
>
> config SILEAD_DMI
> bool "Tablets with Silead touchscreens"
> - depends on ACPI && DMI && I2C=y && INPUT
> + depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop
INPUT dependency.
Otherwise
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
2017-04-28 21:09 ` Dmitry Torokhov
@ 2017-04-28 22:14 ` Darren Hart
0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2017-04-28 22:14 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: LKML, platform-driver-x86, Hans de Goede, Andy Shevchenko, Jean Delvare
On Fri, Apr 28, 2017 at 02:09:00PM -0700, Dmitry Torokhov wrote:
> On Fri, Apr 28, 2017 at 02:00:19PM -0700, Darren Hart (VMware) wrote:
> > SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> > driver. Make this explicitly clear in the Kconfig depends.
> >
> > Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Andy Shevchenko <andy@infradead.org>
> > Cc: Jean Delvare <jdelvare@suse.de>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> > drivers/platform/x86/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 9e5b2c2..5690664 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
> >
> > config SILEAD_DMI
> > bool "Tablets with Silead touchscreens"
> > - depends on ACPI && DMI && I2C=y && INPUT
> > + depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
>
> Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop
> INPUT dependency.
>
Done, thanks.
> Otherwise
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> --
> Dmitry
>
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
2017-04-28 21:00 [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD Darren Hart (VMware)
2017-04-28 21:09 ` Dmitry Torokhov
@ 2017-05-03 6:28 ` Jean Delvare
1 sibling, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2017-05-03 6:28 UTC (permalink / raw)
To: Darren Hart (VMware)
Cc: LKML, platform-driver-x86, Hans de Goede, Andy Shevchenko,
Dmitry Torokhov
On Fri, 28 Apr 2017 14:00:19 -0700, Darren Hart (VMware) wrote:
> SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> driver. Make this explicitly clear in the Kconfig depends.
>
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9e5b2c2..5690664 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
>
> config SILEAD_DMI
> bool "Tablets with Silead touchscreens"
> - depends on ACPI && DMI && I2C=y && INPUT
> + depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
> ---help---
> Certain ACPI based tablets with Silead touchscreens do not have
> enough data in ACPI tables for the touchscreen driver to handle
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Thanks Darren,
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-03 6:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-28 21:00 [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD Darren Hart (VMware)
2017-04-28 21:09 ` Dmitry Torokhov
2017-04-28 22:14 ` Darren Hart
2017-05-03 6:28 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).