* [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter
@ 2017-05-01 14:57 Martin Kepplinger
2017-05-01 17:11 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2017-05-01 14:57 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Martin Kepplinger
The recent change
commit 2098cc15d9a0 ("Input: ar1021_i2c - enable touch mode during open")
also removed the ABS_X input code to be set. This must have been done
by mistake; so we bring back the X axis!
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
Dmitry,
this must have slipped in somehow. I didn't have this mistake included:
https://www.spinics.net/lists/linux-input/msg51103.html
thanks
martin
drivers/input/touchscreen/ar1021_i2c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
index ff59c3a383d6..3f55f673f661 100644
--- a/drivers/input/touchscreen/ar1021_i2c.c
+++ b/drivers/input/touchscreen/ar1021_i2c.c
@@ -118,6 +118,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
input->close = ar1021_i2c_close;
input_set_capability(input, EV_KEY, BTN_TOUCH);
+ input_set_abs_params(input, ABS_X, 0, AR1021_MAX_X, 0, 0);
input_set_abs_params(input, ABS_Y, 0, AR1021_MAX_Y, 0, 0);
input_set_drvdata(input, ar1021);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter
2017-05-01 14:57 [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter Martin Kepplinger
@ 2017-05-01 17:11 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-05-01 17:11 UTC (permalink / raw)
To: Martin Kepplinger; +Cc: linux-input, linux-kernel
On Mon, May 01, 2017 at 04:57:09PM +0200, Martin Kepplinger wrote:
> The recent change
>
> commit 2098cc15d9a0 ("Input: ar1021_i2c - enable touch mode during open")
>
> also removed the ABS_X input code to be set. This must have been done
> by mistake; so we bring back the X axis!
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
>
> Dmitry,
>
> this must have slipped in somehow. I didn't have this mistake included:
> https://www.spinics.net/lists/linux-input/msg51103.html
I must have fat-fingered it somehow. I fixed up the original commit
since it wasn't buried too deep.
Thanks.
>
> thanks
> martin
>
>
> drivers/input/touchscreen/ar1021_i2c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index ff59c3a383d6..3f55f673f661 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -118,6 +118,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
> input->close = ar1021_i2c_close;
>
> input_set_capability(input, EV_KEY, BTN_TOUCH);
> + input_set_abs_params(input, ABS_X, 0, AR1021_MAX_X, 0, 0);
> input_set_abs_params(input, ABS_Y, 0, AR1021_MAX_Y, 0, 0);
>
> input_set_drvdata(input, ar1021);
> --
> 2.11.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-01 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-01 14:57 [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter Martin Kepplinger
2017-05-01 17:11 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).