* [PATCH] x86/intel_rdt: Fix two typos in Documentation
@ 2017-04-06 17:09 Xiaochen Shen
2017-05-03 3:29 ` Shen, Xiaochen
2017-05-09 7:30 ` Fenghua Yu
0 siblings, 2 replies; 3+ messages in thread
From: Xiaochen Shen @ 2017-04-06 17:09 UTC (permalink / raw)
To: tglx, linux-kernel, x86; +Cc: Xiaochen Shen, Fenghua Yu
Both typos are in example 3.
Because cache id 0 is the only cache id, the ";" is redundant in
"# echo "L3:0=ffc00;" > p0/schemata".
And "C0" in "# echo C0 > p0/cpus" is wrong because it specifies core
6-7 instead of wanted core 4-7.
Correct the typos to avoid confusion.
Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
Documentation/x86/intel_rdt_ui.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/x86/intel_rdt_ui.txt b/Documentation/x86/intel_rdt_ui.txt
index 51cf6fa..cd752c1 100644
--- a/Documentation/x86/intel_rdt_ui.txt
+++ b/Documentation/x86/intel_rdt_ui.txt
@@ -206,12 +206,12 @@ Next we make a resource group for our real time cores and give
it access to the "top" 50% of the cache on socket 0.
# mkdir p0
-# echo "L3:0=ffc00;" > p0/schemata
+# echo "L3:0=ffc00" > p0/schemata
Finally we move core 4-7 over to the new group and make sure that the
kernel and the tasks running there get 50% of the cache.
-# echo C0 > p0/cpus
+# echo F0 > p0/cpus
4) Locking between applications
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/intel_rdt: Fix two typos in Documentation
2017-04-06 17:09 [PATCH] x86/intel_rdt: Fix two typos in Documentation Xiaochen Shen
@ 2017-05-03 3:29 ` Shen, Xiaochen
2017-05-09 7:30 ` Fenghua Yu
1 sibling, 0 replies; 3+ messages in thread
From: Shen, Xiaochen @ 2017-05-03 3:29 UTC (permalink / raw)
To: tglx, linux-kernel, x86; +Cc: Fenghua Yu
Sorry, please ignore this patch.
The first typo in this patch has been already fixed by:
a9cad3d4f046 ("Documentation, x86: Intel Memory bandwidth allocation")
A new patch is submitted to address the other typo left over:
https://lkml.org/lkml/2017/5/2/595
Best regards
Xiaochen Shen
On 2017/4/7 1:09, Xiaochen Shen wrote:
> Both typos are in example 3.
>
> Because cache id 0 is the only cache id, the ";" is redundant in
> "# echo "L3:0=ffc00;" > p0/schemata".
>
> And "C0" in "# echo C0 > p0/cpus" is wrong because it specifies core
> 6-7 instead of wanted core 4-7.
>
> Correct the typos to avoid confusion.
>
> Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> Documentation/x86/intel_rdt_ui.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/x86/intel_rdt_ui.txt b/Documentation/x86/intel_rdt_ui.txt
> index 51cf6fa..cd752c1 100644
> --- a/Documentation/x86/intel_rdt_ui.txt
> +++ b/Documentation/x86/intel_rdt_ui.txt
> @@ -206,12 +206,12 @@ Next we make a resource group for our real time cores and give
> it access to the "top" 50% of the cache on socket 0.
>
> # mkdir p0
> -# echo "L3:0=ffc00;" > p0/schemata
> +# echo "L3:0=ffc00" > p0/schemata
>
> Finally we move core 4-7 over to the new group and make sure that the
> kernel and the tasks running there get 50% of the cache.
>
> -# echo C0 > p0/cpus
> +# echo F0 > p0/cpus
>
> 4) Locking between applications
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/intel_rdt: Fix two typos in Documentation
2017-04-06 17:09 [PATCH] x86/intel_rdt: Fix two typos in Documentation Xiaochen Shen
2017-05-03 3:29 ` Shen, Xiaochen
@ 2017-05-09 7:30 ` Fenghua Yu
1 sibling, 0 replies; 3+ messages in thread
From: Fenghua Yu @ 2017-05-09 7:30 UTC (permalink / raw)
To: Xiaochen Shen; +Cc: tglx, linux-kernel, x86, Fenghua Yu
On Fri, Apr 07, 2017 at 01:09:41AM +0800, Xiaochen Shen wrote:
> Both typos are in example 3.
>
> Because cache id 0 is the only cache id, the ";" is redundant in
> "# echo "L3:0=ffc00;" > p0/schemata".
>
> And "C0" in "# echo C0 > p0/cpus" is wrong because it specifies core
> 6-7 instead of wanted core 4-7.
>
> Correct the typos to avoid confusion.
>
> Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Acked-by: Fenghua Yu <fenghua.yu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-09 7:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 17:09 [PATCH] x86/intel_rdt: Fix two typos in Documentation Xiaochen Shen
2017-05-03 3:29 ` Shen, Xiaochen
2017-05-09 7:30 ` Fenghua Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).