linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-kernel@vger.kernel.org, tj@kernel.org,
	gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
	Kernel-team@fb.com
Subject: Re: [PATCH 1/5] kernfs: implement i_generation
Date: Tue, 23 May 2017 00:41:12 -0700	[thread overview]
Message-ID: <20170523074112.GD29525@infradead.org> (raw)
In-Reply-To: <1840aeeff2e745d223b01514a433b4b7f20040a6.1495490800.git.shli@fb.com>

On Mon, May 22, 2017 at 03:53:05PM -0700, Shaohua Li wrote:
> Set i_generation for kernfs inod. This is required to implement exportfs
> operations.
> 
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
>  fs/kernfs/dir.c        | 2 ++
>  fs/kernfs/inode.c      | 1 +
>  include/linux/kernfs.h | 2 ++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index db5900aaa..09d093e 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -634,6 +634,7 @@ static struct kernfs_node *__kernfs_new_node(struct kernfs_root *root,
>  	if (ret < 0)
>  		goto err_out2;
>  	kn->ino = ret;
> +	kn->generation = atomic_inc_return(&root->next_generation);

i_generation is only supposed to be valid on a per-inode basis, so this
global counter seems really odd.

  reply	other threads:[~2017-05-23  7:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 22:53 [PATCH 0/5] kernfs: add exportfs operations Shaohua Li
2017-05-22 22:53 ` [PATCH 1/5] kernfs: implement i_generation Shaohua Li
2017-05-23  7:41   ` Christoph Hellwig [this message]
2017-05-23 15:09     ` Shaohua Li
2017-05-23 19:20       ` Tejun Heo
2017-05-24 17:40       ` Christoph Hellwig
2017-05-22 22:53 ` [PATCH 2/5] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-05-22 22:53 ` [PATCH 3/5] kernfs: add an API to get kernfs node from " Shaohua Li
2017-05-22 22:53 ` [PATCH 4/5] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-05-23 18:37   ` Tejun Heo
2017-05-22 22:53 ` [PATCH 5/5] kernfs: add exportfs operations Shaohua Li
2017-05-23  7:40   ` Christoph Hellwig
2017-05-23 18:57     ` Tejun Heo
2017-05-24 17:38       ` Christoph Hellwig
2017-05-24 17:39         ` Tejun Heo
2017-05-24 17:41           ` Christoph Hellwig
2017-05-24 17:46             ` Tejun Heo
2017-05-24 18:01               ` Shaohua Li
2017-05-23 18:59   ` Tejun Heo
2017-05-23  7:39 ` [PATCH 0/5] " Christoph Hellwig
2017-05-23 15:13   ` Shaohua Li
2017-05-23 19:06 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523074112.GD29525@infradead.org \
    --to=hch@infradead.org \
    --cc=Kernel-team@fb.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@fb.com \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).