From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
viro@zeniv.linux.org.uk, Kernel-team@fb.com
Subject: Re: [PATCH 5/5] kernfs: add exportfs operations
Date: Tue, 23 May 2017 14:59:27 -0400 [thread overview]
Message-ID: <20170523185927.GC13222@htj.duckdns.org> (raw)
In-Reply-To: <3d3a0860317afa0fb722c1a6df58e04593fc700a.1495490800.git.shli@fb.com>
On Mon, May 22, 2017 at 03:53:09PM -0700, Shaohua Li wrote:
> +static struct inode *kernfs_nfs_get_inode(struct super_block *sb,
> + u64 ino, u32 generation)
Heh, do we have to name this kernfs_nfs_get_inode()? I think it'd be
nice to give it a different name and add a comment explaining the goal
of the interface.
Also, I think it probably would be better to make this an optional
feature of kernfs. sysfs has no need to provide something like this
yet.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-05-23 18:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 22:53 [PATCH 0/5] kernfs: add exportfs operations Shaohua Li
2017-05-22 22:53 ` [PATCH 1/5] kernfs: implement i_generation Shaohua Li
2017-05-23 7:41 ` Christoph Hellwig
2017-05-23 15:09 ` Shaohua Li
2017-05-23 19:20 ` Tejun Heo
2017-05-24 17:40 ` Christoph Hellwig
2017-05-22 22:53 ` [PATCH 2/5] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-05-22 22:53 ` [PATCH 3/5] kernfs: add an API to get kernfs node from " Shaohua Li
2017-05-22 22:53 ` [PATCH 4/5] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-05-23 18:37 ` Tejun Heo
2017-05-22 22:53 ` [PATCH 5/5] kernfs: add exportfs operations Shaohua Li
2017-05-23 7:40 ` Christoph Hellwig
2017-05-23 18:57 ` Tejun Heo
2017-05-24 17:38 ` Christoph Hellwig
2017-05-24 17:39 ` Tejun Heo
2017-05-24 17:41 ` Christoph Hellwig
2017-05-24 17:46 ` Tejun Heo
2017-05-24 18:01 ` Shaohua Li
2017-05-23 18:59 ` Tejun Heo [this message]
2017-05-23 7:39 ` [PATCH 0/5] " Christoph Hellwig
2017-05-23 15:13 ` Shaohua Li
2017-05-23 19:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523185927.GC13222@htj.duckdns.org \
--to=tj@kernel.org \
--cc=Kernel-team@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).