linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>, Shaohua Li <shli@fb.com>,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	viro@zeniv.linux.org.uk, Kernel-team@fb.com
Subject: Re: [PATCH 5/5] kernfs: add exportfs operations
Date: Wed, 24 May 2017 10:38:22 -0700	[thread overview]
Message-ID: <20170524173822.GB13151@infradead.org> (raw)
In-Reply-To: <20170523185711.GB13222@htj.duckdns.org>

On Tue, May 23, 2017 at 02:57:11PM -0400, Tejun Heo wrote:
> 
> Yeah, this is one of the repeatedly requested features - a cgroup id
> which can be looked up in a scalable way.  We probably should have
> added this earlier too as we already have places where we're passing
> in full cgroup path into the kernel (ipt_cgroup match).

I still have no idea how this ties into export ops.  Currently I don't
see any tracing code using export operations, so maybe a big part of
the series is missing/

> IIUC, Shaohua is adding it so that block tracing can be made aware of
> cgroups but something like this is necessary whenever we try to refer
> to a cgroup in a race-free / scalable way.

You can already get i_ino using statx, and i_generation using
FS_IOC_GETVERSION, so I'm a little lost on why you need the full
exportfs infrastructure.

  reply	other threads:[~2017-05-24 17:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 22:53 [PATCH 0/5] kernfs: add exportfs operations Shaohua Li
2017-05-22 22:53 ` [PATCH 1/5] kernfs: implement i_generation Shaohua Li
2017-05-23  7:41   ` Christoph Hellwig
2017-05-23 15:09     ` Shaohua Li
2017-05-23 19:20       ` Tejun Heo
2017-05-24 17:40       ` Christoph Hellwig
2017-05-22 22:53 ` [PATCH 2/5] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-05-22 22:53 ` [PATCH 3/5] kernfs: add an API to get kernfs node from " Shaohua Li
2017-05-22 22:53 ` [PATCH 4/5] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-05-23 18:37   ` Tejun Heo
2017-05-22 22:53 ` [PATCH 5/5] kernfs: add exportfs operations Shaohua Li
2017-05-23  7:40   ` Christoph Hellwig
2017-05-23 18:57     ` Tejun Heo
2017-05-24 17:38       ` Christoph Hellwig [this message]
2017-05-24 17:39         ` Tejun Heo
2017-05-24 17:41           ` Christoph Hellwig
2017-05-24 17:46             ` Tejun Heo
2017-05-24 18:01               ` Shaohua Li
2017-05-23 18:59   ` Tejun Heo
2017-05-23  7:39 ` [PATCH 0/5] " Christoph Hellwig
2017-05-23 15:13   ` Shaohua Li
2017-05-23 19:06 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170524173822.GB13151@infradead.org \
    --to=hch@infradead.org \
    --cc=Kernel-team@fb.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@fb.com \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).