From: Martin Fuzzey <mfuzzey@parkeon.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] firmware: request_firmware() should propagate -ERESTARTSYS
Date: Tue, 23 May 2017 15:16:07 +0200 [thread overview]
Message-ID: <20170523131607.28138.12306.stgit@localhost> (raw)
When -ERESTARTSYS is returned by wait_* due to a signal this should
be returned from request_firmware() so that the syscall may be
restarted if necessary.
Without this it is not possible to distinguish the case of
request_firmware() failing due to a timeout with that due to a signal.
In my particular case request_firmware() was being called from
a sysfs .store() callback and the writing process was the
Android init process which received a SIGCHLD causing
request_firmware() to fail.
Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
---
drivers/base/firmware_class.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index b616bf7..13ed62f 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1023,9 +1023,10 @@ static int _request_firmware_load(struct firmware_priv *fw_priv,
mutex_unlock(&fw_lock);
}
- if (fw_state_is_aborted(&buf->fw_st))
- retval = -EAGAIN;
- else if (buf->is_paged_buf && !buf->data)
+ if (fw_state_is_aborted(&buf->fw_st)) {
+ if (retval != -ERESTARTSYS)
+ retval = -EAGAIN;
+ } else if (buf->is_paged_buf && !buf->data)
retval = -ENOMEM;
device_del(f_dev);
next reply other threads:[~2017-05-23 13:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 13:16 Martin Fuzzey [this message]
2017-05-23 13:31 ` [PATCH] firmware: request_firmware() should propagate -ERESTARTSYS Greg Kroah-Hartman
2017-05-23 14:32 ` Martin Fuzzey
2017-05-23 19:55 ` Luis R. Rodriguez
2017-05-24 20:56 ` Luis R. Rodriguez
2017-05-24 21:40 ` [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback Luis R. Rodriguez
2017-05-24 22:00 ` Andy Lutomirski
2017-05-24 22:38 ` Luis R. Rodriguez
2017-05-25 4:13 ` Andy Lutomirski
2017-05-25 8:28 ` Fuzzey, Martin
2017-05-26 11:09 ` Eric W. Biederman
2017-05-26 19:46 ` Luis R. Rodriguez
2017-05-26 21:26 ` Dmitry Torokhov
2017-05-26 21:32 ` Luis R. Rodriguez
2017-05-26 21:55 ` Dmitry Torokhov
2017-06-05 20:24 ` Luis R. Rodriguez
2017-06-06 9:04 ` Martin Fuzzey
2017-06-06 16:34 ` Luis R. Rodriguez
2017-06-06 17:52 ` Luis R. Rodriguez
2017-06-06 14:53 ` Alan Cox
2017-06-06 16:47 ` Luis R. Rodriguez
2017-06-06 17:54 ` Luis R. Rodriguez
2017-06-06 22:11 ` Theodore Ts'o
2017-06-07 0:22 ` Luis R. Rodriguez
2017-06-07 4:56 ` Andy Lutomirski
2017-06-07 6:25 ` Dmitry Torokhov
2017-06-07 12:25 ` Alan Cox
2017-06-07 17:15 ` Luis R. Rodriguez
2017-06-09 1:14 ` Andy Lutomirski
2017-06-09 1:33 ` Luis R. Rodriguez
2017-06-09 21:29 ` Luis R. Rodriguez
2017-05-26 19:40 ` Luis R. Rodriguez
2017-05-26 20:23 ` Fuzzey, Martin
2017-05-26 20:52 ` Luis R. Rodriguez
2017-06-07 17:08 ` Luis R. Rodriguez
2017-06-07 17:54 ` Martin Fuzzey
2017-06-09 1:10 ` Luis R. Rodriguez
2017-06-09 1:57 ` Luis R. Rodriguez
2017-06-09 7:40 ` Martin Fuzzey
2017-06-09 21:12 ` Luis R. Rodriguez
2017-06-09 22:55 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523131607.28138.12306.stgit@localhost \
--to=mfuzzey@parkeon.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).